I would like to correct whitespace in the template for the Z39.50 search window in cataloging: Convert tabs to spaces, trim trailing spaces, reindent.
Created attachment 91483 [details] [review] Bug 23304: Reindent cataloguing/z3950_search.tt This patch reindents cataloguing/z3950_search.tt to use four spaces and to eliminate tabs, following coding guidelines. Trailing white space has been removed, and some minor markup errors have been corrected for validity. To test, apply the patch and use your preferred method for checking the differences between files while ignoring whitespace. I use diff with the "-w" flag, but I'm not giving orders, you do you. Go to Cataloging -> New from Z39.50/SRU. Test that the search form and results look correct and work correctly.
Created attachment 91490 [details] [review] Bug 22304: (follow-up) Add markup structure comments This patch adds comments to the template to highlight the markup structure. It also removes the obsolete "type" attribute from the <script> tag. This patch should have no effect on the interface or functionality.
Created attachment 91491 [details] [review] Bug 22304: (follow-up) Add markup structure comments This patch adds comments to the template to highlight the markup structure. It also removes the obsolete "type" attribute from the <script> tag. This patch should have no effect on the interface or functionality.
Created attachment 91498 [details] [review] Bug 23304: Reindent cataloguing/z3950_search.tt This patch reindents cataloguing/z3950_search.tt to use four spaces and to eliminate tabs, following coding guidelines. Trailing white space has been removed, and some minor markup errors have been corrected for validity. To test, apply the patch and use your preferred method for checking the differences between files while ignoring whitespace. I use diff with the "-w" flag, but I'm not giving orders, you do you. Go to Cataloging -> New from Z39.50/SRU. Test that the search form and results look correct and work correctly. Signed-off-by: Nadine Pierre <nadine.pierre@inLibro.com>
Created attachment 91499 [details] [review] Bug 22304: (follow-up) Add markup structure comments This patch adds comments to the template to highlight the markup structure. It also removes the obsolete "type" attribute from the <script> tag. This patch should have no effect on the interface or functionality. https://bugs.koha-community.org/show_bug.cgi?id=23304 Signed-off-by: Nadine Pierre <nadine.pierre@inLibro.com>
Created attachment 91635 [details] [review] Bug 23304: Reindent cataloguing/z3950_search.tt This patch reindents cataloguing/z3950_search.tt to use four spaces and to eliminate tabs, following coding guidelines. Trailing white space has been removed, and some minor markup errors have been corrected for validity. To test, apply the patch and use your preferred method for checking the differences between files while ignoring whitespace. I use diff with the "-w" flag, but I'm not giving orders, you do you. Go to Cataloging -> New from Z39.50/SRU. Test that the search form and results look correct and work correctly. Signed-off-by: Nadine Pierre <nadine.pierre@inLibro.com> Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Created attachment 91636 [details] [review] Bug 22304: (follow-up) Add markup structure comments This patch adds comments to the template to highlight the markup structure. It also removes the obsolete "type" attribute from the <script> tag. This patch should have no effect on the interface or functionality. https://bugs.koha-community.org/show_bug.cgi?id=23304 Signed-off-by: Nadine Pierre <nadine.pierre@inLibro.com> Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Nice work! Pushed to master for 19.11.00
Pushed to 19.05.x for 19.05.03