| Summary: | Elasticsearch - Record matching fails when multiple keys exist | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Nick Clemens (kidclamp) <nick> |
| Component: | Searching - Elasticsearch | Assignee: | Nick Clemens (kidclamp) <nick> |
| Status: | CLOSED FIXED | QA Contact: | Martin Renvoize (ashimema) <martin.renvoize> |
| Severity: | major | ||
| Priority: | P5 - low | CC: | fridolin.somers, glasklas, johanna.raisa, lucas, martin.renvoize |
| Version: | Main | ||
| Hardware: | All | ||
| OS: | All | ||
| See Also: | https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22545 | ||
| Change sponsored?: | --- | Patch complexity: | Trivial patch |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: |
19.11.00,19.05.03
|
|
| Circulation function: | |||
| Bug Depends on: | |||
| Bug Blocks: | 23324 | ||
| Attachments: |
Test record
Bug 23322: Correct case for boolean in ES search Bug 23322: Correct case for boolean in ES search Bug 23322: Correct case for boolean in ES search |
||
|
Description
Nick Clemens (kidclamp)
2019-07-16 12:08:19 UTC
Created attachment 91547 [details]
Test record
Created attachment 91548 [details] [review] Bug 23322: Correct case for boolean in ES search I did not include tests only because this is a very small reasonable change and routine has no tests. It does not affect behaviour, it only touches syntax lightly. To test: 0 - Set SearchEngine to ElasticSearch 1 - Import the example record (a version is included in sample data in devbox/testing docker so you can skip) 2 - Stage the attached example record 3 - Match using 'ISBN' rule 4 - No matches found 5 - Apply patch 6 - Restart all the things 7 - Reapply matching with no rule 8 - Reapply with ISBN matcing 9 - It matches! 10 - Set SearchEngine to Zebra 11 - Reapply matching with no rule 12 - Reapply with ISBN matching 13 - Matching works as before in Zebra Created attachment 91556 [details] [review] Bug 23322: Correct case for boolean in ES search I did not include tests only because this is a very small reasonable change and routine has no tests. It does not affect behaviour, it only touches syntax lightly. To test: 0 - Set SearchEngine to ElasticSearch 1 - Import the example record (a version is included in sample data in devbox/testing docker so you can skip) 2 - Stage the attached example record 3 - Match using 'ISBN' rule 4 - No matches found 5 - Apply patch 6 - Restart all the things 7 - Reapply matching with no rule 8 - Reapply with ISBN matcing 9 - It matches! 10 - Set SearchEngine to Zebra 11 - Reapply matching with no rule 12 - Reapply with ISBN matching 13 - Matching works as before in Zebra Signed-off-by: Ron Houk <rhouk@ottumwapubliclibrary.org> Created attachment 92067 [details] [review] Bug 23322: Correct case for boolean in ES search I did not include tests only because this is a very small reasonable change and routine has no tests. It does not affect behaviour, it only touches syntax lightly. To test: 0 - Set SearchEngine to ElasticSearch 1 - Import the example record (a version is included in sample data in devbox/testing docker so you can skip) 2 - Stage the attached example record 3 - Match using 'ISBN' rule 4 - No matches found 5 - Apply patch 6 - Restart all the things 7 - Reapply matching with no rule 8 - Reapply with ISBN matcing 9 - It matches! 10 - Set SearchEngine to Zebra 11 - Reapply matching with no rule 12 - Reapply with ISBN matching 13 - Matching works as before in Zebra Signed-off-by: Ron Houk <rhouk@ottumwapubliclibrary.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Trivial patch, works as expected.. would have been nice to have a unit test for it.. but as it's ES dependant I'm not going to fail it for that. Passing QA Nice work! Pushed to master for 19.11.00 Pushed to 19.05.x for 19.05.03 backported to 18.11.x for 18.11.09 *** Bug 22545 has been marked as a duplicate of this bug. *** *** Bug 19197 has been marked as a duplicate of this bug. *** |