Bug 23349

After checking one box and selecting "Batch delete" the following message appears: "You must select at least one record." 

The rest of the testing was successful.

Hi Owen,

We applied the patch and saw the Edit button but when we checked one of the search, edit button was still disabled.

Created attachment 102620 [details] [review]
Bug 23349: Add batch operations to staff interface catalog search results

This patch adds three new options to the staff interface catalog search
results for users with cataloging permission: batch edit, batch delete,
and merge. The choices are found in an "Edit" menu which is disabled by
default. Checking any boxes in the search results table enables the
button.

To test, apply the patch and log in to Koha as a user with
edit_catalogue permission.

 - Perform a search in the catalog
 - You should see a disabled "Edit" button in the toolbar at the top of
   the search results table.
 - Check a single checkbox. The button should become enabled.
   - Test the "Batch edit" and "Batch delete" menu items. They should
     work correctly.
   - Test the "Merge records" item. It should warn you that you must
     select at least two records.
 - Check more than one checkbox and test each menu item again. All
   should work as expected.
 - Log in to the staff client as a user who does not have edit_catalogue
   permission. The "Edit" menu should no longer appear on the search
   results page.

(In reply to Abbey Holt from comment #2)
> After checking one box and selecting "Batch delete" the following message
> appears: "You must select at least one record." 

This should now be fixed.


(In reply to Devinim from comment #3)
> We applied the patch and saw the Edit button but when we checked one of the
> search, edit button was still disabled.

I could not reproduce this problem. Could you clear your browser cache and try the new patch? Thanks!

Created attachment 102621 [details] [review]
Bug 23349: Add batch operations to staff interface catalog search results

This patch adds three new options to the staff interface catalog search
results for users with cataloging permission: batch edit, batch delete,
and merge. The choices are found in an "Edit" menu which is disabled by
default. Checking any boxes in the search results table enables the
button.

To test, apply the patch and log in to Koha as a user with
edit_catalogue permission.

 - Perform a search in the catalog
 - You should see a disabled "Edit" button in the toolbar at the top of
   the search results table.
 - Check a single checkbox. The button should become enabled.
   - Test the "Batch edit" and "Batch delete" menu items. They should
     work correctly.
   - Test the "Merge records" item. It should warn you that you must
     select at least two records.
 - Check more than one checkbox and test each menu item again. All
   should work as expected.
 - Log in to the staff client as a user who does not have edit_catalogue
   permission. The "Edit" menu should no longer appear on the search
   results page.

Signed-off-by: Abbey Holt <aholt@dubuque.lib.ia.us>

Changing status to "Signed off" based on comment 6.

Hi Owen, please check the strings in the js file - they are not showing up for me in the *messages-js.po file!

Created attachment 103171 [details] [review]
Bug 23349: (follow-up) Correct translation function

This patch corrects the translation function inside results.js. It
should be two underscores instead of one.

Created attachment 103190 [details] [review]
Bug 23349: Add batch operations to staff interface catalog search results

This patch adds three new options to the staff interface catalog search
results for users with cataloging permission: batch edit, batch delete,
and merge. The choices are found in an "Edit" menu which is disabled by
default. Checking any boxes in the search results table enables the
button.

To test, apply the patch and log in to Koha as a user with
edit_catalogue permission.

 - Perform a search in the catalog
 - You should see a disabled "Edit" button in the toolbar at the top of
   the search results table.
 - Check a single checkbox. The button should become enabled.
   - Test the "Batch edit" and "Batch delete" menu items. They should
     work correctly.
   - Test the "Merge records" item. It should warn you that you must
     select at least two records.
 - Check more than one checkbox and test each menu item again. All
   should work as expected.
 - Log in to the staff client as a user who does not have edit_catalogue
   permission. The "Edit" menu should no longer appear on the search
   results page.

Signed-off-by: Abbey Holt <aholt@dubuque.lib.ia.us>

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>

Created attachment 103191 [details] [review]
Bug 23349: (follow-up) Correct translation function

This patch corrects the translation function inside results.js. It
should be two underscores instead of one.

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>

One of Owen's magical patches :)

I only have one little concern/thing I am not sure about, maybe to have a second look at later: If you check the checkboxes, choose one of the batch features and then use "back" in the browser (maybe you have chosen the wrong one), the checkboxes are still checked, but the "Edit" pull down is disabled.
You have to uncheck/check something for it to unlock again.

Another little thing: We have the browse feature now that can carry checkboxes over multiple pages - having the edit do this as well would be pretty awesome.

This will still ease people's pain a lot, especially when merging records. It's always a bit hard to explain in training that you have to use the more limited cataloguing search for this.

Nice work everyone!

Pushed to master for 20.05

enhancement not backported to 19.11.x