| Summary: | Rancor fails to load: insert_copyright is not defined | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Cori Lynn Arnold <carnold> |
| Component: | Installation and upgrade (web-based installer) | Assignee: | Nick Clemens (kidclamp) <nick> |
| Status: | CLOSED FIXED | QA Contact: | Tomás Cohen Arazi (tcohen) <tomascohen> |
| Severity: | critical | ||
| Priority: | P5 - low | CC: | fridolin.somers, gmcharlt, tomascohen |
| Version: | 19.05 | ||
| Hardware: | All | ||
| OS: | All | ||
| Change sponsored?: | --- | Patch complexity: | Small patch |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: |
19.11.00,19.05.03
|
|
| Circulation function: | |||
| Bug Depends on: | 17178, 21411 | ||
| Bug Blocks: | |||
| Attachments: |
Screenshot from Chrome
Bug 23396: Add keyboard_shortcuts.sql to C4/Installer.pm Bug 23396: Add keyboard_shortcuts.sql to C4/Installer.pm Bug 23396: Add keyboard_shortcuts.sql to C4/Installer.pm Bug 23396: (QA follow-up) Add atomic update |
||
This bug only happened for me when starting with a blank database. I tested with 16.11.x and 18.11.x databases and didn't get the error. Created attachment 91873 [details] [review] Bug 23396: Add keyboard_shortcuts.sql to C4/Installer.pm To test: 1 - Back up your DB if you want to save it 2 - sudo koha-mysql kohadev DROP database koha_kohadev; CREATE database koha_kohadev; 3 - http://localhost:8081 4 - Go through the web installer 5 - Enable AdvancedCatalogingEditor 6 - Try to load it, fails with JS console error: insert_copyright is not defined 7 - Apply patch 8 - Repeat 9 - This time editor loads Created attachment 91886 [details] [review] Bug 23396: Add keyboard_shortcuts.sql to C4/Installer.pm To test: 1 - Back up your DB if you want to save it 2 - sudo koha-mysql kohadev DROP database koha_kohadev; CREATE database koha_kohadev; 3 - http://localhost:8081 4 - Go through the web installer 5 - Enable AdvancedCatalogingEditor 6 - Try to load it, fails with JS console error: insert_copyright is not defined 7 - Apply patch 8 - Repeat 9 - This time editor loads Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Should we add an update database entry to fix this for existing installations? (In reply to Katrin Fischer from comment #4) > Should we add an update database entry to fix this for existing > installations? I think we should. We already got people installing 19.05 for production use and we could just repeat the initial database update from introducing the feature with a check for data already being there. Created attachment 91937 [details] [review] Bug 23396: Add keyboard_shortcuts.sql to C4/Installer.pm To test: 1 - Back up your DB if you want to save it 2 - sudo koha-mysql kohadev DROP database koha_kohadev; CREATE database koha_kohadev; 3 - http://localhost:8081 4 - Go through the web installer 5 - Enable AdvancedCatalogingEditor 6 - Try to load it, fails with JS console error: insert_copyright is not defined 7 - Apply patch 8 - Repeat 9 - This time editor loads Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Created attachment 91938 [details] [review] Bug 23396: (QA follow-up) Add atomic update New installs before the fix won't have the table populated, this patch adds a fix for that, including the shortcut added by bug 17178. Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Nice work! Pushed to master for 19.11.00 |
Created attachment 91854 [details] Screenshot from Chrome The Advanced Editor fails to load on 19.05 with the error message: marc-editor.js:140 Uncaught ReferenceError: insert_copyright is not defined at marc-editor.js:140 at Object.execCb (require_19.0502000.js:29) at X.check (require_19.0502000.js:18) at X.<anonymous> (require_19.0502000.js:23) at require_19.0502000.js:8 at require_19.0502000.js:23 at y (require_19.0502000.js:7) at X.emit (require_19.0502000.js:23) at X.check (require_19.0502000.js:19) at X.<anonymous> (require_19.0502000.js:23) used Chrome and Firefox.