Bug 17178 - Add a popup/keyboard shortcuts for diacritics and symbols in the advanced cataloging editor
Summary: Add a popup/keyboard shortcuts for diacritics and symbols in the advanced cat...
Status: Signed Off
Alias: None
Product: Koha
Classification: Unclassified
Component: Cataloging (show other bugs)
Version: master
Hardware: All All
: P5 - low enhancement with 1 vote (vote)
Target Milestone: ---
Assignee: Agustín Moyano
QA Contact: Testopia
URL: https://gitlab.com/thekesolutions/Koh...
Whiteboard:
Keywords:
Depends on: 21411
Blocks:
  Show dependency treegraph
 
Reported: 2016-08-24 00:29 UTC by Nick Clemens
Modified: 2019-05-15 19:04 UTC (History)
4 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Small patch
Bot Control: ---
When did the bot last check this:
Who signed the patch off:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 17178: Add shortcut to keyboard_shortcut table (2.00 KB, patch)
2019-05-15 13:37 UTC, Agustín Moyano
Details | Diff | Splinter Review
Bug 17178: Add shortcut to keyboard_shortcut table (2.05 KB, patch)
2019-05-15 19:03 UTC, Liz Rea
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Nick Clemens 2016-08-24 00:29:14 UTC
Work to be done:

1) Add a dialog, accessible by keyboard shortcut, that shows a variety of special characters that can then be entered by clicking or choosing a keyboard shortcut.
2) These characters should include, at a minimum, Spanish language characters and the copyright/published symbols.
Comment 1 Irma Birchall 2016-10-10 03:48:27 UTC
3) Also macrons like in the word ‘Māori’ should be included.
A macron is a line above a vowel to indicate that it should be spoken as a long vowel: ā, ē, ī, ō, ū, Ā, Ē, Ī, Ō and Ū.  The Māori word for macron is tohutō (or pōtae - hat). For more detailed information on its use, see Māori Orthographic Conventions.
Comment 2 Tomás Cohen Arazi 2019-04-17 14:50:07 UTC
Maybe using this?

https://www.npmjs.com/package/simple-keyboard-layouts
Comment 3 Agustín Moyano 2019-04-24 00:29:02 UTC
I see advanced editor already has this functionality.. 

Is this intended for basic editor, or is this duplicate of 18417?
Comment 4 Nick Clemens 2019-04-24 10:20:07 UTC
I think the idea here is broader than the other bug.

The idea would be a graphical interface to select accented characters when using a keyboard that does not contains those characters or a way to easily enter them.

i.e. 
I would be able to press a keyboard-shortcut
A modal or popup would open that would contain a character map, showing various forms of different letters with accents,umlauts, etc.
I would be able to use either the mouse or keys on the beyboard to select the letter I want
The letter would then be inserted where the cursor was located in the editor
Comment 5 Agustín Moyano 2019-05-15 13:37:16 UTC
Created attachment 89784 [details] [review]
Bug 17178: Add shortcut to keyboard_shortcut table

This patch adds Ctrl-K shortcut to toggle virtual keyboard shortcut

Sponsored-by: Round Rock Public Library
Comment 6 Agustín Moyano 2019-05-15 13:48:45 UTC
Sorry, last patch gives 'request entity too large'

Please use https://gitlab.com/thekesolutions/Koha/tree/bug-17178

The patches are the last 2 commits.
Comment 7 Agustín Moyano 2019-05-15 14:04:17 UTC
> Please use https://gitlab.com/thekesolutions/Koha/tree/bug-17178

I dont know if I expressed my self correctly..
I ment use this repo https://gitlab.com/thekesolutions/Koha with branch bug-17178 

Thanks
Comment 8 Liz Rea 2019-05-15 16:59:44 UTC
Hi,

For the Māori keyboard, I didn't see how to add the tohutō, we may need to add a layout for it like they recommend here? https://github.com/hodgef/simple-keyboard-layouts/wiki/Supported-Layouts

I know that it's a relatively obscure language to ensure support for, but it's important because Koha comes from New Zealand.

Otherwise, functionally this works fine. I think if we just add a layout for Māori, either just for us or to the originating project, this should be good to go.

I might be convinced to make all of that a follow up bug as well, so this one can move on. :)

Does anyone else have opinions about this?

Cheers,
Liz
Comment 9 Tomás Cohen Arazi 2019-05-15 17:37:02 UTC
(In reply to Liz Rea from comment #8)
> 
> I know that it's a relatively obscure language to ensure support for, but
> it's important because Koha comes from New Zealand.

We should support it.

> Otherwise, functionally this works fine. I think if we just add a layout for
> Māori, either just for us or to the originating project, this should be good
> to go.
> 
> I might be convinced to make all of that a follow up bug as well, so this
> one can move on. :)

This seriously belongs to a separate bug.
Comment 10 Liz Rea 2019-05-15 19:00:48 UTC
The feature works well and it will be a relatively small job to add the Māori keyboard layout, good for the academy possibly. Will file another bug to be sure we add it.

Liz
Comment 11 Liz Rea 2019-05-15 19:03:05 UTC
Created attachment 89795 [details] [review]
Bug 17178: Add shortcut to keyboard_shortcut table

This patch adds Ctrl-K shortcut to toggle virtual keyboard shortcut

Sponsored-by: Round Rock Public Library

Signed-off-by: Liz Rea <wizzyrea@gmail.com>
Comment 12 Liz Rea 2019-05-15 19:04:14 UTC
still a problem with request entity too large, but you can get the patch (which should have an implied sign off from me) from Theke's gitlab.

Liz