Summary: | Add a holds routine to Koha::Items to fetch related holds | ||
---|---|---|---|
Product: | Koha | Reporter: | Nick Clemens <nick> |
Component: | Architecture, internals, and plumbing | Assignee: | Nick Clemens <nick> |
Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
Severity: | normal | ||
Priority: | P5 - low | CC: | fridolin.somers, jonathan.druart, katrin.fischer, martin.renvoize, maryse.simard |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | Trivial patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: |
19.11.00
|
|
Attachments: |
Bug 23413: Add a holds method to Koha::Items
Bug 23413: Add a holds method to Koha::Items Bug 23413: Add a holds method to Koha::Items Bug 23413: (QA follow-up) Fix terminology Bug 23413: (follow-up) Rename variables Bug 23413: Update tests to use build_sample_biblio Bug 23413: Update tests to use build_sample_biblio Bug 23413: Remove wrong return Bug 23413: Fix tests |
Description
Nick Clemens
2019-08-01 18:10:58 UTC
Created attachment 91912 [details] [review] Bug 23413: Add a holds method to Koha::Items To test; 1 - prove -v t/db_dependent/Koha/Items.t Created attachment 92123 [details] [review] Bug 23413: Add a holds method to Koha::Items To test; 1 - prove -v t/db_dependent/Koha/Items.t Signed-off-by: Maryse Simard <maryse.simard@inlibro.com> Created attachment 92128 [details] [review] Bug 23413: Add a holds method to Koha::Items To test; 1 - prove -v t/db_dependent/Koha/Items.t Signed-off-by: Maryse Simard <maryse.simard@inlibro.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Created attachment 92129 [details] [review] Bug 23413: (QA follow-up) Fix terminology Changed the POD of the new method to use holds. Nice work! Pushed to master for 19.11.00 Fix terminology corrects POD, but vars are still incorrect : my $transfer_rs = $self->_result->reserves->search($params); Should be my $holds_rs ? Created attachment 92542 [details] [review] Bug 23413: (follow-up) Rename variables Created attachment 92543 [details] [review] Bug 23413: Update tests to use build_sample_biblio Before these changes the tests fail if run under Elasticsearch This makes sure they pass either way Created attachment 92544 [details] [review] Bug 23413: Update tests to use build_sample_biblio Before these changes the tests fail if run under Elasticsearch This makes sure they pass either way Martin, the follow-ups are not pushed. Also, we should not need the following return statement: 336 return unless $transfer_rs->count; We need it for ->checkout for instance, because it could be undef. But we should not return undef for ->holds, otherwise it will explode on $items->holds->count Created attachment 94686 [details] [review] Bug 23413: Remove wrong return Nice work! Pushed to master for 19.11.00 Created attachment 94722 [details] [review] Bug 23413: Fix tests |