Created attachment 91912 [details] [review] Bug 23413: Add a holds method to Koha::Items To test; 1 - prove -v t/db_dependent/Koha/Items.t
Created attachment 92123 [details] [review] Bug 23413: Add a holds method to Koha::Items To test; 1 - prove -v t/db_dependent/Koha/Items.t Signed-off-by: Maryse Simard <maryse.simard@inlibro.com>
Created attachment 92128 [details] [review] Bug 23413: Add a holds method to Koha::Items To test; 1 - prove -v t/db_dependent/Koha/Items.t Signed-off-by: Maryse Simard <maryse.simard@inlibro.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Created attachment 92129 [details] [review] Bug 23413: (QA follow-up) Fix terminology Changed the POD of the new method to use holds.
Nice work! Pushed to master for 19.11.00
Fix terminology corrects POD, but vars are still incorrect : my $transfer_rs = $self->_result->reserves->search($params); Should be my $holds_rs ?
Created attachment 92542 [details] [review] Bug 23413: (follow-up) Rename variables
Created attachment 92543 [details] [review] Bug 23413: Update tests to use build_sample_biblio Before these changes the tests fail if run under Elasticsearch This makes sure they pass either way
Created attachment 92544 [details] [review] Bug 23413: Update tests to use build_sample_biblio Before these changes the tests fail if run under Elasticsearch This makes sure they pass either way
Martin, the follow-ups are not pushed.
Also, we should not need the following return statement: 336 return unless $transfer_rs->count; We need it for ->checkout for instance, because it could be undef. But we should not return undef for ->holds, otherwise it will explode on $items->holds->count
Created attachment 94686 [details] [review] Bug 23413: Remove wrong return
Created attachment 94722 [details] [review] Bug 23413: Fix tests