|
Description
Emmi Takkinen
2019-08-02 07:42:06 UTC
Created attachment 92039 [details] [review] Bug 23415: Notify patron fines when renewing It is possible to renew items for patron who has fines over accepted limit on renew page or from checkout list. This patch adds confirmation alerts to these renew actions when patron has fines over "noissuescharge" syspref. Test plan: 1. Have patron with checkouts and fines over allowed limit 2. Renew checkouts either from renew page or checkout list => renew is successful 3. Apply patch 4. Repeat steps 1 and 2 => On renew page an alert is displayed and user has to confirm renew => When renew is done from checkout list confirmation pop-up is displayed Created attachment 92541 [details] [review] Bug 23415: Notify patron fines when renewing In previous patch error message wasn't translatable. Fixed that and made sure loading gif on checkout list works correctly after this patch is applied. I'm trying this on a sandbox, but I am not seeing any change in either renewal process with the patch applied. I also tried this patch on a sandbox and the alert was displayed on moremember.pl-page and renew.pl-page. It was not displayed on circulation.pl-page, where it should also appear. Marking FQA because of Anneli's last comment. Can you please give feedback? I tested this again using a sandbox with this bug number (using master) and it worked perfectly well on all three pages. Thx anneli, do you want to add your sign off? Created attachment 98442 [details] [review] Bug 23415: Notify patron fines when renewing It is possible to renew items for patron who has fines over accepted limit on renew page or from checkout list. This patch adds confirmation alerts to these renew actions when patron has fines over "noissuescharge" syspref. Test plan: 1. Have patron with checkouts and fines over allowed limit 2. Renew checkouts either from renew page or checkout list => renew is successful 3. Apply patch 4. Repeat steps 1 and 2 => On renew page an alert is displayed and user has to confirm renew => When renew is done from checkout list confirmation pop-up is displayed Signed-off-by: Anneli Österman <anneli.osterman@koha-suomi.fi> Hi Emmi, there are some fails with the QA tools for missing filters, can you please fix?
FAIL koha-tmpl/intranet-tmpl/prog/en/modules/circ/circulation.tt
FAIL filters
missing_filter at line 1071 ( var amountlimit = "[% Koha.Preference('noissuescharge') %]";)
missing_filter at line 1072 ( var fines = "[% fines %]";)
FAIL koha-tmpl/intranet-tmpl/prog/en/modules/members/moremember.tt
FAIL filters
missing_filter at line 890 ( var amountlimit = "[% Koha.Preference('noissuescharge') %]";)
missing_filter at line 891 ( var fines = "[% fines %]";)
Created attachment 98634 [details] [review] Bug 23415: Add missing filters Created attachment 98996 [details] [review] Bug 23415: Notify patron fines when renewing It is possible to renew items for patron who has fines over accepted limit on renew page or from checkout list. This patch adds confirmation alerts to these renew actions when patron has fines over "noissuescharge" syspref. Test plan: 1. Have patron with checkouts and fines over allowed limit 2. Renew checkouts either from renew page or checkout list => renew is successful 3. Apply patch 4. Repeat steps 1 and 2 => On renew page an alert is displayed and user has to confirm renew => When renew is done from checkout list confirmation pop-up is displayed Signed-off-by: Anneli Österman <anneli.osterman@koha-suomi.fi> Signed-off-by: Kelly McElligott <kelly@bywatersolutions.com> Created attachment 98997 [details] [review] Bug 23415: Add missing filters Signed-off-by: Kelly McElligott <kelly@bywatersolutions.com> I am wondering if noissuecharge is the right value here.
We got:
OPACFineNoRenewals = fine limit for renewals in the OPAC, but nothing for staff specifically.
noissuecharge = fine limit for checkouts (as name says). It's used in this patch set, but there are other complications with this one:
noissuescharge
Prevent patrons from checking out books if they have more than EUR in fines.
HoldsInNoissuesCharge
[Don't include|Include] hold charges when summing up charges for noissuescharge.
ManInvInNoissuesCharge
[Don't include|Include] custom debit type charges when summing up charges for noissuescharge.
RentalsInNoissuesCharge
[Don't include|Include] rental charges when summing up charges for noissuescharge.
NoIssuesChargeGuarantees
Prevent a patron from checking out if the patron has guarantees owing in total more than EUR in fines.
So I think this is not covering it:
+ my $amountlimit = C4::Context->preference("noissuescharge");
+ var fines = "[% fines | html %]
We'd need the amount calculated taking all noissues* prefs into account.
I think I'd prefer not using noissuecharge here, as it only speaks of checkouts and we have a distinct one for renewals. Using OPACFineNoRenewals would make sense to me, as you can still override in the staff interface. So having a 'hint' there would work.
Also a little worried that this adds a confirm step - but as none of the testers complained, I think it's probably ok :)
Created attachment 105893 [details] [review] Bug 23415: Use OPACFineNoRenewals instead of noissuecharge Since noissuecharge is mainly fine limit for checkouts it's more logical to use value in OPACFineNoRenewals. Sponsored-by: Koha-Suomi Oy Created attachment 105894 [details] [review] Bug 23415: Display confirm dialog only once On detail page when patron has multiple holds and they are renewed from checkouts list, confirmation dialog box is displayed as many times as patron has holds. This patch reworks some code so this dialog box is displayed only once. To test: 1. Find patron with multiple holds (at least two) 2. Renew all holds from checkout list 3. Confirmation pop-up is displayed for every hold 4. Apply this patch 5. Renew again => Confirmation dialog box is displayed only once Sponsored-by: Koha-Suomi Oy Created attachment 108392 [details] [review] Bug 23415: Display confirm dialog only once On detail page when patron has multiple checkouts and they are renewed from checkouts list, confirmation dialog box is displayed as many times as patron has checkouts. This patch reworks some code so this dialog box is displayed only once. To test: 1. Find patron with multiple checkouts (at least two) 2. Renew all checkouts from checkout list 3. Confirmation pop-up is displayed for every checkout 4. Apply this patch 5. Renew again => Confirmation dialog box is displayed only once Sponsored-by: Koha-Suomi Oy Created attachment 109871 [details] [review] Bug 23415: Notify patron fines when renewing It is possible to renew items for patron who has fines over accepted limit on renew page or from checkout list. This patch adds confirmation alerts to these renew actions when patron has fines over "noissuescharge" syspref. Test plan: 1. Have patron with checkouts and fines over allowed limit 2. Renew checkouts either from renew page or checkout list => renew is successful 3. Apply patch 4. Repeat steps 1 and 2 => On renew page an alert is displayed and user has to confirm renew => When renew is done from checkout list confirmation pop-up is displayed Signed-off-by: Anneli Österman <anneli.osterman@koha-suomi.fi> Signed-off-by: Kelly McElligott <kelly@bywatersolutions.com> Created attachment 109872 [details] [review] Bug 23415: Add missing filters Signed-off-by: Kelly McElligott <kelly@bywatersolutions.com> Created attachment 109876 [details] [review] Bug 23415: Use OPACFineNoRenewals instead of noissuecharge Since noissuecharge is mainly fine limit for checkouts it's more logical to use value in OPACFineNoRenewals. Sponsored-by: Koha-Suomi Oy Created attachment 109880 [details] [review] Bug 23415: Display confirm dialog only once On detail page when patron has multiple checkouts and they are renewed from checkouts list, confirmation dialog box is displayed as many times as patron has checkouts. This patch reworks some code so this dialog box is displayed only once. To test: 1. Find patron with multiple checkouts (at least two) 2. Renew all checkouts from checkout list 3. Confirmation pop-up is displayed for every checkout 4. Apply this patch 5. Renew again => Confirmation dialog box is displayed only once Sponsored-by: Koha-Suomi Oy Rebased patches against current master. Applying: Bug 23415: Notify patron fines when renewing Using index info to reconstruct a base tree... M circ/circulation.pl M circ/renew.pl M koha-tmpl/intranet-tmpl/prog/en/modules/circ/circulation.tt M koha-tmpl/intranet-tmpl/prog/en/modules/circ/renew.tt M koha-tmpl/intranet-tmpl/prog/en/modules/members/moremember.tt M koha-tmpl/intranet-tmpl/prog/js/checkouts.js Falling back to patching base and 3-way merge... Auto-merging koha-tmpl/intranet-tmpl/prog/js/checkouts.js CONFLICT (content): Merge conflict in koha-tmpl/intranet-tmpl/prog/js/checkouts.js Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/members/moremember.tt Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/circ/renew.tt Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/circ/circulation.tt Auto-merging circ/renew.pl Auto-merging circ/circulation.pl error: Failed to merge in the changes. Patch failed at 0001 Bug 23415: Notify patron fines when renewing The copy of the patch that failed is found in: .git/rebase-apply/patch When you have resolved this problem run "git bz apply --continue". If you would prefer to skip this patch, instead run "git bz apply --skip". To restore the original branch and stop patching run "git bz apply --abort". Patch left in /tmp/Bug-23415-Notify-patron-fines-when-renewing-AHlD9r.patch Created attachment 116919 [details] [review] Bug 23415: Notify patron fines when renewing It is possible to renew items for patron who has fines over accepted limit on renew page or from checkout list. This patch adds confirmation alerts to these renew actions when patron has fines over "noissuescharge" syspref. Test plan: 1. Have patron with checkouts and fines over allowed limit 2. Renew checkouts either from renew page or checkout list => renew is successful 3. Apply patch 4. Repeat steps 1 and 2 => On renew page an alert is displayed and user has to confirm renew => When renew is done from checkout list confirmation pop-up is displayed Signed-off-by: Anneli Österman <anneli.osterman@koha-suomi.fi> Signed-off-by: Kelly McElligott <kelly@bywatersolutions.com> Created attachment 116920 [details] [review] Bug 23415: Add missing filters Signed-off-by: Kelly McElligott <kelly@bywatersolutions.com> Created attachment 116921 [details] [review] Bug 23415: Use OPACFineNoRenewals instead of noissuecharge Since noissuecharge is mainly fine limit for checkouts it's more logical to use value in OPACFineNoRenewals. Sponsored-by: Koha-Suomi Oy Created attachment 116922 [details] [review] Bug 23415: Display confirm dialog only once On detail page when patron has multiple checkouts and they are renewed from checkouts list, confirmation dialog box is displayed as many times as patron has checkouts. This patch reworks some code so this dialog box is displayed only once. To test: 1. Find patron with multiple checkouts (at least two) 2. Renew all checkouts from checkout list 3. Confirmation pop-up is displayed for every checkout 4. Apply this patch 5. Renew again => Confirmation dialog box is displayed only once Sponsored-by: Koha-Suomi Oy CONFLICT (content): Merge conflict in koha-tmpl/intranet-tmpl/prog/js/checkouts.js Created attachment 118175 [details] [review] Bug 23415: Notify patron fines when renewing It is possible to renew items for patron who has fines over accepted limit on renew page or from checkout list. This patch adds confirmation alerts to these renew actions when patron has fines over "noissuescharge" syspref. Test plan: 1. Have patron with checkouts and fines over allowed limit 2. Renew checkouts either from renew page or checkout list => renew is successful 3. Apply patch 4. Repeat steps 1 and 2 => On renew page an alert is displayed and user has to confirm renew => When renew is done from checkout list confirmation pop-up is displayed Signed-off-by: Anneli Österman <anneli.osterman@koha-suomi.fi> Signed-off-by: Kelly McElligott <kelly@bywatersolutions.com> Created attachment 118176 [details] [review] Bug 23415: Add missing filters Signed-off-by: Kelly McElligott <kelly@bywatersolutions.com> Created attachment 118177 [details] [review] Bug 23415: Use OPACFineNoRenewals instead of noissuecharge Since noissuecharge is mainly fine limit for checkouts it's more logical to use value in OPACFineNoRenewals. Sponsored-by: Koha-Suomi Oy Created attachment 118178 [details] [review] Bug 23415: Display confirm dialog only once On detail page when patron has multiple checkouts and they are renewed from checkouts list, confirmation dialog box is displayed as many times as patron has checkouts. This patch reworks some code so this dialog box is displayed only once. To test: 1. Find patron with multiple checkouts (at least two) 2. Renew all checkouts from checkout list 3. Confirmation pop-up is displayed for every checkout 4. Apply this patch 5. Renew again => Confirmation dialog box is displayed only once Sponsored-by: Koha-Suomi Oy Created attachment 118183 [details] [review] Bug 23415: Display confirm dialog only once On detail page when patron has multiple checkouts and they are renewed from checkouts list, confirmation dialog box is displayed as many times as patron has checkouts. This patch reworks some code so this dialog box is displayed only once. To test: 1. Find patron with multiple checkouts (at least two) 2. Renew all checkouts from checkout list 3. Confirmation pop-up is displayed for every checkout 4. Apply this patch 5. Renew again => Confirmation dialog box is displayed only once Sponsored-by: Koha-Suomi Oy Signed-off-by: Stina Hallin <stina.hallin@ub.lu.se> Created attachment 119300 [details] [review] Bug 23415: Notify patron fines when renewing It is possible to renew items for patron who has fines over accepted limit on renew page or from checkout list. This patch adds confirmation alerts to these renew actions when patron has fines over "noissuescharge" syspref. Test plan: 1. Have patron with checkouts and fines over allowed limit 2. Renew checkouts either from renew page or checkout list => renew is successful 3. Apply patch 4. Repeat steps 1 and 2 => On renew page an alert is displayed and user has to confirm renew => When renew is done from checkout list confirmation pop-up is displayed Signed-off-by: Anneli Österman <anneli.osterman@koha-suomi.fi> Signed-off-by: Kelly McElligott <kelly@bywatersolutions.com> Signed-off-by: Petro Vashchuk <stalkernoid@gmail.com> Created attachment 119301 [details] [review] Bug 23415: Add missing filters Signed-off-by: Kelly McElligott <kelly@bywatersolutions.com> Signed-off-by: Petro Vashchuk <stalkernoid@gmail.com> Created attachment 119302 [details] [review] Bug 23415: Use OPACFineNoRenewals instead of noissuecharge Since noissuecharge is mainly fine limit for checkouts it's more logical to use value in OPACFineNoRenewals. Sponsored-by: Koha-Suomi Oy Signed-off-by: Petro Vashchuk <stalkernoid@gmail.com> Created attachment 119303 [details] [review] Bug 23415: Display confirm dialog only once On detail page when patron has multiple checkouts and they are renewed from checkouts list, confirmation dialog box is displayed as many times as patron has checkouts. This patch reworks some code so this dialog box is displayed only once. To test: 1. Find patron with multiple checkouts (at least two) 2. Renew all checkouts from checkout list 3. Confirmation pop-up is displayed for every checkout 4. Apply this patch 5. Renew again => Confirmation dialog box is displayed only once Sponsored-by: Koha-Suomi Oy Signed-off-by: Stina Hallin <stina.hallin@ub.lu.se> Signed-off-by: Petro Vashchuk <stalkernoid@gmail.com> I think OPACFineNoRenewals needs to be renamed to FineNoRenewals or something along those lines to prevent confusion in the future. (In reply to Kyle M Hall from comment #37) > I think OPACFineNoRenewals needs to be renamed to FineNoRenewals or > something along those lines to prevent confusion in the future. Makes sense...maybe it should also be moved from OPAC preferences to Circulation preferences. Created attachment 121472 [details] [review] Bug 23415: Rename OPACFineNoRenewals OPACFineNoRenewals no longer applies just to OPAC. To avoid confusion rename it as FineNoRenewals and also rename all occurences in code. To test, confirm everything works as described in previous test plans. Also prove t/db_dependent/Circulation.t Patch doesn't apply. Please rebase. Created attachment 139670 [details] [review] Bug 23415: Notify patron fines when renewing It is possible to renew items for patron who has fines over accepted limit on renew page or from checkout list. This patch adds confirmation alerts to these renew actions when patron has fines over "noissuescharge" syspref. Test plan: 1. Have patron with checkouts and fines over allowed limit 2. Renew checkouts either from renew page or checkout list => renew is successful 3. Apply patch 4. Repeat steps 1 and 2 => On renew page an alert is displayed and user has to confirm renew => When renew is done from checkout list confirmation pop-up is displayed Signed-off-by: Anneli Österman <anneli.osterman@koha-suomi.fi> Signed-off-by: Kelly McElligott <kelly@bywatersolutions.com> Signed-off-by: Petro Vashchuk <stalkernoid@gmail.com> Created attachment 139671 [details] [review] Bug 23415: Add missing filters Signed-off-by: Kelly McElligott <kelly@bywatersolutions.com> Signed-off-by: Petro Vashchuk <stalkernoid@gmail.com> Created attachment 139672 [details] [review] Bug 23415: Use OPACFineNoRenewals instead of noissuecharge Since noissuecharge is mainly fine limit for checkouts it's more logical to use value in OPACFineNoRenewals. Sponsored-by: Koha-Suomi Oy Signed-off-by: Petro Vashchuk <stalkernoid@gmail.com> Created attachment 139673 [details] [review] Bug 23415: Display confirm dialog only once On detail page when patron has multiple checkouts and they are renewed from checkouts list, confirmation dialog box is displayed as many times as patron has checkouts. This patch reworks some code so this dialog box is displayed only once. To test: 1. Find patron with multiple checkouts (at least two) 2. Renew all checkouts from checkout list 3. Confirmation pop-up is displayed for every checkout 4. Apply this patch 5. Renew again => Confirmation dialog box is displayed only once Sponsored-by: Koha-Suomi Oy Signed-off-by: Stina Hallin <stina.hallin@ub.lu.se> Signed-off-by: Petro Vashchuk <stalkernoid@gmail.com> Created attachment 139674 [details] [review] Bug 23415: Rename OPACFineNoRenewals OPACFineNoRenewals no longer applies just to OPAC. To avoid confusion rename it as FineNoRenewals and also rename all occurences in code. To test, confirm everything works as described in previous test plans. Also prove t/db_dependent/Circulation.t The test plan still works but OPACFineNoRenewals is still showing as OPACFineNoRenewals and not FineNoRenewals. (In reply to Emmi Takkinen from comment #45) > Created attachment 139674 [details] [review] [review] > Bug 23415: Rename OPACFineNoRenewals > > OPACFineNoRenewals no longer applies just to OPAC. > To avoid confusion rename it as FineNoRenewals and > also rename all occurences in code. > > To test, confirm everything works as described in > previous test plans. > > Also prove t/db_dependent/Circulation.t Created attachment 146415 [details] [review] Bug 23415: Rename OPACFineNoRenewals OPACFineNoRenewals no longer applies just to OPAC. To avoid confusion rename it as FineNoRenewals and also rename all occurences in code. To test, confirm everything works as described in previous test plans. Also prove t/db_dependent/Circulation.t (In reply to Laura Escamilla from comment #46) > The test plan still works but OPACFineNoRenewals is still showing as > OPACFineNoRenewals and not FineNoRenewals. > > > > (In reply to Emmi Takkinen from comment #45) > > Created attachment 139674 [details] [review] [review] [review] > > Bug 23415: Rename OPACFineNoRenewals > > > > OPACFineNoRenewals no longer applies just to OPAC. > > To avoid confusion rename it as FineNoRenewals and > > also rename all occurences in code. > > > > To test, confirm everything works as described in > > previous test plans. > > > > Also prove t/db_dependent/Circulation.t I rebased patch and added new atomicupdate file. Could it be that patch didn't previously apply? Was syspref still named as OPACFineNoRenewals in systempreference page or was it still OPACFineNoRenewals in database and code? Created attachment 148198 [details] [review] Bug 23415: Notify patron fines when renewing It is possible to renew items for patron who has fines over accepted limit on renew page or from checkout list. This patch adds confirmation alerts to these renew actions when patron has fines over "noissuescharge" syspref. Test plan: 1. Have patron with checkouts and fines over allowed limit 2. Renew checkouts either from renew page or checkout list => renew is successful 3. Apply patch 4. Repeat steps 1 and 2 => On renew page an alert is displayed and user has to confirm renew => When renew is done from checkout list confirmation pop-up is displayed Signed-off-by: Anneli Österman <anneli.osterman@koha-suomi.fi> Signed-off-by: Kelly McElligott <kelly@bywatersolutions.com> Signed-off-by: Petro Vashchuk <stalkernoid@gmail.com> Signed-off-by: Sally <sally.healey@cheshiresharedservices.gov.uk> Created attachment 148199 [details] [review] Bug 23415: Add missing filters Signed-off-by: Kelly McElligott <kelly@bywatersolutions.com> Signed-off-by: Petro Vashchuk <stalkernoid@gmail.com> Signed-off-by: Sally <sally.healey@cheshiresharedservices.gov.uk> Created attachment 148200 [details] [review] Bug 23415: Use OPACFineNoRenewals instead of noissuecharge Since noissuecharge is mainly fine limit for checkouts it's more logical to use value in OPACFineNoRenewals. Sponsored-by: Koha-Suomi Oy Signed-off-by: Petro Vashchuk <stalkernoid@gmail.com> Signed-off-by: Sally <sally.healey@cheshiresharedservices.gov.uk> Created attachment 148201 [details] [review] Bug 23415: Display confirm dialog only once On detail page when patron has multiple checkouts and they are renewed from checkouts list, confirmation dialog box is displayed as many times as patron has checkouts. This patch reworks some code so this dialog box is displayed only once. To test: 1. Find patron with multiple checkouts (at least two) 2. Renew all checkouts from checkout list 3. Confirmation pop-up is displayed for every checkout 4. Apply this patch 5. Renew again => Confirmation dialog box is displayed only once Sponsored-by: Koha-Suomi Oy Signed-off-by: Stina Hallin <stina.hallin@ub.lu.se> Signed-off-by: Petro Vashchuk <stalkernoid@gmail.com> Signed-off-by: Sally <sally.healey@cheshiresharedservices.gov.uk> Created attachment 148202 [details] [review] Bug 23415: Rename OPACFineNoRenewals OPACFineNoRenewals no longer applies just to OPAC. To avoid confusion rename it as FineNoRenewals and also rename all occurences in code. To test, confirm everything works as described in previous test plans. Also prove t/db_dependent/Circulation.t Signed-off-by: Sally <sally.healey@cheshiresharedservices.gov.uk> Works as described; it shows for me as FineNoRenewals. I've signed off because all of the functionality is fine. There were a couple of formatting issues around the currency in the pop-up box: 1) The trailing full stop / period feels a bit odd when it's currency: Shows: The patron has a debt of 3.21. Perhaps: The patron has a debt of 3.21 2) If it's a round number, then pennies/cents aren't shown - it looks a bit odd: Shows: The patron has a debt of 3. Perhaps: The patron has a debt of 3.00 3) Is there any scope for adding the appropriate currency symbol? Shows: The patron has a debt of 3.21 Perhaps: The patron has a debt of £3.21 And: The patron has a debt of $3.21 And: The patron has a debt of €3.21 The other query was system preferences. OPACFineNoRenewals has been renamed to FineNoRenewals. There are two other system preferences: OPACFineNoRenewalsBlockAutoRenew and OPACFineNoRenewalsIncludeCredits The descriptions (values) of these have been updated by this bug to refer to FineNoRenewals, but should we also consider renaming the system preferences themselves to: FineNoRenewalsBlockAutoRenew and FineNoRenewalsIncludeCredits ? I realise this last point might be out of scope of the bug. Can you please rebase? Apply? [(y)es, (n)o, (i)nteractive] y Applying: Bug 23415: Notify patron fines when renewing Applying: Bug 23415: Add missing filters Applying: Bug 23415: Use OPACFineNoRenewals instead of noissuecharge error: sha1 information is lacking or useless (koha-tmpl/intranet-tmpl/prog/en/modules/circ/circulation.tt). error: could not build fake ancestor Patch failed at 0001 Bug 23415: Use OPACFineNoRenewals instead of noissuecharge hint: Use 'git am --show-current-patch=diff' to see the failed patch When you have resolved this problem run "git bz apply --continue". If you would prefer to skip this patch, instead run "git bz apply --skip". To restore the original branch and stop patching run "git bz apply --abort". Patch left in /tmp/Bug-23415-Use-OPACFineNoRenewals-instead-of-noissu-dlItcl.patch Please also check the fine formatting as noted by Sally in comment#54. There is now also a way to format in JS afaik. Created attachment 152776 [details] [review] Bug 23415: Notify patron fines when renewing It is possible to renew items for patron who has fines over accepted limit on renew page or from checkout list. This patch adds confirmation alerts to these renew actions when patron has fines over "noissuescharge" syspref. Test plan: 1. Have patron with checkouts and fines over allowed limit 2. Renew checkouts either from renew page or checkout list => renew is successful 3. Apply patch 4. Repeat steps 1 and 2 => On renew page an alert is displayed and user has to confirm renew => When renew is done from checkout list confirmation pop-up is displayed Signed-off-by: Anneli Österman <anneli.osterman@koha-suomi.fi> Signed-off-by: Kelly McElligott <kelly@bywatersolutions.com> Signed-off-by: Petro Vashchuk <stalkernoid@gmail.com> Created attachment 152777 [details] [review] Bug 23415: Add missing filters Signed-off-by: Kelly McElligott <kelly@bywatersolutions.com> Signed-off-by: Petro Vashchuk <stalkernoid@gmail.com> Created attachment 152778 [details] [review] Bug 23415: Use OPACFineNoRenewals instead of noissuecharge Since noissuecharge is mainly fine limit for checkouts it's more logical to use value in OPACFineNoRenewals. Sponsored-by: Koha-Suomi Oy Signed-off-by: Petro Vashchuk <stalkernoid@gmail.com> Created attachment 152779 [details] [review] Bug 23415: Display confirm dialog only once On detail page when patron has multiple checkouts and they are renewed from checkouts list, confirmation dialog box is displayed as many times as patron has checkouts. This patch reworks some code so this dialog box is displayed only once. To test: 1. Find patron with multiple checkouts (at least two) 2. Renew all checkouts from checkout list 3. Confirmation pop-up is displayed for every checkout 4. Apply this patch 5. Renew again => Confirmation dialog box is displayed only once Sponsored-by: Koha-Suomi Oy Signed-off-by: Stina Hallin <stina.hallin@ub.lu.se> Signed-off-by: Petro Vashchuk <stalkernoid@gmail.com> Created attachment 152780 [details] [review] Bug 23415: Rename OPACFineNoRenewals OPACFineNoRenewals no longer applies just to OPAC. To avoid confusion rename it as FineNoRenewals and also rename all occurences in code. To test, confirm everything works as described in previous test plans. Also prove t/db_dependent/Circulation.t Created attachment 152781 [details] [review] Bug 23415: Add fine formatting To test: 1. Find patron with checkouts and fines over allowed limit. 2. Renew checkouts either from renew page or checkout list. => Confirm that fines are formated correctly e.g. "The patron has a debt of 20.00" not like "The patron has a debt of 20." Rebased patches. (In reply to Sally from comment #54) > Works as described; it shows for me as FineNoRenewals. I've signed off > because all of the functionality is fine. > > There were a couple of formatting issues around the currency in the pop-up > box: > > 1) The trailing full stop / period feels a bit odd when it's currency: > Shows: The patron has a debt of 3.21. > Perhaps: The patron has a debt of 3.21 > > 2) If it's a round number, then pennies/cents aren't shown - it looks a bit > odd: > Shows: The patron has a debt of 3. > Perhaps: The patron has a debt of 3.00 > These have been added in new patch. > 3) Is there any scope for adding the appropriate currency symbol? > Shows: The patron has a debt of 3.21 > Perhaps: The patron has a debt of £3.21 > And: The patron has a debt of $3.21 > And: The patron has a debt of €3.21 > This isn't currently possible so I left this out. > The other query was system preferences. > > OPACFineNoRenewals has been renamed to FineNoRenewals. > There are two other system preferences: OPACFineNoRenewalsBlockAutoRenew > and OPACFineNoRenewalsIncludeCredits > > The descriptions (values) of these have been updated by this bug to refer to > FineNoRenewals, but should we also consider renaming the system preferences > themselves to: FineNoRenewalsBlockAutoRenew and > FineNoRenewalsIncludeCredits ? > > I realise this last point might be out of scope of the bug. Hmm, I'm not sure if these are still used just in OPAC. Created attachment 154595 [details] [review] Bug 23415: Notify patron fines when renewing It is possible to renew items for patron who has fines over accepted limit on renew page or from checkout list. This patch adds confirmation alerts to these renew actions when patron has fines over "noissuescharge" syspref. Test plan: 1. Have patron with checkouts and fines over allowed limit 2. Renew checkouts either from renew page or checkout list => renew is successful 3. Apply patch 4. Repeat steps 1 and 2 => On renew page an alert is displayed and user has to confirm renew => When renew is done from checkout list confirmation pop-up is displayed Signed-off-by: Anneli Österman <anneli.osterman@koha-suomi.fi> Signed-off-by: Kelly McElligott <kelly@bywatersolutions.com> Signed-off-by: Petro Vashchuk <stalkernoid@gmail.com> Signed-off-by: Veli-Matti <veli-matti.hakkinen@jyu.fi> Created attachment 154596 [details] [review] Bug 23415: Add missing filters Signed-off-by: Kelly McElligott <kelly@bywatersolutions.com> Signed-off-by: Petro Vashchuk <stalkernoid@gmail.com> Signed-off-by: Veli-Matti <veli-matti.hakkinen@jyu.fi> Created attachment 154597 [details] [review] Bug 23415: Use OPACFineNoRenewals instead of noissuecharge Since noissuecharge is mainly fine limit for checkouts it's more logical to use value in OPACFineNoRenewals. Sponsored-by: Koha-Suomi Oy Signed-off-by: Petro Vashchuk <stalkernoid@gmail.com> Signed-off-by: Veli-Matti <veli-matti.hakkinen@jyu.fi> Created attachment 154598 [details] [review] Bug 23415: Display confirm dialog only once On detail page when patron has multiple checkouts and they are renewed from checkouts list, confirmation dialog box is displayed as many times as patron has checkouts. This patch reworks some code so this dialog box is displayed only once. To test: 1. Find patron with multiple checkouts (at least two) 2. Renew all checkouts from checkout list 3. Confirmation pop-up is displayed for every checkout 4. Apply this patch 5. Renew again => Confirmation dialog box is displayed only once Sponsored-by: Koha-Suomi Oy Signed-off-by: Stina Hallin <stina.hallin@ub.lu.se> Signed-off-by: Petro Vashchuk <stalkernoid@gmail.com> Signed-off-by: Veli-Matti <veli-matti.hakkinen@jyu.fi> Created attachment 154599 [details] [review] Bug 23415: Rename OPACFineNoRenewals OPACFineNoRenewals no longer applies just to OPAC. To avoid confusion rename it as FineNoRenewals and also rename all occurences in code. To test, confirm everything works as described in previous test plans. Also prove t/db_dependent/Circulation.t Signed-off-by: Veli-Matti <veli-matti.hakkinen@jyu.fi> Created attachment 154600 [details] [review] Bug 23415: Add fine formatting To test: 1. Find patron with checkouts and fines over allowed limit. 2. Renew checkouts either from renew page or checkout list. => Confirm that fines are formated correctly e.g. "The patron has a debt of 20.00" not like "The patron has a debt of 20." Signed-off-by: Veli-Matti <veli-matti.hakkinen@jyu.fi> Tested and works as planned. Sorry guys, came to QA but we need a rebase first. Created attachment 158302 [details] [review] Bug 23415: Notify patron fines when renewing It is possible to renew items for patron who has fines over accepted limit on renew page or from checkout list. This patch adds confirmation alerts to these renew actions when patron has fines over "noissuescharge" syspref. Test plan: 1. Have patron with checkouts and fines over allowed limit 2. Renew checkouts either from renew page or checkout list => renew is successful 3. Apply patch 4. Repeat steps 1 and 2 => On renew page an alert is displayed and user has to confirm renew => When renew is done from checkout list confirmation pop-up is displayed Signed-off-by: Anneli Österman <anneli.osterman@koha-suomi.fi> Signed-off-by: Kelly McElligott <kelly@bywatersolutions.com> Signed-off-by: Petro Vashchuk <stalkernoid@gmail.com> Created attachment 158303 [details] [review] Bug 23415: Add missing filters Signed-off-by: Kelly McElligott <kelly@bywatersolutions.com> Signed-off-by: Petro Vashchuk <stalkernoid@gmail.com> Created attachment 158304 [details] [review] Bug 23415: Use OPACFineNoRenewals instead of noissuecharge Since noissuecharge is mainly fine limit for checkouts it's more logical to use value in OPACFineNoRenewals. Sponsored-by: Koha-Suomi Oy Signed-off-by: Petro Vashchuk <stalkernoid@gmail.com> Created attachment 158305 [details] [review] Bug 23415: Display confirm dialog only once On detail page when patron has multiple checkouts and they are renewed from checkouts list, confirmation dialog box is displayed as many times as patron has checkouts. This patch reworks some code so this dialog box is displayed only once. To test: 1. Find patron with multiple checkouts (at least two) 2. Renew all checkouts from checkout list 3. Confirmation pop-up is displayed for every checkout 4. Apply this patch 5. Renew again => Confirmation dialog box is displayed only once Sponsored-by: Koha-Suomi Oy Signed-off-by: Stina Hallin <stina.hallin@ub.lu.se> Signed-off-by: Petro Vashchuk <stalkernoid@gmail.com> Created attachment 158306 [details] [review] Bug 23415: Rename OPACFineNoRenewals OPACFineNoRenewals no longer applies just to OPAC. To avoid confusion rename it as FineNoRenewals and also rename all occurences in code. To test, confirm everything works as described in previous test plans. Also prove t/db_dependent/Circulation.t Created attachment 158307 [details] [review] Bug 23415: Add fine formatting To test: 1. Find patron with checkouts and fines over allowed limit. 2. Renew checkouts either from renew page or checkout list. => Confirm that fines are formated correctly e.g. "The patron has a debt of 20.00" not like "The patron has a debt of 20." Rebased patches. Setting this back to "Signed Off". Applying: Bug 23415: Rename OPACFineNoRenewals error: sha1 information is lacking or useless (koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/opac.pref). error: could not build fake ancestor Patch failed at 0001 Bug 23415: Rename OPACFineNoRenewals Created attachment 161964 [details] [review] Bug 23415: Notify patron fines when renewing It is possible to renew items for patron who has fines over accepted limit on renew page or from checkout list. This patch adds confirmation alerts to these renew actions when patron has fines over "noissuescharge" syspref. Test plan: 1. Have patron with checkouts and fines over allowed limit 2. Renew checkouts either from renew page or checkout list => renew is successful 3. Apply patch 4. Repeat steps 1 and 2 => On renew page an alert is displayed and user has to confirm renew => When renew is done from checkout list confirmation pop-up is displayed Signed-off-by: Anneli Österman <anneli.osterman@koha-suomi.fi> Signed-off-by: Kelly McElligott <kelly@bywatersolutions.com> Signed-off-by: Petro Vashchuk <stalkernoid@gmail.com> Created attachment 161965 [details] [review] Bug 23415: Add missing filters Signed-off-by: Kelly McElligott <kelly@bywatersolutions.com> Signed-off-by: Petro Vashchuk <stalkernoid@gmail.com> Created attachment 161966 [details] [review] Bug 23415: Use OPACFineNoRenewals instead of noissuecharge Since noissuecharge is mainly fine limit for checkouts it's more logical to use value in OPACFineNoRenewals. Sponsored-by: Koha-Suomi Oy Signed-off-by: Petro Vashchuk <stalkernoid@gmail.com> Created attachment 161967 [details] [review] Bug 23415: Display confirm dialog only once On detail page when patron has multiple checkouts and they are renewed from checkouts list, confirmation dialog box is displayed as many times as patron has checkouts. This patch reworks some code so this dialog box is displayed only once. To test: 1. Find patron with multiple checkouts (at least two) 2. Renew all checkouts from checkout list 3. Confirmation pop-up is displayed for every checkout 4. Apply this patch 5. Renew again => Confirmation dialog box is displayed only once Sponsored-by: Koha-Suomi Oy Signed-off-by: Stina Hallin <stina.hallin@ub.lu.se> Signed-off-by: Petro Vashchuk <stalkernoid@gmail.com> Created attachment 161968 [details] [review] Bug 23415: Rename OPACFineNoRenewals OPACFineNoRenewals no longer applies just to OPAC. To avoid confusion rename it as FineNoRenewals and also rename all occurences in code. To test, confirm everything works as described in previous test plans. Also prove t/db_dependent/Circulation.t Created attachment 161969 [details] [review] Bug 23415: Add fine formatting To test: 1. Find patron with checkouts and fines over allowed limit. 2. Renew checkouts either from renew page or checkout list. => Confirm that fines are formated correctly e.g. "The patron has a debt of 20.00" not like "The patron has a debt of 20." Rebased patches. Created attachment 162171 [details] [review] Bug 23415: Notify patron fines when renewing It is possible to renew items for patron who has fines over accepted limit on renew page or from checkout list. This patch adds confirmation alerts to these renew actions when patron has fines over "noissuescharge" syspref. Test plan: 1. Have patron with checkouts and fines over allowed limit 2. Renew checkouts either from renew page or checkout list => renew is successful 3. Apply patch 4. Repeat steps 1 and 2 => On renew page an alert is displayed and user has to confirm renew => When renew is done from checkout list confirmation pop-up is displayed Signed-off-by: Anneli Österman <anneli.osterman@koha-suomi.fi> Signed-off-by: Kelly McElligott <kelly@bywatersolutions.com> Signed-off-by: Petro Vashchuk <stalkernoid@gmail.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Created attachment 162172 [details] [review] Bug 23415: Add missing filters Signed-off-by: Kelly McElligott <kelly@bywatersolutions.com> Signed-off-by: Petro Vashchuk <stalkernoid@gmail.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Created attachment 162173 [details] [review] Bug 23415: Use OPACFineNoRenewals instead of noissuecharge Since noissuecharge is mainly fine limit for checkouts it's more logical to use value in OPACFineNoRenewals. Sponsored-by: Koha-Suomi Oy Signed-off-by: Petro Vashchuk <stalkernoid@gmail.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Created attachment 162174 [details] [review] Bug 23415: Display confirm dialog only once On detail page when patron has multiple checkouts and they are renewed from checkouts list, confirmation dialog box is displayed as many times as patron has checkouts. This patch reworks some code so this dialog box is displayed only once. To test: 1. Find patron with multiple checkouts (at least two) 2. Renew all checkouts from checkout list 3. Confirmation pop-up is displayed for every checkout 4. Apply this patch 5. Renew again => Confirmation dialog box is displayed only once Sponsored-by: Koha-Suomi Oy Signed-off-by: Stina Hallin <stina.hallin@ub.lu.se> Signed-off-by: Petro Vashchuk <stalkernoid@gmail.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Created attachment 162175 [details] [review] Bug 23415: Rename OPACFineNoRenewals OPACFineNoRenewals no longer applies just to OPAC. To avoid confusion rename it as FineNoRenewals and also rename all occurences in code. To test, confirm everything works as described in previous test plans. Also prove t/db_dependent/Circulation.t Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Created attachment 162176 [details] [review] Bug 23415: Add fine formatting To test: 1. Find patron with checkouts and fines over allowed limit. 2. Renew checkouts either from renew page or checkout list. => Confirm that fines are formated correctly e.g. "The patron has a debt of 20.00" not like "The patron has a debt of 20." Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Created attachment 162177 [details] [review] Bug 23415: (QA follow-up) Remove OPACFineNoRenewals from syspres.sql Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Created attachment 162178 [details] [review] Bug 23415: Tidy template parameters block Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Created attachment 162179 [details] [review] Bug 23415: (QA follow-up) Spelling and price formatting Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Created attachment 162180 [details] [review] Bug 23415: (QA follow-up) Fix rebase code re-introduction Looks like some code was re-introduced during rebases, this patch switches it back to calling the newly introduced 'renew' function rather than doing the post inline. I also compared the two posts and updated the function to match the updated post from upstream. Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> This is really close.. but.. May I ask why you chose to handle this at the controller level rather than adding/moving the check into CanBookBeRenewed? I see you do handle it in the _CanBookBeAutoRenewed version, but I think I am confused that it's not there in parent function. (In reply to Martin Renvoize from comment #96) > This is really close.. but.. May I ask why you chose to handle this at the > controller level rather than adding/moving the check into CanBookBeRenewed? > > I see you do handle it in the _CanBookBeAutoRenewed version, but I think I > am confused that it's not there in parent function. Hmm, do you mean why there is a line my >$fine_no_renewals = C4::Context->preference("FineNoRenewals"); (and everything after that line) in _CanBookBeAutoRenewed? Those have been added in different bug, I just renamed syspref from "OPACFineNoRenewals" -> "FineNoRenewals". I'm afraid this needs a rebase It seems that last patch is partially dated. It would be great to keep this moving along as so much work has been done already. I currently have a library asking for this functionality. Code, especially in checkouts.js, has changed so much since last rebase that it's kinda tricky to sort out where everything goes. So this probably needs a lot of rework. I'll probably need to provide whole new patches for this since I don't see a point to just rebase these patches and then creating a new patch to address changes made to the code. I am sorry to hear this Emmi, I hope we didn't make it harder. Created attachment 171620 [details] [review] Bug 23415: Notify patron fines when renewing It is possible to renew items for patron who has fines over accepted limit on renew page or from checkout list. This patch adds confirmation alerts to these renew actions when patron has fines over "noissuescharge" syspref. Test plan: 1. Have patron with checkouts and fines over allowed limit 2. Renew checkouts either from renew page or checkout list => renew is successful 3. Apply patch 4. Repeat steps 1 and 2 => On renew page an alert is displayed and user has to confirm renew => When renew is done from checkout list confirmation pop-up is displayed Sponsored-by: Koha-Suomi Oy Created attachment 171621 [details] [review] Bug 23415: Rename OPACFineNoRenewals OPACFineNoRenewals no longer applies just to OPAC. To avoid confusion rename it as FineNoRenewals and also rename all occurences in code. To test, confirm everything works as described in previous test plans. Also prove t/db_dependent/Circulation.t Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Created attachment 171622 [details] [review] Bug 23415: (QA follow-up) Remove OPACFineNoRenewals from syspres.sql Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Created attachment 171623 [details] [review] Bug 23415: Tidy template parameters block Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> (In reply to Katrin Fischer from comment #102) > I am sorry to hear this Emmi, I hope we didn't make it harder. It actually wasn't as bad as I feared it would be :D I fixed and squashed some patches together, so that this is easier to maintain. However I kept the changes made to OPACFineNoRenewals syspref separate from other changes (again, changes are easier to maintain this way imo). This could need a new test round and sign offs. Thank you for looking at this again Emmi and all. Created attachment 171983 [details] [review] Bug 23415: Notify patron fines when renewing It is possible to renew items for patron who has fines over accepted limit on renew page or from checkout list. This patch adds confirmation alerts to these renew actions when patron has fines over "noissuescharge" syspref. Test plan: 1. Have patron with checkouts and fines over allowed limit 2. Renew checkouts either from renew page or checkout list => renew is successful 3. Apply patch 4. Repeat steps 1 and 2 => On renew page an alert is displayed and user has to confirm renew => When renew is done from checkout list confirmation pop-up is displayed Sponsored-by: Koha-Suomi Oy Signed-off-by: Shi Yao Wang <shi-yao.wang@inlibro.com> Created attachment 171984 [details] [review] Bug 23415: Rename OPACFineNoRenewals OPACFineNoRenewals no longer applies just to OPAC. To avoid confusion rename it as FineNoRenewals and also rename all occurences in code. To test, confirm everything works as described in previous test plans. Also prove t/db_dependent/Circulation.t Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Shi Yao Wang <shi-yao.wang@inlibro.com> Created attachment 171985 [details] [review] Bug 23415: (QA follow-up) Remove OPACFineNoRenewals from syspres.sql Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Shi Yao Wang <shi-yao.wang@inlibro.com> Created attachment 171986 [details] [review] Bug 23415: Tidy template parameters block Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Shi Yao Wang <shi-yao.wang@inlibro.com> Created attachment 172906 [details] [review] Bug 23415: Notify patron fines when renewing It is possible to renew items for patron who has fines over accepted limit on renew page or from checkout list. This patch adds confirmation alerts to these renew actions when patron has fines over "noissuescharge" syspref. Test plan: 1. Have patron with checkouts and fines over allowed limit 2. Renew checkouts either from renew page or checkout list => renew is successful 3. Apply patch 4. Repeat steps 1 and 2 => On renew page an alert is displayed and user has to confirm renew => When renew is done from checkout list confirmation pop-up is displayed Sponsored-by: Koha-Suomi Oy Signed-off-by: Shi Yao Wang <shi-yao.wang@inlibro.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Created attachment 172907 [details] [review] Bug 23415: Rename OPACFineNoRenewals OPACFineNoRenewals no longer applies just to OPAC. To avoid confusion rename it as FineNoRenewals and also rename all occurences in code. To test, confirm everything works as described in previous test plans. Also prove t/db_dependent/Circulation.t Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Shi Yao Wang <shi-yao.wang@inlibro.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Created attachment 172908 [details] [review] Bug 23415: (QA follow-up) Remove OPACFineNoRenewals from syspres.sql Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Shi Yao Wang <shi-yao.wang@inlibro.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Created attachment 172909 [details] [review] Bug 23415: Tidy template parameters block Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Shi Yao Wang <shi-yao.wang@inlibro.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Created attachment 172910 [details] [review] Bug 23415: (QA follow-up) Move to Circulation::CanBookBeRenewed This moves the basic calculation for too_much_oweing out of the controller and into the class method. Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Sorry it took so long to come back to this.. all looking good now. Passing QA 1) Translations (follow-up please)
+ var MSG_CONFIRM_RENEW = _("The patron has a debt of %s\nAre you sure you want to renew checkout(s)?").format(fines);
The \n is likely to cause issues in translations (haven't checked with Weblate, but was definitely an issue with Pootle. Please split into separate strings.
2) too_much_oweing (question, not blocker)
Wondering if that should be "owing"? If so, we could fix it globally on a separate bug.
Sorry, I was about to push this, but it needs some more work: 3) xt/find-missing-op-in-forms.t 1..1 not ok 1 - The <form> in the following files are missing it's corresponding op parameter, or op does not start with 'cud-' (see bug 34478) # Failed test 'The <form> in the following files are missing it's corresponding op parameter, or op does not start with 'cud-' (see bug 34478)' # at xt/find-missing-op-in-forms.t line 43. # got: '1' # expected: '0' # $VAR1 = 'koha-tmpl/intranet-tmpl/prog/en/modules/circ/renew.tt:193'; # Looks like you failed 1 test of 1. 4) xt/find-missing-csrf.t 5) xt/yaml_valid.t After latest patch, this no longer works as intended. If patron has fines over FineNoRenewals limit, renewing loans is prevented with message "too_much_oweing". Clicking "Renew all" displays pop up, but clicking ok just displays "There are no items to be renewed." pop up. So this got me thinking, which way is more preferable? Either we allow renewing items and overwrite FineNoRenewals limit like these patches did previously. Or we don't allow overwriting that limit and prevent it with error "too_much_oweing". I have to admit I got a bit confused about the before and after, but could something like AllowFineOverride be helpful here? Or a confirmation with an option to override. (In reply to Katrin Fischer from comment #122) > I have to admit I got a bit confused about the before and after, but could > something like AllowFineOverride be helpful here? > Or a confirmation with an option to override. Hmm, AllowFineOverride would probably be the way to go here. But do we then need to change its description to something like this: "..staff to manually override and check out items or renew holds to patrons who have more in fines than set in the noissuescharge or FineNoRenewals system preference." Of course there's also possibility that some libraries want to override check out limit, but not holds limit. We could do another pref... but before considering that it would maybe be good to get some libraries opinions on the use case and if that is really required. Hi, the library that I am currently working with would need the ability for staff to override from the alert message. I think it might need to be a separate system preference in order to give libraries flexibility over which transactions could be overridden. |