Bug 23524

Summary: Can modify/delete funds for locked budgets
Product: Koha Reporter: Nick Clemens <nick>
Component: AcquisitionsAssignee: Bugs List <koha-bugs>
Status: NEW --- QA Contact: Testopia <testopia>
Severity: normal    
Priority: P5 - low CC: bwsdonna, katrin.fischer, kelly
Version: Main   
Hardware: All   
OS: All   
See Also: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14851
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14857
Change sponsored?: --- Patch complexity: ---
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:
Bug Depends on: 22786    
Bug Blocks:    

Description Nick Clemens 2019-08-30 13:24:42 UTC
What are the allowed actions for a locked budget? Should it be read only?

To recreate:
1 - From acqui home click on a budget
2 - Edit the budget and lock it
3 - on admin/aqbudgets.pl notice all funds have an action button
4 - You cannot add, but the button is not disabled
5 - You can modify
6 - You can delete
Comment 1 Katrin Fischer 2019-09-01 21:59:18 UTC
I would think that changing the funds in the budget should be not allowed, while we should still allow ordering and receiving (active/inactive works for that).

The manual states:
https://koha-community.org/manual/19.05/en/html/administration.html?highlight=locked#budgets

Locking a budget means that funds will not be able to be modified by librarians

It doesn't work this way yet, but we could fix it.
Comment 2 Donna 2022-07-14 18:59:37 UTC
To me, lock means nothing changes.  So no changing of fund amounts, no adding/removing funds, and no ordering/receiving.  

Active/inactive makes sense for whether or not I can use the money in the budget, where lock means it has been finalized/closed out and nothing should change in it.
Comment 3 Katrin Fischer 2022-07-15 08:59:42 UTC
This is an old bug now... feature in the GUI that never did anything. Maybe we should fix it :)
Comment 4 Katrin Fischer 2023-12-08 21:34:13 UTC
(In reply to Donna from comment #2)
> To me, lock means nothing changes.  So no changing of fund amounts, no
> adding/removing funds, and no ordering/receiving.  
> 
> Active/inactive makes sense for whether or not I can use the money in the
> budget, where lock means it has been finalized/closed out and nothing should
> change in it.

We also have inactive and a fund could be set to inactive and locked. An idea would be to make them add up, but not overlap maybe.