| Summary: | Opac-basket.pl script accidentally displays 'hidden' items | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Mason James <mtj> |
| Component: | OPAC | Assignee: | Mason James <mtj> |
| Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
| Severity: | major | ||
| Priority: | P5 - low | CC: | bob, fridolin.somers, irma, lucas, m.de.rooy |
| Version: | Main | ||
| Hardware: | All | ||
| OS: | All | ||
| Change sponsored?: | --- | Patch complexity: | --- |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: |
19.11.00,19.05.03,18.11.10
|
|
| Circulation function: | |||
| Bug Depends on: | 14385 | ||
| Bug Blocks: | |||
| Attachments: |
Bug 23530 - Opac-basket.pl script accidentally displays 'hidden' items
before patch, WITHDRAWN item displayed after patch, WITHDRAWN item hidden Bug 23530: Fix cart showing only hidden items Bug 23530: Fix cart showing only hidden items |
||
|
Description
Mason James
2019-09-03 04:01:03 UTC
Created attachment 92534 [details] [review] Bug 23530 - Opac-basket.pl script accidentally displays 'hidden' items to test patch.. - prep a test bib with hidden and other items - add bib to cart observe that hidden items are displayed - non-hidden items are hidden - apply patch, reload page observe that hidden items are hidden, non-hidden items are displayed Created attachment 92535 [details]
before patch, WITHDRAWN item displayed
Created attachment 92536 [details]
after patch, WITHDRAWN item hidden
hi Marcel i think the error was introduced from a 'squashing' patch for BZ 14385 https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80466 *** Bug 15513 has been marked as a duplicate of this bug. *** Updating severity - affects the OPAC (library patrons) and is even worse than showing the hidden items as it hides the all the items that you should see. Created attachment 92537 [details] [review] Bug 23530: Fix cart showing only hidden items Items hidden with the OpacHiddenItems system preference were still displayed in the OPAC cart and the normal items were hidden instead. This patch corrects the display. To test: - prep a test bib with hidden and other items using the OpacHiddenItems system preference - add bib to cart - observe that hidden items are displayed - non-hidden items are hidden - apply patch, reload page - observe that hidden items are hidden, non-hidden items are displayed Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Created attachment 92546 [details] [review] Bug 23530: Fix cart showing only hidden items Items hidden with the OpacHiddenItems system preference were still displayed in the OPAC cart and the normal items were hidden instead. This patch corrects the display. To test: - prep a test bib with hidden and other items using the OpacHiddenItems system preference - add bib to cart - observe that hidden items are displayed - non-hidden items are hidden - apply patch, reload page - observe that hidden items are hidden, non-hidden items are displayed Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> Nice work! Pushed to master for 19.11.00 Pushed to 19.05.x for 19.05.04 What a dirty bug ;) Just verified in 19.11.09 - problem exists there, this should be backported. (In reply to Katrin Fischer from comment #11) > Just verified in 19.11.09 - problem exists there, this should be backported. 18.11.09 of course. Hi Lucas, has this been missed? |