| Summary: | Template error causes item search to be submitted multiple times | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Owen Leonard <oleonard> |
| Component: | Templates | Assignee: | Owen Leonard <oleonard> |
| Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
| Severity: | normal | ||
| Priority: | P5 - low | CC: | fridolin.somers, lucas |
| Version: | Main | ||
| Hardware: | All | ||
| OS: | All | ||
| Change sponsored?: | --- | Patch complexity: | Trivial patch |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: |
19.11.00,19.05.04
|
|
| Circulation function: | |||
| Bug Depends on: | |||
| Bug Blocks: | 23543, 23565 | ||
| Attachments: |
Bug 23575: Template error causes item search to be submitted multiple times
Bug 23575: Template error causes item search to be submitted multiple times Bug 23575: Template error causes item search to be submitted multiple times Bug 23575: Template error causes item search to be submitted multiple times |
||
|
Description
Owen Leonard
2019-09-09 16:55:06 UTC
Created attachment 92672 [details] [review] Bug 23575: Template error causes item search to be submitted multiple times This patch corrects the item search template so that the submit handler is not nested inside an unrelated loop. The change should have no outward effect on the behavior of the item search other than making it faster. To observe the bug in action, open your browser's developer tools and click the "Network" tab. Filter the output to only "XHR" and perform an item search. You should see multiple requests. To test, apply the patch and perform an item search. It should behave normally. Check the browser's "Network" monitor again to verify that only one request is being sent. Created attachment 92709 [details] [review] Bug 23575: Template error causes item search to be submitted multiple times This patch corrects the item search template so that the submit handler is not nested inside an unrelated loop. The change should have no outward effect on the behavior of the item search other than making it faster. To observe the bug in action, open your browser's developer tools and click the "Network" tab. Filter the output to only "XHR" and perform an item search. You should see multiple requests. To test, apply the patch and perform an item search. It should behave normally. Check the browser's "Network" monitor again to verify that only one request is being sent. Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> Created attachment 92820 [details] [review] Bug 23575: Template error causes item search to be submitted multiple times This patch corrects the item search template so that the submit handler is not nested inside an unrelated loop. The change should have no outward effect on the behavior of the item search other than making it faster. To observe the bug in action, open your browser's developer tools and click the "Network" tab. Filter the output to only "XHR" and perform an item search. You should see multiple requests. To test, apply the patch and perform an item search. It should behave normally. Check the browser's "Network" monitor again to verify that only one request is being sent. Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> Signed-off-by: Bouzid Fergani <bouzid.fergani@inlibro.com> Created attachment 92822 [details] [review] Bug 23575: Template error causes item search to be submitted multiple times This patch corrects the item search template so that the submit handler is not nested inside an unrelated loop. The change should have no outward effect on the behavior of the item search other than making it faster. To observe the bug in action, open your browser's developer tools and click the "Network" tab. Filter the output to only "XHR" and perform an item search. You should see multiple requests. To test, apply the patch and perform an item search. It should behave normally. Check the browser's "Network" monitor again to verify that only one request is being sent. Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> Signed-off-by: Bouzid Fergani <bouzid.fergani@inlibro.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Excellent catch, Owen! Nice work! Pushed to master for 19.11.00 Pushed to 19.05.x for 19.05.04 Great job, what a dirty bug ;) backported to 18.11.x for 18.11.11 |