|
Description
Séverine Queune
2019-09-11 13:14:04 UTC
Created attachment 95518 [details] [review] Bug 23591: Add some useful methods to Koha::Suggestions Those are methods initially written for bug 23991. I finally need them before than expected. Created attachment 95519 [details] [review] Bug 23591: Display a new "Suggestion detail" tab on the bib detail page This patch adds a new "Suggestion detail" tab on the bibliographic detail page. It will help suggestion management. Test plan: - Create several suggestions for a given biblio - Go to the detail page of the bibliographic record and confirm that there is a new "Suggestion detail" tab with all the suggestions you created. Created attachment 95520 [details] [review] Bug 23591: Use same css for suggestion notes Created attachment 95521 [details] [review] Bug 23591: [DO NOT PUSH] CSS Changes What about the archived suggestions? Do we want to display or hide them? Or maybe a show/hide link on top of the table? (In reply to Jonathan Druart from comment #5) > What about the archived suggestions? Do we want to display or hide them? Or > maybe a show/hide link on top of the table? After consulting the users, to not display the archives suggestions by default, but using a link, seems more useful. Created attachment 95579 [details] [review] Bug 23591: Hide archived suggestions However we are adding a note on top of the table to tell how many suggestions are archived. It seems that there is no good reason to display the archived suggestions on this table. A detail but I need to ask... On the message "There is one archived suggestion.", "one" is written in full letters, but when there are more suggestions, numbers are used. Do you want to keep these different forms ? (In reply to Séverine Queune from comment #8) > A detail but I need to ask... > On the message "There is one archived suggestion.", "one" is written in full > letters, but when there are more suggestions, numbers are used. > Do you want to keep these different forms ? I will let that for someone else. It makes sense to me to have it like that. No problem for me, just wanted to be sure :) Let's go for signing ! Created attachment 95600 [details] [review] Bug 23591: Add some useful methods to Koha::Suggestions Those are methods initially written for bug 23991. I finally need them before than expected. Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> Created attachment 95601 [details] [review] Bug 23591: Display a new "Suggestion detail" tab on the bib detail page This patch adds a new "Suggestion detail" tab on the bibliographic detail page. It will help suggestion management. Test plan: - Create several suggestions for a given biblio - Go to the detail page of the bibliographic record and confirm that there is a new "Suggestion detail" tab with all the suggestions you created. Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> Created attachment 95602 [details] [review] Bug 23591: Use same css for suggestion notes Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> Created attachment 95603 [details] [review] Bug 23591: [DO NOT PUSH] CSS Changes Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> Created attachment 95604 [details] [review] Bug 23591: Hide archived suggestions However we are adding a note on top of the table to tell how many suggestions are archived. It seems that there is no good reason to display the archived suggestions on this table. Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> Currently blocked by bug in FQA further up the dependency tree. Created attachment 100812 [details] [review] Bug 23591: Add some useful methods to Koha::Suggestions Those are methods initially written for bug 23991. I finally need them before than expected. Created attachment 100813 [details] [review] Bug 23591: Display a new "Suggestion detail" tab on the bib detail page This patch adds a new "Suggestion detail" tab on the bibliographic detail page. It will help suggestion management. Test plan: - Create several suggestions for a given biblio - Go to the detail page of the bibliographic record and confirm that there is a new "Suggestion detail" tab with all the suggestions you created. Created attachment 100814 [details] [review] Bug 23591: Use same css for suggestion notes Created attachment 100815 [details] [review] Bug 23591: [DO NOT PUSH] CSS Changes Created attachment 100816 [details] [review] Bug 23591: Hide archived suggestions However we are adding a note on top of the table to tell how many suggestions are archived. It seems that there is no good reason to display the archived suggestions on this table. Patch no longer applies on top of bug 22784, can you please rebase? Apply? [(y)es, (n)o, (i)nteractive] y Applying: Bug 23591: Add some useful methods to Koha::Suggestions Applying: Bug 23591: Display a new "Suggestion detail" tab on the bib detail page Applying: Bug 23591: Use same css for suggestion notes error: sha1 information is lacking or useless (koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt). error: could not build fake ancestor Created attachment 102799 [details] [review] Bug 23591: Use same css for suggestion notes Created attachment 102800 [details] [review] Bug 23591: [DO NOT PUSH] CSS Changes Created attachment 102801 [details] [review] Bug 23591: Hide archived suggestions However we are adding a note on top of the table to tell how many suggestions are archived. It seems that there is no good reason to display the archived suggestions on this table. Created attachment 102850 [details] [review] Bug 23591: Add some useful methods to Koha::Suggestions Those are methods initially written for bug 23991. I finally need them before than expected. Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Created attachment 102851 [details] [review] Bug 23591: Display a new "Suggestion detail" tab on the bib detail page This patch adds a new "Suggestion detail" tab on the bibliographic detail page. It will help suggestion management. Test plan: - Create several suggestions for a given biblio - Go to the detail page of the bibliographic record and confirm that there is a new "Suggestion detail" tab with all the suggestions you created. Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Created attachment 102852 [details] [review] Bug 23591: Use same css for suggestion notes Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Created attachment 102853 [details] [review] Bug 23591: [DO NOT PUSH] CSS Changes Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Created attachment 102854 [details] [review] Bug 23591: Hide archived suggestions However we are adding a note on top of the table to tell how many suggestions are archived. It seems that there is no good reason to display the archived suggestions on this table. Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Do not push CSS changes indeed - file is not minified! :) Future enhanements: - Move the dates into separate columns as we did in other places now, so the can be sorted nicely. - Add an option to show the archived suggestions (checkbox or button) Nice work everyone! Pushed to master for 20.05 new feature not backported to 19.11.x |