Summary: | Holds API is missing reserved parameters on the GET spec | ||
---|---|---|---|
Product: | Koha | Reporter: | Owen Leonard <oleonard> |
Component: | REST API | Assignee: | Tomás Cohen Arazi <tomascohen> |
Status: | CLOSED FIXED | QA Contact: | Julian Maurice <julian.maurice> |
Severity: | major | ||
Priority: | P5 - low | CC: | emmi.takkinen, fridolin.somers, julian.maurice, lucas |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | Trivial patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: |
19.11.00,19.05.04
|
|
Attachments: |
Bug 23597: Add missing reserved query parameters to GET /holds
Bug 23597: Add missing reserved query parameters to GET /holds Bug 23597: Add missing reserved query parameters to GET /holds |
Description
Owen Leonard
2019-09-11 17:27:12 UTC
Created attachment 92713 [details] [review] Bug 23597: Add missing reserved query parameters to GET /holds Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Created attachment 92714 [details] [review] Bug 23597: Add missing reserved query parameters to GET /holds Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Owen Leonard <oleonard@myacpl.org> Problem found: When I try to load the list of holds on the patron's account I get an error from the API: Can't call method "branchname" on an undefined value at /kohadevbox/koha/svc/holds line 89 eval {...} at /kohadevbox/koha/svc/holds line 2 Never mind that appears to be unrelated. Created attachment 92826 [details] [review] Bug 23597: Add missing reserved query parameters to GET /holds Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Julian Maurice <julian.maurice@biblibre.com> Nice work! Pushed to master for 19.11.00 *** Bug 23358 has been marked as a duplicate of this bug. *** Pushed to 19.05.x for 19.05.04 backported to 18.11.x for 18.11.11 |