When I make a request for a list of holds on a particular biblionumber I get results from multiple biblios. It looks like the query is using a "LIKE" search: api/v1/holds?biblio_id=41 returns records for 241, 41, 2541, 4129...
Created attachment 92713 [details] [review] Bug 23597: Add missing reserved query parameters to GET /holds Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Created attachment 92714 [details] [review] Bug 23597: Add missing reserved query parameters to GET /holds Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Problem found: When I try to load the list of holds on the patron's account I get an error from the API: Can't call method "branchname" on an undefined value at /kohadevbox/koha/svc/holds line 89 eval {...} at /kohadevbox/koha/svc/holds line 2
Never mind that appears to be unrelated.
Created attachment 92826 [details] [review] Bug 23597: Add missing reserved query parameters to GET /holds Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Julian Maurice <julian.maurice@biblibre.com>
Nice work! Pushed to master for 19.11.00
*** Bug 23358 has been marked as a duplicate of this bug. ***
Pushed to 19.05.x for 19.05.04
backported to 18.11.x for 18.11.11