| Summary: | When placing a hold editing using Inspect Element allows addition to the code of non listed library | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Patrick <pm> |
| Component: | Circulation | Assignee: | Lari Taskula <lari.taskula> |
| Status: | CLOSED FIXED | QA Contact: | Jonathan Druart <jonathan.druart> |
| Severity: | major | ||
| Priority: | P5 - low | CC: | fridolin.somers, gmcharlt, jonathan.druart, kyle.m.hall, martin.renvoize |
| Version: | Main | ||
| Hardware: | All | ||
| OS: | All | ||
| See Also: | https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22330 | ||
| Change sponsored?: | --- | Patch complexity: | --- |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: |
19.11.00,19.05.05
|
|
| Circulation function: | |||
| Bug Depends on: | 7614 | ||
| Bug Blocks: | |||
| Attachments: |
Bug 23774: Server-side confirmation for hold pickup location in OPAC
Bug 23774: Server-side confirmation for hold pickup location in OPAC Bug 23774: Server-side confirmation for hold pickup location in OPAC |
||
|
Description
Patrick
2019-10-08 11:39:28 UTC
Hi Patrick, which preferences/features do you use to limit the list of pick-up locations in the first place? I'd like to confirm the bug, but need more information about your configuration. Hi Katrin, The list is built based on the "Pickup Location" flag on the branches record being set to "Yes" Kind regards, Patrick Created attachment 95018 [details] [review] Bug 23774: Server-side confirmation for hold pickup location in OPAC While placing a hold on a book, if a user opens up Inspect Element on the Pick up location drop down box they can change the pick up location in the code to a library that is not listed as a pick up location. How to replicate: Search for a book Select book Click Place Hold On the screen Home > Placing a hold Right click on Pick up location Select 'Inspect Element' Under <!-- HOLDABLE --> <li class="Branch"> <select name="Branch ******"> Pick Up location:</label>=$0 Option values are listed that relate to the pick up location, this value can be changed to another new location and when the hold is placed the hold will be placed for this new location instead of the listed options in the Pick up location drop down list. To test: 1. Apply patch 2. Repeat "How to replicate" 3. Observe it is no longer possible to place holds on libraries not defined as pickup location by changing option value via Inspect Element tool Created attachment 95023 [details] [review] Bug 23774: Server-side confirmation for hold pickup location in OPAC While placing a hold on a book, if a user opens up Inspect Element on the Pick up location drop down box they can change the pick up location in the code to a library that is not listed as a pick up location. How to replicate: Search for a book Select book Click Place Hold On the screen Home > Placing a hold Right click on Pick up location Select 'Inspect Element' Under <!-- HOLDABLE --> <li class="Branch"> <select name="Branch ******"> Pick Up location:</label>=$0 Option values are listed that relate to the pick up location, this value can be changed to another new location and when the hold is placed the hold will be placed for this new location instead of the listed options in the Pick up location drop down list. To test: 1. Apply patch 2. Repeat "How to replicate" 3. Observe it is no longer possible to place holds on libraries not defined as pickup location by changing option value via Inspect Element tool Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Thanks for the quick fix once assigned Lari, I'd meant to catch you to ask but you beat me to it :). Works as requested, so glad you jumped in as I was somewhat daunted when I started digging through the code. Signing Off. Many thanks Lari, Martin & Kathrin. Greatly appreciated. Kind regards, Patrick. Created attachment 95041 [details] [review] Bug 23774: Server-side confirmation for hold pickup location in OPAC While placing a hold on a book, if a user opens up Inspect Element on the Pick up location drop down box they can change the pick up location in the code to a library that is not listed as a pick up location. How to replicate: Search for a book Select book Click Place Hold On the screen Home > Placing a hold Right click on Pick up location Select 'Inspect Element' Under <!-- HOLDABLE --> <li class="Branch"> <select name="Branch ******"> Pick Up location:</label>=$0 Option values are listed that relate to the pick up location, this value can be changed to another new location and when the hold is placed the hold will be placed for this new location instead of the listed options in the Pick up location drop down list. To test: 1. Apply patch 2. Repeat "How to replicate" 3. Observe it is no longer possible to place holds on libraries not defined as pickup location by changing option value via Inspect Element tool Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Nice work! Pushed to master for 19.11.00 Pushed to 19.05.x for 19.05.05 |