Branch transfer limits are respected for placing holds in the OPAC but nowhere else. This should be remedied.
*** Bug 11020 has been marked as a duplicate of this bug. ***
*** Bug 11024 has been marked as a duplicate of this bug. ***
*** Bug 7376 has been marked as a duplicate of this bug. ***
Created attachment 85067 [details] [review] Bug 22330: Transfer limits should be respected for placing holds in staff interface and APIs Branch transfer limits are respected for placing holds in the OPAC but nowhere else. This should be remedied. Test Plan: 1) Set up a branch transfer limit from Library A to Library B 2) Verify you cannot set up a hold for an item from Library A for pickup at Library B from the staff interface ( without overriding ) 3) Verify you cannot place that hold via ILS-DI 4) Verify you cannot place that hold via SIP 4) Verify a forced hold from Library A to Library B will not show up in the holds queue
Created attachment 85068 [details] [review] Bug 22330: Cache item and library objects when building the holds queue
Setting severity to critical since this replaces 7376 which had that severity.
Comment on attachment 85067 [details] [review] Bug 22330: Transfer limits should be respected for placing holds in staff interface and APIs Review of attachment 85067 [details] [review]: ----------------------------------------------------------------- ::: C4/Reserves.pm @@ +34,3 @@ > use C4::Letters; > use C4::Log; > +use C4::Members qw(); C4::Members is just few lines above with full import... @@ +48,4 @@ > use Koha::ItemTypes; > +use Koha::Items; > +use Koha::Libraries; > +use Koha::Libraries; The same use line twice.
Created attachment 86479 [details] [review] Bug 22330: Transfer limits should be respected for placing holds in staff interface and APIs Branch transfer limits are respected for placing holds in the OPAC but nowhere else. This should be remedied. Test Plan: 1) Set up a branch transfer limit from Library A to Library B 2) Verify you cannot set up a hold for an item from Library A for pickup at Library B from the staff interface ( without overriding ) 3) Verify you cannot place that hold via ILS-DI 4) Verify you cannot place that hold via SIP 4) Verify a forced hold from Library A to Library B will not show up in the holds queue
Created attachment 86480 [details] [review] Bug 22330: Transfer limits should be respected for placing holds in staff interface and APIs Branch transfer limits are respected for placing holds in the OPAC but nowhere else. This should be remedied. Test Plan: 1) Set up a branch transfer limit from Library A to Library B 2) Verify you cannot set up a hold for an item from Library A for pickup at Library B from the staff interface ( without overriding ) 3) Verify you cannot place that hold via ILS-DI 4) Verify you cannot place that hold via SIP 4) Verify a forced hold from Library A to Library B will not show up in the holds queue
Created attachment 86481 [details] [review] Bug 22330: Cache item and library objects when building the holds queue
Created attachment 86482 [details] [review] Bug 22330: (QA follow-up) Remove duplicate use lines, combine and sort remaning lines
Created attachment 86758 [details] [review] Bug 22330: Transfer limits should be respected for placing holds in staff interface and APIs Branch transfer limits are respected for placing holds in the OPAC but nowhere else. This should be remedied. Test Plan: 1) Set up a branch transfer limit from Library A to Library B 2) Verify you cannot set up a hold for an item from Library A for pickup at Library B from the staff interface ( without overriding ) 3) Verify you cannot place that hold via ILS-DI 4) Verify you cannot place that hold via SIP 4) Verify a forced hold from Library A to Library B will not show up in the holds queue Signed-off-by: Liz Rea <wizzyrea@gmail.com>
Created attachment 86759 [details] [review] Bug 22330: Cache item and library objects when building the holds queue Signed-off-by: Liz Rea <wizzyrea@gmail.com>
Created attachment 86760 [details] [review] Bug 22330: (QA follow-up) Remove duplicate use lines, combine and sort remaning lines Signed-off-by: Liz Rea <wizzyrea@gmail.com>
I realised half a second too late that there was a QA tool fail here, but I'm not 100% sure it's not a false positive, and no one was around to ask. Anyway, here's what it was: FAIL koha-tmpl/intranet-tmpl/prog/en/modules/reserve/request.tt FAIL filters missing_filter at line 666 ( var biblionumber = "[% biblionumber %]";) missing_filter at line 667 ( var borrowernumber = "[% patron.borrowernumber %]";)
Created attachment 86779 [details] [review] Bug 22330: (QA follow-up) Fix QA script failure
Created attachment 86802 [details] [review] Bug 22330: Transfer limits should be respected for placing holds in staff interface and APIs Branch transfer limits are respected for placing holds in the OPAC but nowhere else. This should be remedied. Test Plan: 1) Set up a branch transfer limit from Library A to Library B 2) Verify you cannot set up a hold for an item from Library A for pickup at Library B from the staff interface ( without overriding ) 3) Verify you cannot place that hold via ILS-DI 4) Verify you cannot place that hold via SIP 4) Verify a forced hold from Library A to Library B will not show up in the holds queue Signed-off-by: Liz Rea <wizzyrea@gmail.com> Signed-off-by: Josef Moravec <josef.moravec@gmail.com>
Created attachment 86803 [details] [review] Bug 22330: Cache item and library objects when building the holds queue Signed-off-by: Liz Rea <wizzyrea@gmail.com> Signed-off-by: Josef Moravec <josef.moravec@gmail.com>
Created attachment 86804 [details] [review] Bug 22330: (QA follow-up) Remove duplicate use lines, combine and sort remaning lines Signed-off-by: Liz Rea <wizzyrea@gmail.com> Signed-off-by: Josef Moravec <josef.moravec@gmail.com>
Created attachment 86805 [details] [review] Bug 22330: (QA follow-up) Fix QA script failure Signed-off-by: Josef Moravec <josef.moravec@gmail.com>
Created attachment 86806 [details] [review] Bug 22330: (QA follow-up) Enable datatable in patron search Test plan: Try to search patron for circulation (or for creating hold), when there are more than 1 patron, you should see a table with patrons found. --> without this patch, the datatable is not created (for example sorting the table by clicking to column heading does not work) --> with this patch, the datatable works Signed-off-by: Josef Moravec <josef.moravec@gmail.com>
Created attachment 86807 [details] [review] Bug 22330: (QA follow-up) Fix number of tests in Reserves.t Test plan: prove t/db_dependent/Reserves.t Signed-off-by: Josef Moravec <josef.moravec@gmail.com>
I removed schema files changes accidentally added to third patch and added two small fixes - number of test, that is obvious - activate again the commented out javascript for creating datatable when searching for patron to circulate/create hold
Awesome work all! Pushed to master for 19.05
This is proving non-trivial to backport. Kyle, do you feel this should make the cut to 18.11?
Can someone confirm if this bug encompasses bug 7376? (Transfer limits should be checked at check-in) Because this bug seems to only be about holds.
Non-trivial backport for a long standing issue. I'm taking the decision not to backport at the present time.