|
Description
Victor Grousset/tuxayo
2019-10-08 12:19:54 UTC
Created attachment 133119 [details] [review] Bug 23775: Claiming a serial issue doesn't create the next one Whenever we need to generate manually a new serial we go to page 'serials-edit.pl'. With this patch it is possible to generate a new serial on page 'serials.pl'. Test Plan: -- Previously we need a serial which is in EXPECTED status & the Date received should not be later than today -- 1)On the intra. Make sure to have at least 1 subscription for a bibliographic record & 1 vendor linked 2)Then Home > Serials > Claims > Claims for <your_vendor_name> 3)Check the row of the serial with the EXPECTED status 4)Click 'Send notification' 5)Notice the status of the row : it is now CLAIMED 6)To verify: Home > Serials > Serial collection information for <your_record_name> 7)The status is CLAIMED too & a new serial with an EXPECTED status has appeared on the table Created attachment 133122 [details] [review] Bug 23775: Claiming a serial issue doesn't create the next one Whenever we need to generate manually a new serial we go to page 'serials-edit.pl'. With this patch it is possible to generate a new serial on page 'serials.pl'. Test Plan: -- Previously we need a serial which is in EXPECTED status & the Date received should not be later than today -- 1)On the intra. Make sure to have at least 1 subscription for a bibliographic record & 1 vendor linked 2)Then Home > Serials > Claims > Claims for <your_vendor_name> 3)Check the row of the serial with the EXPECTED status 4)Click 'Send notification' 5)Notice the status of the row : it is now CLAIMED 6)To verify: Home > Serials > Serial collection information for <your_record_name> 7)Here the status is CLAIMED too but nothing happened around 8)Apply patch 9)Repeat from 2) to 6) 10)The status is still CLAIMED & the new serial with status EXPECTED is freshly generated > 3)Check the row of the serial with the EXPECTED status
> 4)Click 'Send notification'
> 5)Notice the status of the row : it is now CLAIMED
I don't know if I'm doing something wrong, but this step doesn't work for me. The status of the issue remains EXPECTED.
Thanks for the feedback, it works fine on my computer. I have changed the test plan to be clearer : > 3)Tick the checkbox of the row where the status is EXPECTED then > 4)Click 'Send notification' > 5)Notice the status of the row : it is now CLAIMED Created attachment 134062 [details] [review] Bug 23775: Claiming a serial issue doesn't create the next one Whenever we need to generate manually a new serial we go to page 'serials-edit.pl'. With this patch it is possible to generate a new serial on page 'serials.pl'. Test Plan: -- Previously we need a serial which is in EXPECTED status & the Date received should not be later than today -- 1)On the intra. Make sure to have at least 1 subscription for a bibliographic record & 1 vendor linked 2)Then Home > Serials > Claims > Claims for <your_vendor_name> 3)Tick the checkbox of the row where the status is EXPECTED then 4)Click 'Send notification' 5)Notice the status of the row : it is now CLAIMED 6)To verify: Home > Serials > Serial collection information for <your_record_name> 7)Here the status is CLAIMED too but nothing happened around 8)Apply patch 9)Repeat from 2) to 6) 10)The status is still CLAIMED & the new serial with status EXPECTED is freshly generated Tried on a sandbox, doesn't apply : TASK [Apply bug 23775 via git-bz in docker container] ************************** fatal: [localhost -> koha-bz23775]: FAILED! => {"changed": true, "cmd": "cd /kohadevbox/koha && yes | git bz apply 23775", "delta": "0:00:06.645085", "end": "2022-09-08 14:37:16.817592", "msg": "non-zero return code", "rc": 1, "start": "2022-09-08 14:37:10.172507", "stderr": ".git/rebase-apply/patch:80: trailing whitespace.\n \nwarning: 1 line adds whitespace errors.\n.git/rebase-apply/patch:80: trailing whitespace.\n \nwarning: 1 line applied after fixing whitespace errors.\nerror: Failed to merge in the changes.\nhint: Use 'git am --show-current-patch=diff' to see the failed patch\nPatch left in /tmp/Bug-23775-Claiming-a-serial-issue-doesnt-create-th-5vIy9g.patch", "stderr_lines": [".git/rebase-apply/patch:80: trailing whitespace.", " Created attachment 152624 [details] [review] Bug 23775: Claiming a serial issue doesn't create the next one Whenever we need to generate manually a new serial we go to page 'serials-edit.pl'. With this patch it is possible to generate a new serial on page 'serials.pl'. Test Plan: -- Previously we need a serial which is in EXPECTED status & the Date received should not be later than today -- 1) On the intra. Make sure to have at least 1 subscription for a bibliographic record & 1 vendor linked 2) Then Home > Serials > Claims > Claims for <your_vendor_name> 3) Tick the checkbox of the row where the status is EXPECTED then 4) Click 'Send notification' 5) Notice the status of the row : it is now CLAIMED 6) To verify: Home > Serials > Serial collection information for <your_record_name> 7) Here the status is CLAIMED too but nothing happened around 8) Apply patch 9) Repeat from 2) to 6) 10) The status is still CLAIMED & the new serial with status EXPECTED is freshly generated Patch cleaned and rebased on master Created attachment 152696 [details] [review] Bug 23775: Claiming a serial issue doesn't create the next one Whenever we need to generate manually a new serial we go to page 'serials-edit.pl'. With this patch it is possible to generate a new serial on page 'serials.pl'. Test Plan: -- Previously we need a serial which is in EXPECTED status & the Date received should not be later than today -- 1) On the intra. Make sure to have at least 1 subscription for a bibliographic record & 1 vendor linked 2) Then Home > Serials > Claims > Claims for <your_vendor_name> 3) Tick the checkbox of the row where the status is EXPECTED then 4) Click 'Send notification' 5) Notice the status of the row : it is now CLAIMED 6) To verify: Home > Serials > Serial collection information for <your_record_name> 7) Here the status is CLAIMED too but nothing happened around 8) Apply patch 9) Repeat from 2) to 6) 10) The status is still CLAIMED & the new serial with status EXPECTED is freshly generated Signed-off-by: Sam Lau <samalau@gmail.com> Created attachment 152729 [details] [review] Bug 23775: Claiming a serial issue doesn't create the next one Whenever we need to generate manually a new serial we go to page 'serials-edit.pl'. With this patch it is possible to generate a new serial on page 'serials.pl'. Test Plan: -- Previously we need a serial which is in EXPECTED status & the Date received should not be later than today -- 1) On the intra. Make sure to have at least 1 subscription for a bibliographic record & 1 vendor linked 2) Then Home > Serials > Claims > Claims for <your_vendor_name> 3) Tick the checkbox of the row where the status is EXPECTED then 4) Click 'Send notification' 5) Notice the status of the row : it is now CLAIMED 6) To verify: Home > Serials > Serial collection information for <your_record_name> 7) Here the status is CLAIMED too but nothing happened around 8) Apply patch 9) Repeat from 2) to 6) 10) The status is still CLAIMED & the new serial with status EXPECTED is freshly generated Signed-off-by: Sam Lau <samalau@gmail.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Working as expected, unit tests included, qa script happy. Passing QA Pushed to master for 23.11. Nice work everyone, thanks! Thanks for all the hard work! Pushed to 23.05.x for the next release Nice work everyone! Pushed to oldstable for 22.11.x |