Bug 23775 - Claiming a serial issue doesn't create the next one
Summary: Claiming a serial issue doesn't create the next one
Status: RESOLVED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Serials (show other bugs)
Version: Main
Hardware: All All
: P5 - low normal (vote)
Assignee: Julian Maurice
QA Contact: Martin Renvoize
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2019-10-08 12:19 UTC by Victor Grousset/tuxayo
Modified: 2023-12-28 20:47 UTC (History)
5 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
23.11.00,23.05.02,22.11.08


Attachments
Bug 23775: Claiming a serial issue doesn't create the next one (12.39 KB, patch)
2022-04-08 11:43 UTC, Jérémy Breuillard
Details | Diff | Splinter Review
Bug 23775: Claiming a serial issue doesn't create the next one (12.48 KB, patch)
2022-04-08 13:23 UTC, Jérémy Breuillard
Details | Diff | Splinter Review
Bug 23775: Claiming a serial issue doesn't create the next one (8.64 KB, patch)
2022-04-27 12:03 UTC, Jérémy Breuillard
Details | Diff | Splinter Review
Bug 23775: Claiming a serial issue doesn't create the next one (3.79 KB, patch)
2023-06-23 08:32 UTC, Julian Maurice
Details | Diff | Splinter Review
Bug 23775: Claiming a serial issue doesn't create the next one (3.83 KB, patch)
2023-06-26 15:08 UTC, Sam Lau
Details | Diff | Splinter Review
Bug 23775: Claiming a serial issue doesn't create the next one (3.89 KB, patch)
2023-06-27 12:48 UTC, Martin Renvoize
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Victor Grousset/tuxayo 2019-10-08 12:19:54 UTC
== test plan ==
1. have a vendor with an email address for claiming late issues
2. have a subscription linked to this vendor
   - You can create a new one with arbitrary values
3. Go to "Serial collection"
4. click "Edit serials"
5. Status of the latest: change from Expected to Claimed
6. save
7. see that the next issue has been created
8. go to /cgi-bin/koha/serials/claims.pl
9. make a claim on the expected issue of the previously used serial
10. Then you see that the next issue hasn't been created
Comment 1 Jérémy Breuillard 2022-04-08 11:43:55 UTC Comment hidden (obsolete)
Comment 2 Jérémy Breuillard 2022-04-08 13:23:16 UTC Comment hidden (obsolete)
Comment 3 Owen Leonard 2022-04-22 17:49:02 UTC
> 3)Check the row of the serial with the EXPECTED status
> 4)Click 'Send notification'
> 5)Notice the status of the row : it is now CLAIMED

I don't know if I'm doing something wrong, but this step doesn't work for me. The status of the issue remains EXPECTED.
Comment 4 Jérémy Breuillard 2022-04-27 12:00:06 UTC
Thanks for the feedback, it works fine on my computer. I have changed the test plan to be clearer :

  > 3)Tick the checkbox of the row where the status is EXPECTED then
  > 4)Click 'Send notification'
  > 5)Notice the status of the row : it is now CLAIMED
Comment 5 Jérémy Breuillard 2022-04-27 12:03:00 UTC
Created attachment 134062 [details] [review]
Bug 23775: Claiming a serial issue doesn't create the next one

Whenever we need to generate manually a new serial we go to page 'serials-edit.pl'. With this patch it is possible to generate a new serial on page 'serials.pl'.

Test Plan:
-- Previously we need a serial which is in EXPECTED status & the Date received should not be later than today --
1)On the intra. Make sure to have at least 1 subscription for a bibliographic record & 1 vendor linked
2)Then Home > Serials > Claims > Claims for <your_vendor_name>
3)Tick the checkbox of the row where the status is EXPECTED then
4)Click 'Send notification'
5)Notice the status of the row : it is now CLAIMED
6)To verify: Home > Serials > Serial collection information for <your_record_name>
7)Here the status is CLAIMED too but nothing happened around
8)Apply patch
9)Repeat from 2) to 6)
10)The status is still CLAIMED & the new serial with status EXPECTED is freshly generated
Comment 6 Thibault Keromnès 2022-09-08 15:04:27 UTC
Tried on a sandbox, doesn't apply : 

TASK [Apply bug 23775 via git-bz in docker container] **************************
fatal: [localhost -> koha-bz23775]: FAILED! => {"changed": true, "cmd": "cd /kohadevbox/koha && yes | git bz apply 23775", "delta": "0:00:06.645085", "end": "2022-09-08 14:37:16.817592", "msg": "non-zero return code", "rc": 1, "start": "2022-09-08 14:37:10.172507", "stderr": ".git/rebase-apply/patch:80: trailing whitespace.\n          \nwarning: 1 line adds whitespace errors.\n.git/rebase-apply/patch:80: trailing whitespace.\n          \nwarning: 1 line applied after fixing whitespace errors.\nerror: Failed to merge in the changes.\nhint: Use 'git am --show-current-patch=diff' to see the failed patch\nPatch left in /tmp/Bug-23775-Claiming-a-serial-issue-doesnt-create-th-5vIy9g.patch", "stderr_lines": [".git/rebase-apply/patch:80: trailing whitespace.", "
Comment 7 Julian Maurice 2023-06-23 08:32:00 UTC
Created attachment 152624 [details] [review]
Bug 23775: Claiming a serial issue doesn't create the next one

Whenever we need to generate manually a new serial we go to page
'serials-edit.pl'. With this patch it is possible to generate a new
serial on page 'serials.pl'.

Test Plan:
-- Previously we need a serial which is in EXPECTED status & the Date
received should not be later than today --
1) On the intra. Make sure to have at least 1 subscription for a
   bibliographic record & 1 vendor linked
2) Then Home > Serials > Claims > Claims for <your_vendor_name>
3) Tick the checkbox of the row where the status is EXPECTED then
4) Click 'Send notification'
5) Notice the status of the row : it is now CLAIMED
6) To verify: Home > Serials > Serial collection information for
   <your_record_name>
7) Here the status is CLAIMED too but nothing happened around
8) Apply patch
9) Repeat from 2) to 6)
10) The status is still CLAIMED & the new serial with status EXPECTED is
    freshly generated
Comment 8 Julian Maurice 2023-06-23 08:32:33 UTC
Patch cleaned and rebased on master
Comment 9 Sam Lau 2023-06-26 15:08:49 UTC
Created attachment 152696 [details] [review]
Bug 23775: Claiming a serial issue doesn't create the next one

Whenever we need to generate manually a new serial we go to page
'serials-edit.pl'. With this patch it is possible to generate a new
serial on page 'serials.pl'.

Test Plan:
-- Previously we need a serial which is in EXPECTED status & the Date
received should not be later than today --
1) On the intra. Make sure to have at least 1 subscription for a
   bibliographic record & 1 vendor linked
2) Then Home > Serials > Claims > Claims for <your_vendor_name>
3) Tick the checkbox of the row where the status is EXPECTED then
4) Click 'Send notification'
5) Notice the status of the row : it is now CLAIMED
6) To verify: Home > Serials > Serial collection information for
   <your_record_name>
7) Here the status is CLAIMED too but nothing happened around
8) Apply patch
9) Repeat from 2) to 6)
10) The status is still CLAIMED & the new serial with status EXPECTED is
    freshly generated

Signed-off-by: Sam Lau <samalau@gmail.com>
Comment 10 Martin Renvoize 2023-06-27 12:48:14 UTC
Created attachment 152729 [details] [review]
Bug 23775: Claiming a serial issue doesn't create the next one

Whenever we need to generate manually a new serial we go to page
'serials-edit.pl'. With this patch it is possible to generate a new
serial on page 'serials.pl'.

Test Plan:
-- Previously we need a serial which is in EXPECTED status & the Date
received should not be later than today --
1) On the intra. Make sure to have at least 1 subscription for a
   bibliographic record & 1 vendor linked
2) Then Home > Serials > Claims > Claims for <your_vendor_name>
3) Tick the checkbox of the row where the status is EXPECTED then
4) Click 'Send notification'
5) Notice the status of the row : it is now CLAIMED
6) To verify: Home > Serials > Serial collection information for
   <your_record_name>
7) Here the status is CLAIMED too but nothing happened around
8) Apply patch
9) Repeat from 2) to 6)
10) The status is still CLAIMED & the new serial with status EXPECTED is
    freshly generated

Signed-off-by: Sam Lau <samalau@gmail.com>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Comment 11 Martin Renvoize 2023-06-27 12:48:39 UTC
Working as expected, unit tests included, qa script happy.

Passing QA
Comment 12 Tomás Cohen Arazi 2023-07-03 13:34:32 UTC
Pushed to master for 23.11.

Nice work everyone, thanks!
Comment 13 Martin Renvoize 2023-07-17 14:59:59 UTC
Thanks for all the hard work!

Pushed to 23.05.x for the next release
Comment 14 Matt Blenkinsop 2023-07-18 13:00:19 UTC
Nice work everyone!

Pushed to oldstable for 22.11.x