Bug 23821

Summary: Reintroduction of create_helper_biblio
Product: Koha Reporter: Jonathan Druart <jonathan.druart>
Component: Test SuiteAssignee: Jonathan Druart <jonathan.druart>
Status: CLOSED FIXED QA Contact: Testopia <testopia>
Severity: normal    
Priority: P5 - low CC: tomascohen
Version: unspecified   
Hardware: All   
OS: All   
Change sponsored?: --- Patch complexity: Trivial patch
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:
19.11.00
Bug Depends on: 7614, 21798    
Bug Blocks:    
Attachments: Bug 23821: Remove new occurrence of create_helper_biblio
Bug 23821: Remove new occurrence of create_helper_biblio

Description Jonathan Druart 2019-10-16 10:25:32 UTC
create_helper_biblio subroutines have been remove from bug 21798, but one occurrence have been reintroduced by bug 7614. We must use build_sample_biblio instead.
Comment 1 Jonathan Druart 2019-10-16 10:26:47 UTC
Created attachment 94270 [details] [review]
Bug 23821: Remove new occurrence of create_helper_biblio

create_helper_biblio subroutines have been remove from bug 21798, but
one occurrence have been reintroduced by bug 7614. We must use
build_sample_biblio instead.

Test plan:
  prove t/db_dependent/Koha/Libraries.t
should return green.
Comment 2 Tomás Cohen Arazi 2019-10-16 13:39:24 UTC
Created attachment 94296 [details] [review]
Bug 23821: Remove new occurrence of create_helper_biblio

create_helper_biblio subroutines have been remove from bug 21798, but
one occurrence have been reintroduced by bug 7614. We must use
build_sample_biblio instead.

Test plan:
  prove t/db_dependent/Koha/Libraries.t
should return green.

Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Comment 3 Martin Renvoize 2019-10-17 13:54:50 UTC
Nice work!

Pushed to master for 19.11.00