Bug 23853

Summary:	Typo in authorised_values.tt
Product:	Koha	Reporter:	Caroline Cyr La Rose <caroline.cyr-la-rose>
Component:	System Administration	Assignee:	Caroline Cyr La Rose <caroline.cyr-la-rose>
Status:	CLOSED FIXED	QA Contact:	Martin Renvoize (ashimema) <martin.renvoize>
Severity:	normal
Priority:	P5 - low	CC:	gmcharlt, martin.renvoize, severine.queune
Version:	Main
Hardware:	All
OS:	All
Change sponsored?:	---	Patch complexity:	String patch
Documentation contact:		Documentation submission:
Text to go in the release notes:		Version(s) released in:	19.11.00
Circulation function:
Attachments:	Bug 23853: Typo in authorised_values.tt Bug 23853: Typo in authorised_values.tt Bug 23853: Typo in authorised_values.tt

Description Caroline Cyr La Rose 2019-10-21 14:22:17 UTC

When you go into Administration > Authorised values, there are descriptions for each auth value category. The description of Bsort1 says that it is used for sort 2 field. It should say that it is used for sort 1.

I also noticed that Asort1 and Asort2 have the same description, but Bsort1 and Bsort2 do not.

Comment 1 Caroline Cyr La Rose 2019-10-21 15:15:08 UTC

Created attachment 94454 [details] [review]
Bug 23853: Typo in authorised_values.tt

This patch corrects the Bsort1 typo in authorised_values.tt and changes the Bsort2 description to match Bsort1's.

To test:
1- Go to Administration > Authorised values
2- Make sure descriptions for Bsort1 and Bsort2 match their category and are the same (except for 1 and 2)

Comment 2 Séverine Queune 2019-10-29 08:38:29 UTC

Created attachment 94820 [details] [review]
Bug 23853: Typo in authorised_values.tt

This patch corrects the Bsort1 typo in authorised_values.tt and changes the Bsort2 description to match Bsort1's.

To test:
1- Go to Administration > Authorised values
2- Make sure descriptions for Bsort1 and Bsort2 match their category and are the same (except for 1 and 2)

Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr>

Comment 3 Séverine Queune 2019-10-29 08:41:01 UTC

Nice catch Caroline !
Works fine for me :)

Comment 4 Martin Renvoize (ashimema) 2019-10-29 12:06:21 UTC

Created attachment 94828 [details] [review]
Bug 23853: Typo in authorised_values.tt

This patch corrects the Bsort1 typo in authorised_values.tt and changes the Bsort2 description to match Bsort1's.

To test:
1- Go to Administration > Authorised values
2- Make sure descriptions for Bsort1 and Bsort2 match their category and are the same (except for 1 and 2)

Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>

Comment 5 Martin Renvoize (ashimema) 2019-10-29 12:06:37 UTC

Good catch, passing QA

Comment 6 Martin Renvoize (ashimema) 2019-10-29 12:17:08 UTC

Nice work!

Pushed to master for 19.11.00