Bug 23894

Summary: accountlines.payment_type and accountlines.credit_type should be merged
Product: Koha Reporter: Martin Renvoize (ashimema) <martin.renvoize>
Component: Fines and feesAssignee: Bugs List <koha-bugs>
Status: NEW --- QA Contact: Testopia <testopia>
Severity: enhancement    
Priority: P5 - low CC: black23, gmcharlt, kyle.m.hall, mirjam.vantieghem
Version: Main   
Hardware: All   
OS: All   
Change sponsored?: --- Patch complexity: ---
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:
Circulation function:
Bug Depends on: 17702, 24338    
Bug Blocks: 14825    

Description Martin Renvoize (ashimema) 2019-10-24 21:22:25 UTC 
During the implementation of bug 23805 and bug 23049 it became apparent to me that the introduction of payment_type appeared to be a workaround for the lack of distinct credit and debit categories.

Now we have a distinct credit_type field in accountlines which is properly governed by foreign key relationships I believe we could merge the payment_type field with this credit_type field and expose a purpose build UI for managing such types.
Comment 1 Mirjam Vantieghem 2024-02-08 11:25:09 UTC 
Not sure if I'm understanding this one.
We use the payment types for a different purpose than the credit types, so a merge would not be desirable. At least not for our library.
The payment types, e.g. cash/bank transfer/invoice, are used to indicate how a payment was made for debit transactions.
The credit types, e.g. refund for deposit/overpayment, are used to define what kind of credit transaction it is, i.e. the reason for creating a manual credit.