Bug 23894 - accountlines.payment_type and accountlines.credit_type should be merged
Summary: accountlines.payment_type and accountlines.credit_type should be merged
Status: NEW
Alias: None
Product: Koha
Classification: Unclassified
Component: Fines and fees (show other bugs)
Version: Main
Hardware: All All
: P5 - low enhancement (vote)
Assignee: Bugs List
QA Contact: Testopia
URL:
Keywords:
Depends on: 17702 24338
Blocks: 14825
  Show dependency treegraph
 
Reported: 2019-10-24 21:22 UTC by Martin Renvoize
Modified: 2024-02-08 11:25 UTC (History)
5 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Martin Renvoize 2019-10-24 21:22:25 UTC
During the implementation of bug 23805 and bug 23049 it became apparent to me that the introduction of payment_type appeared to be a workaround for the lack of distinct credit and debit categories.

Now we have a distinct credit_type field in accountlines which is properly governed by foreign key relationships I believe we could merge the payment_type field with this credit_type field and expose a purpose build UI for managing such types.
Comment 1 Mirjam Vantieghem 2024-02-08 11:25:09 UTC
Not sure if I'm understanding this one.
We use the payment types for a different purpose than the credit types, so a merge would not be desirable. At least not for our library.
The payment types, e.g. cash/bank transfer/invoice, are used to indicate how a payment was made for debit transactions.
The credit types, e.g. refund for deposit/overpayment, are used to define what kind of credit transaction it is, i.e. the reason for creating a manual credit.