|
Description
Nick Clemens (kidclamp)
2019-11-07 14:02:06 UTC
Created attachment 95605 [details] [review] Bug 23987: Use src=CATALOGUING for edition/deletion in batch from items table There are 2 ways to land in batchMod from the detail page of a bib record: from the Edit menu, and the action buttons on top of the items table. We want the same behavior for both and so use src=CATALOGUING It will make batchMod to behave identically for the "return" button Created attachment 95606 [details] [review] Bug 23987: "return to cataloguing" if the record is deleted from bachMod-del If a bibliographic record is deleted after having deleted all their items in a batch, we should not display a "return to the record" button but "return to cataloguing" instead Test plan: 1 - Have/make a bib with items 2 - On details page select Edit->Delete items in a batch 3 - Select all items and check "Delete record if no items remain" 4 - Delete the things 5 - On confirmation screen you have a count of items/bibs deleted => Without the patch there is a 'Return to record' button that leads to nowhere => With this patch there is a "Return to cataloging module" button 6 - Repeat using the "Delete selected items" link on top of the items table => Without the patch there is a 'Return to where you were' button that leads to nowhere => With this patch there is a "Return to cataloging module" button Note that there is a link AND a button, coming from commit 928c0af2b6a2c7aa6ed54019c5bd7dbddbccf4ee Bug 15824 - 'Done' button is unclear on batch item modification and deletion I do not think it makes sense to have both. Created attachment 95711 [details] [review] Bug 23987: Use src=CATALOGUING for edition/deletion in batch from items table There are 2 ways to land in batchMod from the detail page of a bib record: from the Edit menu, and the action buttons on top of the items table. We want the same behavior for both and so use src=CATALOGUING It will make batchMod to behave identically for the "return" button Signed-off-by: George Williams <george@nekls.org> Created attachment 95712 [details] [review] Bug 23987: "return to cataloguing" if the record is deleted from bachMod-del If a bibliographic record is deleted after having deleted all their items in a batch, we should not display a "return to the record" button but "return to cataloguing" instead Test plan: 1 - Have/make a bib with items 2 - On details page select Edit->Delete items in a batch 3 - Select all items and check "Delete record if no items remain" 4 - Delete the things 5 - On confirmation screen you have a count of items/bibs deleted => Without the patch there is a 'Return to record' button that leads to nowhere => With this patch there is a "Return to cataloging module" button 6 - Repeat using the "Delete selected items" link on top of the items table => Without the patch there is a 'Return to where you were' button that leads to nowhere => With this patch there is a "Return to cataloging module" button Note that there is a link AND a button, coming from commit 928c0af2b6a2c7aa6ed54019c5bd7dbddbccf4ee Bug 15824 - 'Done' button is unclear on batch item modification and deletion I do not think it makes sense to have both. Signed-off-by: George Williams <george@nekls.org> Created attachment 95757 [details] [review] Bug 23987: Use src=CATALOGUING for edition/deletion in batch from items table There are 2 ways to land in batchMod from the detail page of a bib record: from the Edit menu, and the action buttons on top of the items table. We want the same behavior for both and so use src=CATALOGUING It will make batchMod to behave identically for the "return" button Signed-off-by: George Williams <george@nekls.org> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Created attachment 95758 [details] [review] Bug 23987: "return to cataloguing" if the record is deleted from bachMod-del If a bibliographic record is deleted after having deleted all their items in a batch, we should not display a "return to the record" button but "return to cataloguing" instead Test plan: 1 - Have/make a bib with items 2 - On details page select Edit->Delete items in a batch 3 - Select all items and check "Delete record if no items remain" 4 - Delete the things 5 - On confirmation screen you have a count of items/bibs deleted => Without the patch there is a 'Return to record' button that leads to nowhere => With this patch there is a "Return to cataloging module" button 6 - Repeat using the "Delete selected items" link on top of the items table => Without the patch there is a 'Return to where you were' button that leads to nowhere => With this patch there is a "Return to cataloging module" button Note that there is a link AND a button, coming from commit 928c0af2b6a2c7aa6ed54019c5bd7dbddbccf4ee Bug 15824 - 'Done' button is unclear on batch item modification and deletion I do not think it makes sense to have both. Signed-off-by: George Williams <george@nekls.org> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Nice work everyone! Pushed to master for 20.05 Pushed to 19.11.01 backported to 19.05.x for 19.05.06 Backported to 18.11.x for 18.11.14. |