Summary: | All status fields in the item edit interface offer two blank/null entries per dropdown instead of one | ||
---|---|---|---|
Product: | Koha | Reporter: | Chris Cormack <chris> |
Component: | Cataloging | Assignee: | Katrin Fischer <katrin.fischer> |
Status: | CLOSED FIXED | QA Contact: | Bugs List <koha-bugs> |
Severity: | normal | ||
Priority: | P3 | CC: | jonathan.druart, nengard, paul.poulain |
Version: | 3.6 | ||
Hardware: | PC | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | --- |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: | ||
Circulation function: | |||
Attachments: |
Bug 2399: All status fields in the item edit interface offer two blank/null entries per dropdown instead of one
Bug 2399: Follow up removing MySQLisms from ru-RU and uk-UA sample files Bug 2399: All status fields in the item edit interface offer two blank/null entries per dropdown instead of one Bug 2399: Follow up removing MySQLisms from ru-RU and uk-UA sample files |
Description
Chris Cormack
2010-05-21 00:50:45 UTC
This bug hasn't been touched in nearly another year, please revisit and test and close if appropriate. For subfields 4, 5, and 7 of the item record this is still an issue in 3.4. Updating version to master, 5 and 7 still have 2 empty lines theres For 3.6 it's 4,5 and 7. I think the problem is caused by the sample data for authorized values. Perhaps the line for 0 without description should be removed from all the sample data? But I am not sure if it's safe to do this? Created attachment 8783 [details] [review] Bug 2399: All status fields in the item edit interface offer two blank/null entries per dropdown instead of one Removes the '0' values without description from the sample date for authorised values. To test: 1) Verify that SQL files load correctly - truncate authorised_values; /* empty authorised values table */ - load sample data using one of the SQL files 2) Check cataloging interface - all status fields should only show 1 empty line Created attachment 8828 [details] [review] Bug 2399: Follow up removing MySQLisms from ru-RU and uk-UA sample files (In reply to comment #4) Perhaps a better way to do this is to remove this empty entry in template files ? Just for discussion. (In reply to comment #5) > Created attachment 8828 [details] [review] > Bug 2399: Follow up removing MySQLisms from ru-RU and uk-UA sample files This patch does not remove all the MYSQLism, LAST_INSERT_ID is a MYSQLism :-/ Hi Jonathan, I only touched those lines and removed the '' because I had to renumber them to keep the current functionality. Can we please take a note of that mysqlism and remove it another time? I think the empty lines have been introduced a longer time ago and people have adjusted to them modifying their authorized values. Removing the empty lines now will cause a lot of trouble, removing those lines without descriptions from the sample files will hurt no existing installations. Also I think it's much nicer to make Koha put in an empty line than to expect people insert those into the authorized values. Created attachment 9006 [details] [review] Bug 2399: All status fields in the item edit interface offer two blank/null entries per dropdown instead of one Removes the '0' values without description from the sample date for authorised values. To test: 1) Verify that SQL files load correctly - truncate authorised_values; /* empty authorised values table */ - load sample data using one of the SQL files 2) Check cataloging interface - all status fields should only show 1 empty line Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz> Created attachment 9007 [details] [review] Bug 2399: Follow up removing MySQLisms from ru-RU and uk-UA sample files Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz> QA Comment: First patch delete the empty line for authorised values and remove backquotes. Second patch remove backquotes from ru-RU and uk-UA files. Marked as Passed QA This patch will be in 3.6.6. |