Bug 24007

Summary: Koha::Account::non_issues_charges is badly named
Product: Koha Reporter: Martin Renvoize <martin.renvoize>
Component: Architecture, internals, and plumbingAssignee: Martin Renvoize <martin.renvoize>
Status: NEW --- QA Contact: Testopia <testopia>
Severity: enhancement    
Priority: P5 - low CC: jonathan.druart, kyle, tomascohen
Version: Main   
Hardware: All   
OS: All   
See Also: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23822
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23293
Change sponsored?: --- Patch complexity: ---
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:
Bug Depends on: 24009, 23293    
Bug Blocks: 14825    

Description Martin Renvoize 2019-11-11 12:19:45 UTC
The non_issues_charges method name suggests you will be returned a set of charges (Account::Lines) which would block a patrons ability to check out items.

In fact, it returns a 'balance' of such charges but includes outstanding credits in the calculation.

We should either rename the method to clarify it's use or update the method to return the expectation given it's naming.