Bug 24007 - Koha::Account::non_issues_charges is badly named
Summary: Koha::Account::non_issues_charges is badly named
Status: NEW
Alias: None
Product: Koha
Classification: Unclassified
Component: Architecture, internals, and plumbing (show other bugs)
Version: Main
Hardware: All All
: P5 - low enhancement
Assignee: Martin Renvoize (ashimema)
QA Contact: Testopia
URL:
Keywords:
Depends on: 23293 24009
Blocks: 14825
  Show dependency treegraph
 
Reported: 2019-11-11 12:19 UTC by Martin Renvoize (ashimema)
Modified: 2019-11-11 15:49 UTC (History)
3 users (show)

See Also:
GIT URL:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
Circulation function:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Martin Renvoize (ashimema) 2019-11-11 12:19:45 UTC
The non_issues_charges method name suggests you will be returned a set of charges (Account::Lines) which would block a patrons ability to check out items.

In fact, it returns a 'balance' of such charges but includes outstanding credits in the calculation.

We should either rename the method to clarify it's use or update the method to return the expectation given it's naming.