Summary: | Errors with use of CanItemBeReserved return value | ||
---|---|---|---|
Product: | Koha | Reporter: | Fridolin Somers <fridolin.somers> |
Component: | Hold requests | Assignee: | Jonathan Druart <jonathan.druart> |
Status: | CLOSED FIXED | QA Contact: | Marcel de Rooy <m.de.rooy> |
Severity: | critical | ||
Priority: | P5 - low | CC: | 1joynelson, arthur.suzuki, gmcharlt, jonathan.druart, kyle, lucas, m.de.rooy, martin.renvoize, tomascohen |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | Small patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: |
20.05.00, 19.11.01
|
|
Circulation function: | |||
Bug Depends on: | 15524, 23116 | ||
Bug Blocks: | |||
Attachments: |
Bug 24168: (bug 23116 follow-up) AllowHoldPolicyOverride allows a librarian to almost place a hold on an item already on hold
Bug 24168: (bug 23116 follow-up) AllowHoldPolicyOverride allows a librarian to almost place a hold on an item already on hold |
Description
Fridolin Somers
2019-12-04 10:56:34 UTC
(In reply to Fridolin SOMERS from comment #1) > Also impact on Bug 22330 Oups sorry no its correct : my $canitembereserved = C4::Reserves::CanItemBeReserved( $borrowernumber, $itemnumber, $branch )->{status}; Created attachment 95994 [details] [review] Bug 24168: (bug 23116 follow-up) AllowHoldPolicyOverride allows a librarian to almost place a hold on an item already on hold This patch actually fixes the issue described on bug 23116. Test plan: See bug 23116. Hmm. I actually do not see the difference this patch makes. Looks to me if nothing really changes here. Before we tested $var->{status} eq 'OK' and now we put status into $var and test $var eq 'OK'. Where is the bug that we should solve ? Take a look at the file and search for "can_item_be_reserved". There is another occurrence. Created attachment 96099 [details] [review] Bug 24168: (bug 23116 follow-up) AllowHoldPolicyOverride allows a librarian to almost place a hold on an item already on hold This patch actually fixes the issue described on bug 23116. Test plan: See bug 23116. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> See also comment5. Important to note that the later comparison with itemAlreadyOnHold assumes that the variable is a string. (In reply to Jonathan Druart from comment #5) > Take a look at the file and search for "can_item_be_reserved". > There is another occurrence. OK Thats the point. Passed QA Nice work everyone! Pushed to master for 20.05 Pushed to stable 19.11.01 backported to 19.05.x for 19.05.06 |