Bug 24186

Summary: maxFine can break fine reductions in updateFine
Product: Koha Reporter: Martin Renvoize (ashimema) <martin.renvoize>
Component: Fines and feesAssignee: Bugs List <koha-bugs>
Status: NEW --- QA Contact: Testopia <testopia>
Severity: enhancement    
Priority: P5 - low CC: nick
Version: unspecified   
Hardware: All   
OS: All   
Change sponsored?: --- Patch complexity: ---
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:
Circulation function:
Bug Depends on: 24146    
Bug Blocks:    
Attachments: Bug 24186: Add Tests
Add Debugging

Description Martin Renvoize (ashimema) 2019-12-06 15:54:58 UTC
If maxFine is enabled and the user has hit their maxFine limit, then in a backdated return situation where a fine may need discounting via updateFine, the discount will not be applied as the current code will short circuit before calling adjust due it assuming all calls to updateFine are increases.
Comment 1 Martin Renvoize (ashimema) 2019-12-06 16:55:21 UTC
Created attachment 96073 [details] [review]
Bug 24186: Add Tests
Comment 2 Martin Renvoize (ashimema) 2019-12-06 16:55:24 UTC
Created attachment 96074 [details] [review]
Add Debugging
Comment 3 Katrin Fischer 2023-12-31 10:55:01 UTC
Ping?