Bug 24186 - maxFine can break fine reductions in updateFine
Summary: maxFine can break fine reductions in updateFine
Status: NEW
Alias: None
Product: Koha
Classification: Unclassified
Component: Fines and fees (show other bugs)
Version: unspecified
Hardware: All All
: P5 - low enhancement
Assignee: Bugs List
QA Contact: Testopia
URL:
Keywords:
Depends on: 24146
Blocks:
  Show dependency tree / graph
 
Reported: 2019-12-06 15:54 UTC by Martin Renvoize (ashimema)
Modified: 2023-12-31 10:55 UTC (History)
1 user (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
Circulation function:

Attachments
Bug 24186: Add Tests (2.89 KB, patch)
2019-12-06 16:55 UTC, Martin Renvoize (ashimema) 		Details | Diff | Splinter Review
Add Debugging (1.38 KB, patch)
2019-12-06 16:55 UTC, Martin Renvoize (ashimema) 		Details | Diff | Splinter Review
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Martin Renvoize (ashimema) 2019-12-06 15:54:58 UTC 
If maxFine is enabled and the user has hit their maxFine limit, then in a backdated return situation where a fine may need discounting via updateFine, the discount will not be applied as the current code will short circuit before calling adjust due it assuming all calls to updateFine are increases.
Comment 1 Martin Renvoize (ashimema) 2019-12-06 16:55:21 UTC 
Created attachment 96073 [details] [review]
Bug 24186: Add Tests
Comment 2 Martin Renvoize (ashimema) 2019-12-06 16:55:24 UTC 
Created attachment 96074 [details] [review]
Add Debugging
Comment 3 Katrin Fischer 2023-12-31 10:55:01 UTC 
Ping?