Summary: | List on opac missing close form tag under some conditions | ||
---|---|---|---|
Product: | Koha | Reporter: | Nick Clemens (kidclamp) <nick> |
Component: | OPAC | Assignee: | Nick Clemens (kidclamp) <nick> |
Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
Severity: | minor | ||
Priority: | P5 - low | CC: | 1joynelson, hayleypelham, lucas |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
GIT URL: | Change sponsored?: | --- | |
Patch complexity: | Trivial patch | Documentation contact: | |
Documentation submission: | Text to go in the release notes: | ||
Version(s) released in: |
20.05.00, 19.11.02, 19.05.07, 18.11.13
|
Circulation function: | |
Attachments: |
Bug 24240: Move form closing tag outside of conditional
Bug 24240: Move form closing tag outside of conditional Bug 24240: Move form closing tag outside of conditional |
Description
Nick Clemens (kidclamp)
2019-12-13 14:24:10 UTC
Created attachment 96253 [details] [review] Bug 24240: Move form closing tag outside of conditional To test: 1 - Create a public list 2 - View the list as a user not signed in 3 - Validate the HTML, note the div closed with open elements, and a form tag unclosed 4 - Apply patch 5 - Those errors are fixed Created attachment 96298 [details] [review] Bug 24240: Move form closing tag outside of conditional To test: 1 - Create a public list 2 - View the list as a user not signed in 3 - Validate the HTML, note the div closed with open elements, and a form tag unclosed 4 - Apply patch 5 - Those errors are fixed Signed-off-by: Owen Leonard <oleonard@myacpl.org> Created attachment 96314 [details] [review] Bug 24240: Move form closing tag outside of conditional To test: 1 - Create a public list 2 - View the list as a user not signed in 3 - Validate the HTML, note the div closed with open elements, and a form tag unclosed 4 - Apply patch 5 - Those errors are fixed Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Nice work everyone! Pushed to master for 20.05 Pushed to 19.11.x branch for 19.11.02 backported to 19.05.x for 19.05.07 Backported to 18.11.x for 18.11.13 |