The myform form on opac-shelves.tt only gets a closing tag if the user can manage the list or remove items. For public lists this is often not the case
Created attachment 96253 [details] [review] Bug 24240: Move form closing tag outside of conditional To test: 1 - Create a public list 2 - View the list as a user not signed in 3 - Validate the HTML, note the div closed with open elements, and a form tag unclosed 4 - Apply patch 5 - Those errors are fixed
Created attachment 96298 [details] [review] Bug 24240: Move form closing tag outside of conditional To test: 1 - Create a public list 2 - View the list as a user not signed in 3 - Validate the HTML, note the div closed with open elements, and a form tag unclosed 4 - Apply patch 5 - Those errors are fixed Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Created attachment 96314 [details] [review] Bug 24240: Move form closing tag outside of conditional To test: 1 - Create a public list 2 - View the list as a user not signed in 3 - Validate the HTML, note the div closed with open elements, and a form tag unclosed 4 - Apply patch 5 - Those errors are fixed Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Nice work everyone! Pushed to master for 20.05
Pushed to 19.11.x branch for 19.11.02
backported to 19.05.x for 19.05.07
Backported to 18.11.x for 18.11.13