Summary: | Management permissions is deprecated | ||
---|---|---|---|
Product: | Koha | Reporter: | Nicole C. Engard <nengard> |
Component: | Patrons | Assignee: | Katrin Fischer <katrin.fischer> |
Status: | CLOSED FIXED | QA Contact: | Marcel de Rooy <m.de.rooy> |
Severity: | normal | ||
Priority: | P3 | CC: | m.de.rooy, magnus, martin.renvoize, nick, pasi.kallinen, veron |
Version: | Main | ||
Hardware: | PC | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | Small patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: | ||
Circulation function: | |||
Attachments: |
Bug 2426: Remove deprecated management permission
Bug 2426: Remove deprecated management permission Bug 2426: Remove deprecated management permission Bug 2426: Remove deprecated management permission |
Description
Chris Cormack
2010-05-21 00:51:03 UTC
This is a real old bug. I don't think we have the permission 'management Set library management parameters' in our granular permissions system that is now standard. Does the bug still exist or is it working correctly for IndependentBranches now? "management Set library management parameters" is still there, not sure about what it does, though. It is still there and as the chat shows I was told that it doesn't do anything ... so the question is why aren't we removing it? The original question is still unanswered: How do we handle the permission to set the branch when IndenpendantBranches is turned on: <strong>[% LoginBranchname %]</strong> [% IF ( IndependantBranches ) %] [% IF ( CAN_user_management ) %] (<a href="/cgi-bin/koha/circ/selectbranchprinter.pl">Set</a>) [% END %] [% ELSE %] (<a href="/cgi-bin/koha/circ/selectbranchprinter.pl">Set</a>) [% END %] It sounds like gmcharlt proposed a new granular permission, catalogue->setbranch. I'm not sure what atz meant by "a psuedo permission," but if any work followed from that it's probably locked up in LEK now. *** Bug 11776 has been marked as a duplicate of this bug. *** It appears the only remaining code for this permission has been changed since and now also checks for another permission: 66 [% IF ( CAN_user_management || CAN_user_editcatalogue_edit_catalogue ) %] 67 <li> 68 <a class="toplinks" href="/cgi-bin/koha/circ/selectbranchprinter.pl">Set library</a> 69 </li> 70 [% END %] Might be a good time to finally remove the permission? Created attachment 75348 [details] [review] Bug 2426: Remove deprecated management permission After review of the code it turns out that the management permission that has been marked as deprecated a long time ago, does not have any function. The patch removes all remaining code related to it. To test: - Make sure you have a patron with the management permission - Apply patch - Run database update - Check everything still works as expected Bonus: borrowers.flags is recalculated for patrons with management permission. To check: - Create some 'permission twins' with and without management permission - Note the value in borrowers.flags - Apply patch, don't run database update - Save permissions from GUI for one of the twins - Note the newly calculated value - Run database update - Now both twins should have the same borrowers.flags value Created attachment 75349 [details] [review] Bug 2426: Remove deprecated management permission After review of the code it turns out that the management permission that has been marked as deprecated a long time ago, does not have any function. The patch removes all remaining code related to it. To test: - Make sure you have a patron with the management permission - Apply patch - Run database update - Check everything still works as expected Bonus: borrowers.flags is recalculated for patrons with management permission. To check: - Create some 'permission twins' with and without management permission - Note the value in borrowers.flags - Apply patch, don't run database update - Save permissions from GUI for one of the twins - Note the newly calculated value - Run database update - Now both twins should have the same borrowers.flags value Created attachment 75476 [details] [review] Bug 2426: Remove deprecated management permission After review of the code it turns out that the management permission that has been marked as deprecated a long time ago, does not have any function. The patch removes all remaining code related to it. To test: - Make sure you have a patron with the management permission - Apply patch - Run database update - Check everything still works as expected Bonus: borrowers.flags is recalculated for patrons with management permission. To check: - Create some 'permission twins' with and without management permission - Note the value in borrowers.flags - Apply patch, don't run database update - Save permissions from GUI for one of the twins - Note the newly calculated value - Run database update - Now both twins should have the same borrowers.flags value Signed-off-by: Owen Leonard <oleonard@myacpl.org> > Bonus:
> borrowers.flags is recalculated for patrons with management
> permission.
No bonus imo.
Created attachment 75562 [details] [review] Bug 2426: Remove deprecated management permission After review of the code it turns out that the management permission that has been marked as deprecated a long time ago, does not have any function. The patch removes all remaining code related to it. To test: - Make sure you have a patron with the management permission - Apply patch - Run database update - Check everything still works as expected Bonus: borrowers.flags is recalculated for patrons with management permission. To check: - Create some 'permission twins' with and without management permission - Note the value in borrowers.flags - Apply patch, don't run database update - Save permissions from GUI for one of the twins - Note the newly calculated value - Run database update - Now both twins should have the same borrowers.flags value Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Pushed to master for 18.11, awesome work all! Not pushing to 18.05.x as it could surprise unsuspecting librarians during a minor update having this permission disappear (even though it effectively does nothing at present). Nice fix for 18.11, marking resolved. |