| Summary: | SCSS conversion broke style in search results item status | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Fridolin Somers <fridolin.somers> |
| Component: | Templates | Assignee: | Fridolin Somers <fridolin.somers> |
| Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
| Severity: | normal | ||
| Priority: | P5 - low | CC: | andrew, hayleypelham, lucas |
| Version: | Main | ||
| Hardware: | All | ||
| OS: | All | ||
| Change sponsored?: | --- | Patch complexity: | Trivial patch |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: |
20.05.00, 19.05.07
|
|
| Circulation function: | |||
| Attachments: |
Bug 24282: SCSS conversion broke style in search results item status
Bug 24282: SCSS conversion broke style in search results item status Bug 24282: SCSS conversion broke style in search results item status |
||
Created attachment 96505 [details] [review] Bug 24282: SCSS conversion broke style in search results item status Before SCSS conversion, there was a style for search results item status : #searchresults span.status { Conversion to SCSS added ul : #searchresults ul span.status { Now style does not apply anymore. You can see that items on loan are not red anymore. To test, apply the patch and regenerate your CSS (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_client). Clear your browser cache if necessary. All rules using #searchresults in 17.11 : font-size : 90%; list-style: url(../img/item-bullet.gif); padding : .2em 0; clear : left; } clear : left; color : #900; display : block; } clear : left; display : block; } display : block; } float : left; margin : 3px 5px 3px -5px; } vertical-align : top; } Apply patch update intranet CSS file and check you see the same rules. Created attachment 96620 [details] [review] Bug 24282: SCSS conversion broke style in search results item status Before SCSS conversion, there was a style for search results item status : #searchresults span.status { Conversion to SCSS added ul : #searchresults ul span.status { Now style does not apply anymore. You can see that items on loan are not red anymore. To test, apply the patch and regenerate your CSS (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_client). Clear your browser cache if necessary. All rules using #searchresults in 17.11 : font-size : 90%; list-style: url(../img/item-bullet.gif); padding : .2em 0; clear : left; } clear : left; color : #900; display : block; } clear : left; display : block; } display : block; } float : left; margin : 3px 5px 3px -5px; } vertical-align : top; } Apply patch update intranet CSS file and check you see the same rules. Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> Created attachment 96672 [details] [review] Bug 24282: SCSS conversion broke style in search results item status Before SCSS conversion, there was a style for search results item status : #searchresults span.status { Conversion to SCSS added ul : #searchresults ul span.status { Now style does not apply anymore. You can see that items on loan are not red anymore. To test, apply the patch and regenerate your CSS (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_client). Clear your browser cache if necessary. All rules using #searchresults in 17.11 : font-size : 90%; list-style: url(../img/item-bullet.gif); padding : .2em 0; clear : left; } clear : left; color : #900; display : block; } clear : left; display : block; } display : block; } float : left; margin : 3px 5px 3px -5px; } vertical-align : top; } Apply patch update intranet CSS file and check you see the same rules. Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> *** Bug 24234 has been marked as a duplicate of this bug. *** Nice work everyone! Pushed to master for 20.05 backported to 19.05.x for 19.05.07 |
Before SCSS conversion, there was a style for search results item status : #searchresults span.status { Conversion to SCSS added ul : #searchresults ul span.status { Now style does not apply anymore. You can see that items on loan are not red anymore.