Bug 24234 - Spacing of availability note in intranet search results unclear
Summary: Spacing of availability note in intranet search results unclear
Status: RESOLVED DUPLICATE of bug 24282
Alias: None
Product: Koha
Classification: Unclassified
Component: Searching (show other bugs)
Version: master
Hardware: All All
: P5 - low minor (vote)
Assignee: Lucas Gass
QA Contact: Testopia
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2019-12-12 21:09 UTC by Andrew Fuerste-Henry
Modified: 2019-12-29 15:34 UTC (History)
4 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
results list (64.81 KB, image/png)
2019-12-12 21:09 UTC, Andrew Fuerste-Henry
Details
Bug 24234: fix css in staff search results (1007 bytes, patch)
2019-12-14 20:29 UTC, Lucas Gass
Details | Diff | Splinter Review
Bug 24234: fix css in staff search results (1.05 KB, patch)
2019-12-16 17:45 UTC, ByWater Sandboxes
Details | Diff | Splinter Review
Bug 24234: fix css in staff search results (1.11 KB, patch)
2019-12-16 17:50 UTC, ByWater Sandboxes
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Andrew Fuerste-Henry 2019-12-12 21:09:47 UTC
Created attachment 96233 [details]
results list

In search results on the Intranet, Koha lists available copies then unavailable copies, with a note about why they're unavailable. See attached screenshot. The spacing of this information makes the unavailable note ("1 unavailable:" or "1 on loan:") end up closer to the item above than the item below, giving the impression that the note applies to the first item rather than the second.
Comment 1 Lucas Gass 2019-12-14 20:29:36 UTC
Created attachment 96290 [details] [review]
Bug 24234: fix css in staff search results

A simple CSS change to make “x on loan:” and “x unavailable:” heading bold. It also confines the width/weight of img so it can never push the headings out to the right.
 
TEST PLAN:
1 - search for a record with at least 3 items. Check one out, make another one damaged, and keep one available. 
2. Search for the record
3. See unclear results in the availability section.
4. Apply patch and regenerate css (yarn build)
5. restart_all and clear cache.
6. view new, easier to read availability section
Comment 2 Andrew Fuerste-Henry 2019-12-16 17:24:38 UTC
Had to install yarn to get it to work on a sandbox, but otherwise looks good! Signing off.
Comment 3 ByWater Sandboxes 2019-12-16 17:45:07 UTC
Created attachment 96348 [details] [review]
Bug 24234: fix css in staff search results

Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com>
Comment 4 ByWater Sandboxes 2019-12-16 17:50:37 UTC
Created attachment 96349 [details] [review]
Bug 24234: fix css in staff search results

Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com>

Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com>
Comment 5 Katrin Fischer 2019-12-22 17:06:48 UTC
I like the boldness on the subheadings, but not sure about the boldness on the locations. I think it might be a bit too much. 
Adding Owen for another opinion.
Comment 6 Lucas Gass 2019-12-23 23:09:44 UTC
I think this
Comment 7 Lucas Gass 2019-12-23 23:10:48 UTC
I think this bug is actually fixed by bz24282.
Comment 8 Jonathan Druart 2019-12-27 14:57:59 UTC
(In reply to Lucas Gass from comment #7)
> I think this bug is actually fixed by bz24282.

Should we mark it as duplicated then?
Comment 9 Katrin Fischer 2019-12-29 15:34:09 UTC
As Lucas signed the other one off, I marked them as duplicate - please reopen if there is still some change to be made!

*** This bug has been marked as a duplicate of bug 24282 ***