Bug 24317

Summary: Sample patron data not loading for non-English installations
Product: Koha Reporter: Katrin Fischer <katrin.fischer>
Component: Installation and upgrade (web-based installer)Assignee: Kyle M Hall <kyle>
Status: CLOSED FIXED QA Contact: Testopia <testopia>
Severity: major    
Priority: P5 - low CC: bgkriegel, gmcharlt, kyle, lucas
Version: Main   
Hardware: All   
OS: All   
See Also: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24314
Change sponsored?: --- Patch complexity: Small patch
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:
20.05.00
Bug Depends on: 14570    
Bug Blocks:    
Attachments: Bug 24317 - Sample patron data not loading for non-English installations
Bug 24317: Sample patron data not loading for non-English installations
Bug 24317: Sample patron data not loading for non-English installations

Description Katrin Fischer 2019-12-29 22:30:57 UTC
Bug 14570 removed the guarantorid column from the English sample data but missed the other translated installers. This means the sample patrons can no longer be installed for other languages.
Comment 1 Kyle M Hall 2019-12-30 11:55:06 UTC
Created attachment 96678 [details] [review]
Bug 24317 - Sample patron data not loading for non-English installations

Bug 14570 removed the guarantorid column from the English sample data but missed the other translated installers. This means the sample patrons can no longer be installed for other languages.

Test Plan:
1) Attempt to install the sample patron data in German, Spanish, Norwegian, and Polish
2) Note the error
3) Apply this patch
4) Repeat step 1
5) No error!
Comment 2 Katrin Fischer 2019-12-30 12:59:52 UTC
Thx Kyle!
Comment 3 Bernardo Gonzalez Kriegel 2019-12-31 00:07:27 UTC
Created attachment 96691 [details] [review]
Bug 24317: Sample patron data not loading for non-English installations

Bug 14570 removed the guarantorid column from the English sample data but missed the other translated installers. This means the sample patrons can no longer be installed for other languages.

Test Plan:
1) Attempt to install the sample patron data in German, Spanish, Norwegian, and Polish
2) Note the error
3) Apply this patch
4) Repeat step 1
5) No error!

Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com>

On top of Bug 24316 + followup

Tested doing clean install for de-DE es-ES fr-CA it-IT nb-NO pl-PL
up to loading of all mandatory & optional data.
All languages load without problems.
A small qa error fixed in commit message.
Comment 4 Katrin Fischer 2019-12-31 09:40:43 UTC
Created attachment 96700 [details] [review]
Bug 24317: Sample patron data not loading for non-English installations

Bug 14570 removed the guarantorid column from the English sample data but missed the other translated installers. This means the sample patrons can no longer be installed for other languages.

Test Plan:
1) Attempt to install the sample patron data in German, Spanish, Norwegian, and Polish
2) Note the error
3) Apply this patch
4) Repeat step 1
5) No error!

Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com>

On top of Bug 24316 + followup

Tested doing clean install for de-DE es-ES fr-CA it-IT nb-NO pl-PL
up to loading of all mandatory & optional data.
All languages load without problems.
A small qa error fixed in commit message.

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Comment 5 Martin Renvoize 2020-01-02 12:19:29 UTC
Nice work everyone!

Pushed to master for 20.05
Comment 6 Lucas Gass 2020-01-15 18:21:24 UTC
missing dependencies for 19.05.x, no backport