Bug 23049 replaced the MANUAL_INV authorised value by a dedicated table, but missed to remove the authorised value sample data from the non English installers. Marking major as this causes errors in the web installer.
Created attachment 96677 [details] [review] Bug 24316: Remove obsolete sample data for MANUAL_INV authorised value Bug 23049 replaced the MANUAL_INV authorised value by a dedicated table, but missed to remove the authorised value sample data from the non-English installers. This patch corrects this oversight. Note: The German (de-DE) file was changed a bit more, adding 2 missing translations for the new RETURN_CLAIM_RESOLUTION and to match the sequence of the en file. To test: - Verify the SQL file changes are valid by loading those files OR - Run the installers for each language on an empty database - Verify there is no error loading the optional authorised value data
Created attachment 96692 [details] [review] Bug 24316: Remove obsolete sample data for MANUAL_INV authorised value Bug 23049 replaced the MANUAL_INV authorised value by a dedicated table, but missed to remove the authorised value sample data from the non-English installers. This patch corrects this oversight. Note: The German (de-DE) file was changed a bit more, adding 2 missing translations for the new RETURN_CLAIM_RESOLUTION and to match the sequence of the en file. To test: - Verify the SQL file changes are valid by loading those files OR - Run the installers for each language on an empty database - Verify there is no error loading the optional authorised value data Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Tested with 24317 and a small followup for this bug for es-ES Tested doing clean install for de-DE es-ES fr-CA it-IT nb-NO pl-PL up to loading of all mandatory & optional data. All languages load without problems.
Created attachment 96693 [details] [review] Bug 24316: (follow up) Fix es-ES web installer Same correction, as other languages, removing obsolete authorised value MANUAL_INV. Same test
Last patch needs a sign
Created attachment 96699 [details] [review] Bug 24316: (follow up) Fix es-ES web installer Same correction, as other languages, removing obsolete authorised value MANUAL_INV. Same test Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Thx Bernardo!
Should not we remove it (again) for existing installs?
I think it's ok - since the authorised_value category was missing, this shoudl not have been installed in fresh installations. And for everyone updating it would have worked correctly, only fresh 19.11 would be in danger (and the sql was broken there). But we can still.. not blocking :)
Created attachment 96736 [details] [review] Bug 24316: Remove obsolete sample data for MANUAL_INV authorised value Bug 23049 replaced the MANUAL_INV authorised value by a dedicated table, but missed to remove the authorised value sample data from the non-English installers. This patch corrects this oversight. Note: The German (de-DE) file was changed a bit more, adding 2 missing translations for the new RETURN_CLAIM_RESOLUTION and to match the sequence of the en file. To test: - Verify the SQL file changes are valid by loading those files OR - Run the installers for each language on an empty database - Verify there is no error loading the optional authorised value data Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Tested with 24317 and a small followup for this bug for es-ES Tested doing clean install for de-DE es-ES fr-CA it-IT nb-NO pl-PL up to loading of all mandatory & optional data. All languages load without problems. Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Created attachment 96737 [details] [review] Bug 24316: (follow up) Fix es-ES web installer Same correction, as other languages, removing obsolete authorised value MANUAL_INV. Same test Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Nice work everyone! Pushed to master for 20.05
Pushed to 19.11.x branch for 19.11.02
missing dependencies for 19.05.x, no backport