|
Description
Martin Renvoize (ashimema)
2020-01-03 16:53:14 UTC
Created attachment 97972 [details] [review] Bug 24338: Add 'CASH' to default 'PAYMENT_TYPE' AV Bug 23321 adds cash registers to the koha accounts system and as part of that work introduces the 'CASH' payment type as a required option to allow requirment of a 'CASH_REGISTER' when making cash payments. The original patchset, however, forgot to add this new authorised value during installation and upgrade. On master I can already see a CASH payment type, so not sure whether this is required or not. OK, so on master it's already added in bug 23354, but it's not in the 19.11 branch yet. Setting branch appropriately. Patch doesn't apply on 19.11.x Created attachment 98381 [details] [review] Bug 24338: Add 'CASH' to default 'PAYMENT_TYPE' AV Bug 23321 adds cash registers to the koha accounts system and as part of that work introduces the 'CASH' payment type as a required option to allow requirment of a 'CASH_REGISTER' when making cash payments. The original patchset, however, forgot to add this new authorised value during installation and upgrade. Does it matter that this is not idempotent? You can have repeated values in the authorised_values table with no complaints - should there be a key on id,category,authorised_value? Created attachment 98388 [details] [review] Bug 24338: (QA follow-up) Make update idempotent Good catch Created attachment 98412 [details] [review] Bug 24338: Add 'CASH' to default 'PAYMENT_TYPE' AV Bug 23321 adds cash registers to the koha accounts system and as part of that work introduces the 'CASH' payment type as a required option to allow requirment of a 'CASH_REGISTER' when making cash payments. The original patchset, however, forgot to add this new authorised value during installation and upgrade. Test plan: 1) Check the values shown for the PAYMENT_TYPE authorized value category (Home > Administration > Basic parameters > Authorized values) 2) There should be no CASH authorized value 3) Apply the patch 4) Run the database update (perl installer/data/mysql/updatedatabase.pl) 5) Refresh the PAYMENT_TYPE authorized value page 6) A CASH authorized value should now be one of the values 7) Sign-off! Signed-off-by: David Nind <david@davidnind.com> Created attachment 98413 [details] [review] Bug 24338: (QA follow-up) Make update idempotent Signed-off-by: David Nind <david@davidnind.com> Do we really need the print statements? (In reply to Jonathan Druart from comment #11) > Do we really need the print statements? Oops, not at all.. leftover debugging whilst I was working on the DB update.. my bad. Created attachment 98490 [details] [review] Bug 24338: Add 'CASH' to default 'PAYMENT_TYPE' AV Bug 23321 adds cash registers to the koha accounts system and as part of that work introduces the 'CASH' payment type as a required option to allow requirment of a 'CASH_REGISTER' when making cash payments. The original patchset, however, forgot to add this new authorised value during installation and upgrade. Signed-off-by: David Nind <david@davidnind.com> Created attachment 98491 [details] [review] Bug 24338: (QA follow-up) Make update idempotent Signed-off-by: David Nind <david@davidnind.com> Second patch now corrected to remove debug print lines. Created attachment 98504 [details] [review] Bug 24338: Add 'CASH' to default 'PAYMENT_TYPE' AV Bug 23321 adds cash registers to the koha accounts system and as part of that work introduces the 'CASH' payment type as a required option to allow requirment of a 'CASH_REGISTER' when making cash payments. The original patchset, however, forgot to add this new authorised value during installation and upgrade. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Created attachment 98505 [details] [review] Bug 24338: (QA follow-up) Make update idempotent Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Pushed to 19.11.x branch for 19.11.03 release missing dependencies for 19.05.x, no backport |