| Summary: | Add support for more complex markup in OPAC confirmation dialogs | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Owen Leonard <oleonard> |
| Component: | Templates | Assignee: | Owen Leonard <oleonard> |
| Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
| Severity: | enhancement | ||
| Priority: | P5 - low | CC: | 1joynelson, martin.renvoize, maryse.simard, testopia |
| Version: | Main | ||
| Hardware: | All | ||
| OS: | All | ||
| Change sponsored?: | --- | Patch complexity: | Small patch |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: |
20.05.00
|
|
| Circulation function: | |||
| Bug Depends on: | 21870 | ||
| Bug Blocks: | 24336, 24433 | ||
| Attachments: |
Bug 24341: Allow for more complex markup in OPAC confirmation dialogs
Bug 24341: Allow for more complex markup in OPAC confirmation dialogs Bug 24341: Allow for more complex markup in OPAC confirmation dialogs |
||
|
Description
Owen Leonard
2020-01-03 17:39:11 UTC
Created attachment 96796 [details] [review] Bug 24341: Allow for more complex markup in OPAC confirmation dialogs This patch changes the globally-available confirmModal() function in the OPAC so that it uses jQuery's html() function for adding information to the confirmation modal's body. This will allow for more than just plain text to be added. This patch also removes some obsolete lines from the JavaScript in opac-user.tt and renames some variable for clarity. To test, apply the patch log in to the OPAC as a user who has holds and article requests. - Test the following interactions, both the confirmation and cancel options for each: - Cancel a hold - Suspend all holds - Resume all holds - Cancel an article request Created attachment 97420 [details] [review] Bug 24341: Allow for more complex markup in OPAC confirmation dialogs This patch changes the globally-available confirmModal() function in the OPAC so that it uses jQuery's html() function for adding information to the confirmation modal's body. This will allow for more than just plain text to be added. This patch also removes some obsolete lines from the JavaScript in opac-user.tt and renames some variable for clarity. To test, apply the patch log in to the OPAC as a user who has holds and article requests. - Test the following interactions, both the confirmation and cancel options for each: - Cancel a hold - Suspend all holds - Resume all holds - Cancel an article request Signed-off-by: Maryse Simard <maryse.simard@inlibro.com> Cancelling a hold in the OPAC doesn't ask for confirmation in my testing - can you pleas check? (In reply to Katrin Fischer from comment #3) > Cancelling a hold in the OPAC doesn't ask for confirmation in my testing - > can you pleas check? This is true in master too. I've created Bug 24433 (In reply to Owen Leonard from comment #4) > (In reply to Katrin Fischer from comment #3) > > Cancelling a hold in the OPAC doesn't ask for confirmation in my testing - > > can you pleas check? > > This is true in master too. I've created Bug 24433 Thx Owen! Created attachment 97591 [details] [review] Bug 24341: Allow for more complex markup in OPAC confirmation dialogs This patch changes the globally-available confirmModal() function in the OPAC so that it uses jQuery's html() function for adding information to the confirmation modal's body. This will allow for more than just plain text to be added. This patch also removes some obsolete lines from the JavaScript in opac-user.tt and renames some variable for clarity. To test, apply the patch log in to the OPAC as a user who has holds and article requests. - Test the following interactions, both the confirmation and cancel options for each: - Cancel a hold - Suspend all holds - Resume all holds - Cancel an article request Signed-off-by: Maryse Simard <maryse.simard@inlibro.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Nice work everyone! Pushed to master for 20.05 Enhancement not backported to 19.11.x |