Bug 24419

Summary: Add Koha::Suggestion->suggester accessor
Product: Koha Reporter: Tomás Cohen Arazi <tomascohen>
Component: Architecture, internals, and plumbingAssignee: Tomás Cohen Arazi <tomascohen>
Status: CLOSED FIXED QA Contact: Testopia <testopia>
Severity: enhancement    
Priority: P5 - low CC: 1joynelson, jonathan.druart, kyle, martin.renvoize, tomascohen
Version: Main   
Hardware: All   
OS: All   
Change sponsored?: --- Patch complexity: ---
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:
20.05.00
Bug Depends on: 24418    
Bug Blocks: 20212    
Attachments: Bug 24419: Add Koha::Suggestion->suggestor accessor
Bug 24419: Add Koha::Suggestion->suggestor accessor
Bug 24419: Add Koha::Suggestion->suggestor accessor
Bug 24419: Add Koha::Suggestion->suggester accessor

Description Tomás Cohen Arazi 2020-01-14 15:23:09 UTC

    
Comment 1 Tomás Cohen Arazi 2020-01-14 15:51:01 UTC
Created attachment 97356 [details] [review]
Bug 24419: Add Koha::Suggestion->suggestor accessor

This patch adds a ->suggestor accessor to the Koha::Suggestion class. It
will return undef if no suggestor, and a Koha::Patron object otherwise.

To test:
1. Apply this patch
2. Run:
   $ kshell
  k$ prove t/db_dependent/Koha/Suggestion.t
=> SUCCESS: Tests pass!
3. Sign off :-D

Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Comment 2 Kyle M Hall 2020-01-14 18:12:29 UTC
Created attachment 97368 [details] [review]
Bug 24419: Add Koha::Suggestion->suggestor accessor

This patch adds a ->suggestor accessor to the Koha::Suggestion class. It
will return undef if no suggestor, and a Koha::Patron object otherwise.

To test:
1. Apply this patch
2. Run:
   $ kshell
  k$ prove t/db_dependent/Koha/Suggestion.t
=> SUCCESS: Tests pass!
3. Sign off :-D

Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Comment 3 Martin Renvoize 2020-01-15 08:39:08 UTC
Created attachment 97385 [details] [review]
Bug 24419: Add Koha::Suggestion->suggestor accessor

This patch adds a ->suggestor accessor to the Koha::Suggestion class. It
will return undef if no suggestor, and a Koha::Patron object otherwise.

To test:
1. Apply this patch
2. Run:
   $ kshell
  k$ prove t/db_dependent/Koha/Suggestion.t
=> SUCCESS: Tests pass!
3. Sign off :-D

Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Comment 4 Martin Renvoize 2020-01-15 08:39:50 UTC
All works as expected, passes qa test scripts.. Passing QA
Comment 5 Jonathan Druart 2020-01-17 07:05:33 UTC
Martin,
I asked you when I wrote bug 23991 and I think we agreed it was suggester, not suggestor.
Comment 6 Martin Renvoize 2020-01-17 10:03:40 UTC
Curse my bad spelling!
Comment 7 Tomás Cohen Arazi 2020-01-17 13:33:00 UTC
Created attachment 97515 [details] [review]
Bug 24419: Add Koha::Suggestion->suggester accessor

This patch adds a ->suggester accessor to the Koha::Suggestion class. It
will return undef if no suggester, and a Koha::Patron object otherwise.

To test:
1. Apply this patch
2. Run:
   $ kshell
  k$ prove t/db_dependent/Koha/Suggestion.t
=> SUCCESS: Tests pass!
3. Sign off :-D

Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Comment 8 Martin Renvoize 2020-01-20 16:34:33 UTC
Nice work everyone!

Pushed to master for 20.05
Comment 9 Joy Nelson 2020-02-06 22:28:20 UTC
enhancement not backported to 19.11.x