Bug 20212 - Slowness in Receiving in Acquisitions
Summary: Slowness in Receiving in Acquisitions
Status: ASSIGNED
Alias: None
Product: Koha
Classification: Unclassified
Component: Acquisitions (show other bugs)
Version: master
Hardware: All All
: P5 - low enhancement with 20 votes (vote)
Assignee: Tomás Cohen Arazi
QA Contact: Testopia
URL:
Keywords:
: 10959 (view as bug list)
Depends on: 24461 24561 24830 24918 25297 25670 18731 24366 24418 24419 24430 24435 24440 24448 24457 24462 24467 24528 24554
Blocks:
  Show dependency treegraph
 
Reported: 2018-02-15 13:44 UTC by Kyle M Hall
Modified: 2020-08-10 18:21 UTC (History)
9 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Who signed the patch off:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 20212: Extend datatables for API interaction (3.71 KB, patch)
2020-01-17 16:07 UTC, Tomás Cohen Arazi
Details | Diff | Splinter Review
Bug 20212: Add more embeddable objects to orders (2.19 KB, patch)
2020-01-17 16:08 UTC, Tomás Cohen Arazi
Details | Diff | Splinter Review
[WIP] Bug 20212: Use the API to render orders (15.97 KB, patch)
2020-01-17 16:08 UTC, Tomás Cohen Arazi
Details | Diff | Splinter Review
Bug 20212: Add more embeddable objects to orders (2.27 KB, patch)
2020-01-20 15:52 UTC, Tomás Cohen Arazi
Details | Diff | Splinter Review
[WIP] Bug 20212: Use the API to render orders (16.02 KB, patch)
2020-01-20 15:52 UTC, Tomás Cohen Arazi
Details | Diff | Splinter Review
Bug 20212: Add more embeddable objects to orders (2.34 KB, patch)
2020-01-20 19:20 UTC, Tomás Cohen Arazi
Details | Diff | Splinter Review
[WIP] Bug 20212: Use the API to render orders (16.14 KB, patch)
2020-01-20 19:20 UTC, Tomás Cohen Arazi
Details | Diff | Splinter Review
[WIP] Bug 20212: Use the API to render orders (29.10 KB, patch)
2020-01-20 20:01 UTC, Tomás Cohen Arazi
Details | Diff | Splinter Review
Bug 20212: Display correct number of items (1.19 KB, patch)
2020-01-22 16:20 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 20212: Use the API to render orders (31.22 KB, patch)
2020-01-31 12:21 UTC, Tomás Cohen Arazi
Details | Diff | Splinter Review
[WIP] Bug 20212: Use the API to render orders (32.26 KB, patch)
2020-01-31 13:23 UTC, Tomás Cohen Arazi
Details | Diff | Splinter Review
[WIP] Bug 20212: Use the API to render orders (32.27 KB, patch)
2020-01-31 14:45 UTC, Tomás Cohen Arazi
Details | Diff | Splinter Review
Bug 20212: Add more embeddable objects to orders (2.34 KB, patch)
2020-02-27 23:53 UTC, Agustín Moyano
Details | Diff | Splinter Review
Bug 20212: Use the API to render orders (32.27 KB, patch)
2020-02-27 23:53 UTC, Agustín Moyano
Details | Diff | Splinter Review
[WIP] Bug 20212: Use the API to render orders (32.27 KB, patch)
2020-02-27 23:54 UTC, Agustín Moyano
Details | Diff | Splinter Review
Bug 20212: Use the API to render orders (31.70 KB, patch)
2020-03-04 18:29 UTC, Tomás Cohen Arazi
Details | Diff | Splinter Review
Bug 20212: Add missing entried on schema files (3.42 KB, patch)
2020-03-10 19:24 UTC, Tomás Cohen Arazi
Details | Diff | Splinter Review
Bug 20212: Add more embeddable objects to orders (2.86 KB, patch)
2020-03-10 19:24 UTC, Tomás Cohen Arazi
Details | Diff | Splinter Review
Bug 20212: Allow filtering orders on ISBN (6.04 KB, patch)
2020-03-10 19:24 UTC, Tomás Cohen Arazi
Details | Diff | Splinter Review
Bug 20212: Use API to render orders datatable (37.72 KB, patch)
2020-03-10 19:24 UTC, Tomás Cohen Arazi
Details | Diff | Splinter Review
Bug 20212: Add missing entries on schema files (4.30 KB, patch)
2020-03-11 13:37 UTC, Tomás Cohen Arazi
Details | Diff | Splinter Review
Bug 20212: Add more embeddable objects to orders (2.86 KB, patch)
2020-03-11 13:37 UTC, Tomás Cohen Arazi
Details | Diff | Splinter Review
Bug 20212: Allow filtering orders on ISBN (6.04 KB, patch)
2020-03-11 13:38 UTC, Tomás Cohen Arazi
Details | Diff | Splinter Review
Bug 20212: Use API to render orders datatable (24.68 KB, patch)
2020-03-11 13:38 UTC, Tomás Cohen Arazi
Details | Diff | Splinter Review
Bug 20212: Add missing entries on schema files (5.18 KB, patch)
2020-03-11 18:49 UTC, Tomás Cohen Arazi
Details | Diff | Splinter Review
Bug 20212: Add more embeddable objects to orders (2.86 KB, patch)
2020-03-11 18:49 UTC, Tomás Cohen Arazi
Details | Diff | Splinter Review
Bug 20212: Allow filtering orders on biblioitems fields (6.23 KB, patch)
2020-03-11 18:49 UTC, Tomás Cohen Arazi
Details | Diff | Splinter Review
Bug 20212: Use API to render orders datatable (26.49 KB, patch)
2020-03-11 18:49 UTC, Tomás Cohen Arazi
Details | Diff | Splinter Review
Bug 20212: Use API to render orders datatable (34.97 KB, patch)
2020-03-11 20:11 UTC, Tomás Cohen Arazi
Details | Diff | Splinter Review
Bug 20212: Clean parcel.pl (5.55 KB, patch)
2020-03-11 20:11 UTC, Tomás Cohen Arazi
Details | Diff | Splinter Review
Bug 20212: Use API to render orders datatable (35.00 KB, patch)
2020-03-12 15:25 UTC, Tomás Cohen Arazi
Details | Diff | Splinter Review
Bug 20212: Add missing entries on schema files (4.88 KB, patch)
2020-03-20 19:28 UTC, Tomás Cohen Arazi
Details | Diff | Splinter Review
Bug 20212: Add more embeddable objects to orders (2.86 KB, patch)
2020-04-24 13:27 UTC, Tomás Cohen Arazi
Details | Diff | Splinter Review
Bug 20212: Allow filtering orders on biblioitems fields (6.23 KB, patch)
2020-04-24 13:27 UTC, Tomás Cohen Arazi
Details | Diff | Splinter Review
Bug 20212: Clean parcel.pl (5.56 KB, patch)
2020-04-24 13:27 UTC, Tomás Cohen Arazi
Details | Diff | Splinter Review
Bug 20212: Use API to render orders datatable (35.00 KB, patch)
2020-04-24 13:28 UTC, Tomás Cohen Arazi
Details | Diff | Splinter Review
Bug 20212: Add missing entries on schema files (2.07 KB, patch)
2020-04-24 13:28 UTC, Tomás Cohen Arazi
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Kyle M Hall 2018-02-15 13:44:27 UTC
Convert order tables from pre-loading all order data to ajax tables that load order data on an as needed basis.
Comment 1 Katrin Fischer 2018-02-15 16:10:32 UTC
*** Bug 10959 has been marked as a duplicate of this bug. ***
Comment 2 Liz Rea 2018-07-03 01:45:36 UTC
Is this work in progress or are other solutions to this acceptable.
Comment 3 Kyle M Hall 2018-07-09 16:50:04 UTC
(In reply to Liz Rea from comment #2)
> Is this work in progress or are other solutions to this acceptable.

If you have thoughts or plans I'd love to hear them! As far as I'm aware, we haven't put pen to paper yet :)
Comment 4 Tomás Cohen Arazi 2019-02-20 15:13:18 UTC Comment hidden (obsolete)
Comment 5 Tomás Cohen Arazi 2019-02-20 15:13:43 UTC
And please help make bug 18731 into master ASAP!
Comment 6 Tomás Cohen Arazi 2020-01-13 14:52:44 UTC
Time to finish this as all dependencies are in master \o/
Comment 7 Tomás Cohen Arazi 2020-01-17 16:07:59 UTC Comment hidden (obsolete)
Comment 8 Tomás Cohen Arazi 2020-01-17 16:08:02 UTC Comment hidden (obsolete)
Comment 9 Tomás Cohen Arazi 2020-01-17 16:08:06 UTC Comment hidden (obsolete)
Comment 10 Tomás Cohen Arazi 2020-01-17 16:09:03 UTC Comment hidden (obsolete)
Comment 11 Tomás Cohen Arazi 2020-01-20 15:52:48 UTC Comment hidden (obsolete)
Comment 12 Tomás Cohen Arazi 2020-01-20 15:52:52 UTC Comment hidden (obsolete)
Comment 13 Tomás Cohen Arazi 2020-01-20 15:54:19 UTC Comment hidden (obsolete)
Comment 14 Tomás Cohen Arazi 2020-01-20 19:20:09 UTC Comment hidden (obsolete)
Comment 15 Tomás Cohen Arazi 2020-01-20 19:20:14 UTC Comment hidden (obsolete)
Comment 16 Tomás Cohen Arazi 2020-01-20 20:01:10 UTC Comment hidden (obsolete)
Comment 17 Jonathan Druart 2020-01-22 16:20:24 UTC Comment hidden (obsolete)
Comment 18 Tomás Cohen Arazi 2020-01-31 12:21:18 UTC Comment hidden (obsolete)
Comment 19 Tomás Cohen Arazi 2020-01-31 13:23:55 UTC Comment hidden (obsolete)
Comment 20 Tomás Cohen Arazi 2020-01-31 14:45:43 UTC Comment hidden (obsolete)
Comment 21 Agustín Moyano 2020-02-27 23:53:02 UTC Comment hidden (obsolete)
Comment 22 Agustín Moyano 2020-02-27 23:53:09 UTC Comment hidden (obsolete)
Comment 23 Agustín Moyano 2020-02-27 23:54:31 UTC Comment hidden (obsolete)
Comment 24 Tomás Cohen Arazi 2020-03-04 18:29:20 UTC Comment hidden (obsolete)
Comment 25 Tomás Cohen Arazi 2020-03-10 19:24:05 UTC
Created attachment 100475 [details] [review]
Bug 20212: Add missing entried on schema files
Comment 26 Tomás Cohen Arazi 2020-03-10 19:24:09 UTC
Created attachment 100476 [details] [review]
Bug 20212: Add more embeddable objects to orders
Comment 27 Tomás Cohen Arazi 2020-03-10 19:24:14 UTC
Created attachment 100477 [details] [review]
Bug 20212: Allow filtering orders on ISBN

This patch adapts the code from the list() sub so it manipulates the
query parameters and the embed header so:
- the biblioitem relationship is prefetch
- any queries on biblio.isbn are correctly translated into search on the
  biblioitems table.
Comment 28 Tomás Cohen Arazi 2020-03-10 19:24:19 UTC
Created attachment 100478 [details] [review]
Bug 20212: Use API to render orders datatable
Comment 29 Tomás Cohen Arazi 2020-03-10 19:28:01 UTC
I've set it NSO to gather some attention. This is not ready yet (cleanup is required for that). But The only way I found of testing it is displaying both tables (the original and the API-driven so the behaviour can be compared).

The patchset touches histsearch.pl but only the table displayed when adding an invoice is complete-ish.

The only missing feature is the in-column filtering, but the main technical challenge is solved (filtering on bilbioitems.isbn).

Please test and provide feedback!
Comment 30 Tomás Cohen Arazi 2020-03-11 13:37:52 UTC Comment hidden (obsolete)
Comment 31 Tomás Cohen Arazi 2020-03-11 13:37:56 UTC Comment hidden (obsolete)
Comment 32 Tomás Cohen Arazi 2020-03-11 13:38:01 UTC Comment hidden (obsolete)
Comment 33 Tomás Cohen Arazi 2020-03-11 13:38:05 UTC Comment hidden (obsolete)
Comment 34 Tomás Cohen Arazi 2020-03-11 18:49:23 UTC
Created attachment 100600 [details] [review]
Bug 20212: Add missing entries on schema files

This patch adds the missing koha_object(s)_class methods to the related
schema files. It also adds a 'bilbioitem' relationship to the Biblio
class as required for being able to prefetch that table information.
Comment 35 Tomás Cohen Arazi 2020-03-11 18:49:26 UTC
Created attachment 100601 [details] [review]
Bug 20212: Add more embeddable objects to orders
Comment 36 Tomás Cohen Arazi 2020-03-11 18:49:30 UTC
Created attachment 100602 [details] [review]
Bug 20212: Allow filtering orders on biblioitems fields

This patch adapts the code from the list() sub so it manipulates the
query parameters and the embed header so:
- the biblioitem relationship is prefetch
- any queries on biblio.isbn and biblio.ean are correctly translated into search on the
  biblioitems table.
Comment 37 Tomás Cohen Arazi 2020-03-11 18:49:35 UTC Comment hidden (obsolete)
Comment 38 Tomás Cohen Arazi 2020-03-11 20:11:01 UTC
Created attachment 100605 [details] [review]
Bug 20212: Use API to render orders datatable
Comment 39 Tomás Cohen Arazi 2020-03-11 20:11:06 UTC
Created attachment 100606 [details] [review]
Bug 20212: Clean parcel.pl

Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Comment 40 Tomás Cohen Arazi 2020-03-11 20:13:26 UTC
So this is ready for real testing. I cleaned the code related to listing the pending orders from parcel.pl as well. If we agree on this approach, the same API and code can be reused in all places that display orders! YAY
Comment 41 Tomás Cohen Arazi 2020-03-12 15:25:51 UTC
Created attachment 100643 [details] [review]
Bug 20212: Use API to render orders datatable
Comment 42 Martin Renvoize 2020-03-18 09:02:19 UTC
Think I'm missing where this requires bug 24455?
Comment 43 Tomás Cohen Arazi 2020-03-19 12:12:53 UTC
(In reply to Martin Renvoize from comment #42)
> Think I'm missing where this requires bug 24455?

It doesn't, removed the dependency.
Comment 44 Tomás Cohen Arazi 2020-03-20 19:28:00 UTC
Created attachment 101320 [details] [review]
Bug 20212: Add missing entries on schema files

This patch adds the missing koha_object(s)_class methods to the related
schema files. It also adds a 'bilbioitem' relationship to the Biblio
class as required for being able to prefetch that table information.
Comment 45 Tomás Cohen Arazi 2020-03-22 01:39:06 UTC
I've got an interesting DB with lots of real-life acq data, and:
- There are some use cases that I didn't consider
- Some combinations of the data produce error 500.
Comment 46 Tomás Cohen Arazi 2020-04-24 13:27:19 UTC
Created attachment 103684 [details] [review]
Bug 20212: Add more embeddable objects to orders
Comment 47 Tomás Cohen Arazi 2020-04-24 13:27:38 UTC
Created attachment 103685 [details] [review]
Bug 20212: Allow filtering orders on biblioitems fields

This patch adapts the code from the list() sub so it manipulates the
query parameters and the embed header so:
- the biblioitem relationship is prefetch
- any queries on biblio.isbn and biblio.ean are correctly translated into search on the
  biblioitems table.
Comment 48 Tomás Cohen Arazi 2020-04-24 13:27:57 UTC
Created attachment 103686 [details] [review]
Bug 20212: Clean parcel.pl

Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Comment 49 Tomás Cohen Arazi 2020-04-24 13:28:08 UTC
Created attachment 103687 [details] [review]
Bug 20212: Use API to render orders datatable
Comment 50 Tomás Cohen Arazi 2020-04-24 13:28:22 UTC
Created attachment 103688 [details] [review]
Bug 20212: Add missing entries on schema files

This patch adds the missing koha_object(s)_class methods to the related
schema files. It also adds a 'bilbioitem' relationship to the Biblio
class as required for being able to prefetch that table information.