| Summary: | Broken link to return to record after batch item modification or deletion | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Andrew Fuerste-Henry <andrew> |
| Component: | Cataloging | Assignee: | Nick Clemens (kidclamp) <nick> |
| Status: | CLOSED FIXED | QA Contact: | Marcel de Rooy <m.de.rooy> |
| Severity: | normal | ||
| Priority: | P5 - low | CC: | 1joynelson, hayleypelham, kelly, lisettepalouse+koha, lucas, m.de.rooy, nick |
| Version: | Main | ||
| Hardware: | All | ||
| OS: | All | ||
| Change sponsored?: | --- | Patch complexity: | Small patch |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: |
20.05.00, 19.11.03, 19.05.08, 18.11.14
|
|
| Circulation function: | |||
| Bug Depends on: | 23987 | ||
| Bug Blocks: | |||
| Attachments: |
Bug 24423: Add biblionumber to modify items link
Bug 24423: Add biblionumber to modify items link Bug 24236: Fix pagination to use query_cgi Bug 24423: Add biblionumber to modify items link Bug 24423: Fix for deletion - cleanup accidental debug inclusiopm Bug 24423: Add biblionumber to modify items link |
||
|
Description
Andrew Fuerste-Henry
2020-01-14 22:28:20 UTC
Created attachment 97398 [details] [review] Bug 24423: Add biblionumber to modify items link To test: - Find/create a bib with at least one item - From detail.pl, use the checkboxes in the holdings table to select one or more items - click the "Modify Selected Items" link just above the holdings table to take your item(s) to batch modification - Change something and click save - Observe that the Return to the Record link points to a url without a biblionumber: "/cgi-bin/koha/catalogue/detail.pl?biblionumber=" - Apply patch - Repeat - The link now works! Created attachment 97405 [details] [review] Bug 24423: Add biblionumber to modify items link To test: - Find/create a bib with at least one item - From detail.pl, use the checkboxes in the holdings table to select one or more items - click the "Modify Selected Items" link just above the holdings table to take your item(s) to batch modification - Change something and click save - Observe that the Return to the Record link points to a url without a biblionumber: "/cgi-bin/koha/catalogue/detail.pl?biblionumber=" - Apply patch - Repeat - The link now works! Signed-off-by: Nick Clemens <nick@bywatersolutions.com> Created attachment 97406 [details] [review] Bug 24236: Fix pagination to use query_cgi This is still wrong, we should use page-numbers.inc, but that is a larger refactoring This patch fixes non-QueryParser searches by simple getting an using the escaped query (query_cgi) For QueryParser, we do what the QP code does, just uri escape the query - the way that SimpleSearch does the query parsing instead of the usual buildQuery suggest to me that we should probably switch all of this to use the general Zebra search. The issues with reservoir should be their own bug To test: 1 - Search for cat in cataloging search 2 - Get results and see you can paginate 3 - Search for "cat" 4 - Get results but subsequent pages empty 5 - Apply patch 6 - Repeat search for "cat" 7 - You can paginate 8 - Enable UseQueryParser syspref (don't worry about installing) 9 - Confirm can still search with quotes and paginate Signed-off-by: Nick Clemens <nick@bywatersolutions.com> Comment on attachment 97406 [details] [review] Bug 24236: Fix pagination to use query_cgi This was incorrectly signed off to the wrong patch during a sandbox webinar. Created attachment 97435 [details] [review] Bug 24423: Add biblionumber to modify items link To test: - Find/create a bib with at least one item - From detail.pl, use the checkboxes in the holdings table to select one or more items - Click the "Modify Selected Items" link just above the holdings table to take your item(s) to batch modification - Change something and click save - Observe that the Return to the Record link points to a url without a biblionumber: "/cgi-bin/koha/catalogue/detail.pl?biblionumber=" - Apply patch - Repeat - The link now works! Signed-off-by: Nick Clemens <nick@bywatersolutions.com> Signed-off-by: David Nind <david@davidnind.com> Created attachment 97437 [details] [review] Bug 24423: Fix for deletion - cleanup accidental debug inclusiopm To test: Repeat prior test plan with 'Delete selected' Looking here Created attachment 97475 [details] [review] Bug 24423: Add biblionumber to modify items link To test: - Find/create a bib with at least one item - From detail.pl, use the checkboxes in the holdings table to select one or more items - click the "Modify Selected Items" link just above the holdings table to take your item(s) to batch modification - Change something and click save - Observe that the Return to the Record link points to a url without a biblionumber: "/cgi-bin/koha/catalogue/detail.pl?biblionumber=" - Apply patch - Repeat - The link now works! Signed-off-by: Nick Clemens <nick@bywatersolutions.com> Signed-off-by: David Nind <david@davidnind.com> Bug 24423: Fix for deletion - cleanup accidental debug inclusiopm To test: Repeat prior test plan with 'Delete selected' Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Nice work everyone! Pushed to master for 20.05 Pushed to 19.11.x branch for 19.11.03 Updated the title of this bug to reflect the fact that it also impacts batch item deletion. The patch fixes that, too. backported to 19.05.x for 19.05.08 Backported to 18.11.x for 18.11.14. *** Bug 24743 has been marked as a duplicate of this bug. *** |