|
Description
Martin Renvoize (ashimema)
2020-01-16 16:48:56 UTC
Created attachment 97498 [details] [review] Bug 24436: Add 'Reserve' options to branchtransfers trigger Created attachment 97499 [details] [review] Bug 24436: Add handling for reserve transfer triggers Created attachment 97510 [details] [review] Bug 24436: Add 'Reserve' options to branchtransfers trigger Created attachment 97511 [details] [review] Bug 24436: Add handling for reserve transfer triggers Created attachment 97539 [details] [review] Bug 24436: Add 'Reserve' options to branchtransfers trigger Created attachment 97540 [details] [review] Bug 24436: Add handling for reserve transfer triggers Created attachment 100628 [details] [review] Bug 24436: Add 'Reserve' options to branchtransfers trigger Signed-off-by: Nick Clemens <nick@bywatersolutions.com> Created attachment 100629 [details] [review] Bug 24436: Add handling for reserve transfer triggers To test: 1 - Place a hold for pickup at a different branch than you are signed in at on an item owned by current branch 2 - Check in the item 3 - Confirm the transfer 4 - Check the branchtransfers table and note the reason is 'Reserve' 5 - Set the preference CanMarkHoldsToPullAsLost to allow 6 - Place a hold on an item at branch you are singed in at 7 - Ensure you are not using strict sql modes (bug 22431) 8 - Go to Circulation->Holds to pull 9 - Mark hold as lost 10 - Check branchtransfers and confirm reason is "LostReserve" 11 - Check in item from step 1 at the correct branch 12 - Go to Circulation->Holds awaiting pickup 13 - Cancel the reserve 14 - Check branchtransfers and confirm reason is "CancelReserve" Signed-off-by: Nick Clemens <nick@bywatersolutions.com> Created attachment 101087 [details] [review] Bug 24436: Add 'Reserve' options to branchtransfers trigger Signed-off-by: Nick Clemens <nick@bywatersolutions.com> Created attachment 101088 [details] [review] Bug 24436: Add handling for reserve transfer triggers To test: 1 - Place a hold for pickup at a different branch than you are signed in at on an item owned by current branch 2 - Check in the item 3 - Confirm the transfer 4 - Check the branchtransfers table and note the reason is 'Reserve' 5 - Set the preference CanMarkHoldsToPullAsLost to allow 6 - Place a hold on an item at branch you are singed in at 7 - Ensure you are not using strict sql modes (bug 22431) 8 - Go to Circulation->Holds to pull 9 - Mark hold as lost 10 - Check branchtransfers and confirm reason is "LostReserve" 11 - Check in item from step 1 at the correct branch 12 - Go to Circulation->Holds awaiting pickup 13 - Cancel the reserve 14 - Check branchtransfers and confirm reason is "CancelReserve" Signed-off-by: Nick Clemens <nick@bywatersolutions.com> Rebased Nice work everyone! Pushed to master for 20.05 not backported to 19.11.x |