Bug 24436

Summary: Record if a transfer was triggered by a 'hold'
Product: Koha Reporter: Martin Renvoize <martin.renvoize>
Component: CirculationAssignee: Martin Renvoize <martin.renvoize>
Status: CLOSED FIXED QA Contact: Testopia <testopia>
Severity: enhancement    
Priority: P5 - low CC: 1joynelson, gmcharlt, katrin.fischer, koha-bugs, kyle.m.hall, testopia
Version: Main   
Hardware: All   
OS: All   
Change sponsored?: --- Patch complexity: ---
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:
20.05.00
Bug Depends on: 24299    
Bug Blocks: 24297    
Attachments: Bug 24436: Add 'Reserve' options to branchtransfers trigger
Bug 24436: Add handling for reserve transfer triggers
Bug 24436: Add 'Reserve' options to branchtransfers trigger
Bug 24436: Add handling for reserve transfer triggers
Bug 24436: Add 'Reserve' options to branchtransfers trigger
Bug 24436: Add handling for reserve transfer triggers
Bug 24436: Add 'Reserve' options to branchtransfers trigger
Bug 24436: Add handling for reserve transfer triggers
Bug 24436: Add 'Reserve' options to branchtransfers trigger
Bug 24436: Add handling for reserve transfer triggers

Description Martin Renvoize 2020-01-16 16:48:56 UTC
Using the new 'trigger' field in branchtransfers to record if a transfer was added by a reserve.
Comment 1 Martin Renvoize 2020-01-17 11:21:41 UTC
Created attachment 97498 [details] [review]
Bug 24436: Add 'Reserve' options to branchtransfers trigger
Comment 2 Martin Renvoize 2020-01-17 11:21:44 UTC
Created attachment 97499 [details] [review]
Bug 24436: Add handling for reserve transfer triggers
Comment 3 Martin Renvoize 2020-01-17 11:52:15 UTC
Created attachment 97510 [details] [review]
Bug 24436: Add 'Reserve' options to branchtransfers trigger
Comment 4 Martin Renvoize 2020-01-17 11:52:18 UTC
Created attachment 97511 [details] [review]
Bug 24436: Add handling for reserve transfer triggers
Comment 5 Martin Renvoize 2020-01-17 16:02:18 UTC
Created attachment 97539 [details] [review]
Bug 24436: Add 'Reserve' options to branchtransfers trigger
Comment 6 Martin Renvoize 2020-01-17 16:02:21 UTC
Created attachment 97540 [details] [review]
Bug 24436: Add handling for reserve transfer triggers
Comment 7 Nick Clemens 2020-03-12 12:52:10 UTC
Created attachment 100628 [details] [review]
Bug 24436: Add 'Reserve' options to branchtransfers trigger

Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Comment 8 Nick Clemens 2020-03-12 12:52:12 UTC
Created attachment 100629 [details] [review]
Bug 24436: Add handling for reserve transfer triggers

To test:
1 - Place a hold for pickup at a different branch than you are signed in at on an item owned by current branch
2 - Check in the item
3 - Confirm the transfer
4 - Check the branchtransfers table and note the reason is 'Reserve'
5 - Set the preference CanMarkHoldsToPullAsLost to allow
6 - Place a hold on an item at branch you are singed in at
7 - Ensure you are not using strict sql modes (bug 22431)
8 - Go to Circulation->Holds to pull
9 - Mark hold as lost
10 - Check branchtransfers and confirm reason is "LostReserve"
11 - Check in item from step 1 at the correct branch
12 - Go to Circulation->Holds awaiting pickup
13 - Cancel the reserve
14 - Check branchtransfers and confirm reason is "CancelReserve"

Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Comment 9 Martin Renvoize 2020-03-20 12:01:37 UTC
Created attachment 101087 [details] [review]
Bug 24436: Add 'Reserve' options to branchtransfers trigger

Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Comment 10 Martin Renvoize 2020-03-20 12:01:40 UTC
Created attachment 101088 [details] [review]
Bug 24436: Add handling for reserve transfer triggers

To test:
1 - Place a hold for pickup at a different branch than you are signed in at on an item owned by current branch
2 - Check in the item
3 - Confirm the transfer
4 - Check the branchtransfers table and note the reason is 'Reserve'
5 - Set the preference CanMarkHoldsToPullAsLost to allow
6 - Place a hold on an item at branch you are singed in at
7 - Ensure you are not using strict sql modes (bug 22431)
8 - Go to Circulation->Holds to pull
9 - Mark hold as lost
10 - Check branchtransfers and confirm reason is "LostReserve"
11 - Check in item from step 1 at the correct branch
12 - Go to Circulation->Holds awaiting pickup
13 - Cancel the reserve
14 - Check branchtransfers and confirm reason is "CancelReserve"

Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Comment 11 Martin Renvoize 2020-03-20 12:01:53 UTC
Rebased
Comment 12 Martin Renvoize 2020-03-20 16:04:56 UTC
Nice work everyone!

Pushed to master for 20.05
Comment 13 Joy Nelson 2020-04-03 21:15:34 UTC
not backported to 19.11.x