Use the new 'trigger' field in branchtransfers to record if a transfer was added by the 'rotating collection' tool.
Created attachment 97464 [details] [review] Bug 24299: Add 'RotatingCollection' branchtransfer trigger
Created attachment 97465 [details] [review] Bug 24299: Record 'RotatingCollection' as a transfer trigger
Created attachment 97508 [details] [review] Bug 24299: Add 'RotatingCollection' branchtransfer trigger
Created attachment 97509 [details] [review] Bug 24299: Record 'RotatingCollection' as a transfer trigger
Created attachment 97537 [details] [review] Bug 24299: Add 'RotatingCollection' branchtransfer trigger
Created attachment 97538 [details] [review] Bug 24299: Record 'RotatingCollection' as a transfer trigger
Created attachment 98295 [details] [review] Bug 24299: Add 'RotatingCollection' branchtransfer trigger
Created attachment 98296 [details] [review] Bug 24299: Record 'RotatingCollection' as a transfer trigger
Created attachment 100626 [details] [review] Bug 24299: Add 'RotatingCollection' branchtransfer trigger Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Created attachment 100627 [details] [review] Bug 24299: Record 'RotatingCollection' as a transfer trigger Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Test coverage for transferbook and TransferCollection wouldn't hurt
(In reply to Nick Clemens from comment #11) > Test coverage for transferbook and TransferCollection wouldn't hurt Added bug 24901 to add basic test coverage for transferbook.. would be great to get a second pair of eyes as I was rather surprised by how the functionality of the method actually worked once I started writing tests :(.. The POD is completely wrong. I'll add a little followup here to catch the additional field being populated
Created attachment 101075 [details] [review] Bug 24299: Add 'RotatingCollection' branchtransfer trigger This patch adds the RotatingCollection value to the database enum for branchtransfer.reason
Created attachment 101076 [details] [review] Bug 24299: Record 'RotatingCollection' as a transfer trigger This patch adds support for passing a trigger to C4::Circulation::transferbook and passes 'RotatingCollection' to it when called inside the rotating collections routine. Test plan: 1/ Perform a rotating collection transfer operations 2/ Check the database for instances of 'RotatingCollection' in the branchtransfers.reason field. 3/ Signoff
Created attachment 101077 [details] [review] Bug 24299: Add Unit test for 'reason' in transferbook Test plan 1/ Run test and verify it passes 2/ Signoff
Created attachment 101083 [details] [review] Bug 24299: Add Unit test for 'reason' in transferbook Test plan 1/ Run test and verify it passes 2/ Signoff
Created attachment 101084 [details] [review] Bug 24299: Add 'RotatingCollection' branchtransfer trigger This patch adds the RotatingCollection value to the database enum for branchtransfer.reason Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Created attachment 101085 [details] [review] Bug 24299: Record 'RotatingCollection' as a transfer trigger This patch adds support for passing a trigger to C4::Circulation::transferbook and passes 'RotatingCollection' to it when called inside the rotating collections routine. Test plan: 1/ Perform a rotating collection transfer operations 2/ Check the database for instances of 'RotatingCollection' in the branchtransfers.reason field. 3/ Signoff Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Created attachment 101086 [details] [review] Bug 24299: Add Unit test for 'reason' in transferbook Test plan 1/ Run test and verify it passes 2/ Signoff
Created attachment 101097 [details] [review] Bug 24299: Add Unit test for 'reason' in transferbook Test plan 1/ Run test and verify it passes 2/ Signoff Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Small patchset in this chain, works as expected and tested, passing QA. Don't forget to pull the Schema changes out of first patch and regenerate
Nice work everyone! Pushed to master for 20.05
enhancement not backported to 19.11.x