Bug 24460

Summary: Modifying item's lost state returns issued item without it being logged
Product: Koha Reporter: Joonas Kylmälä <joonas.kylmala>
Component: CatalogingAssignee: Bugs List <koha-bugs>
Status: NEW --- QA Contact: Testopia <testopia>
Severity: minor    
Priority: P5 - low CC: andrew, m.de.rooy
Version: Main   
Hardware: All   
OS: All   
Change sponsored?: --- Patch complexity: ---
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:
Circulation function:

Description Joonas Kylmälä 2020-01-20 12:28:48 UTC 
If the sub MarkIssueReturned is called it returns checked-in item without logging it to action_logs table:

>        # And finally delete the issue
>        $issue->delete;

Elsewhere in the codebase returns are logged:

>        logaction("CIRCULATION", "RETURN", $borrowernumber, $item->itemnumber)
>            if C4::Context->preference("ReturnLog");

MarkIssueReturned should also log the return to action log so that if any mistakes are made when changing the item status to lost or not lost they can be tracked by the librarians.

MarkIssueReturned() gets called by the web page catalogue/updateitem.pl if the lost status is changed.
Comment 1 Andrew Fuerste-Henry 2020-11-14 20:23:53 UTC 
+1 on this. Logging returns due to an item being marked lost would make a much cleaner data trail.
Comment 2 Andrew Fuerste-Henry 2020-11-14 20:26:13 UTC 
Additionally, we should make sure this also logs the end of an issue when a lost fee is paid / written off, for libraries that are not marking lost items as returned when they go to lost.