Bug 24460 - Modifying item's lost state returns issued item without it being logged
Summary: Modifying item's lost state returns issued item without it being logged
Status: NEW
Alias: None
Product: Koha
Classification: Unclassified
Component: Cataloging (show other bugs)
Version: Main
Hardware: All All
: P5 - low minor
Assignee: Bugs List
QA Contact: Testopia
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2020-01-20 12:28 UTC by Joonas Kylmälä
Modified: 2020-11-14 20:26 UTC (History)
2 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
Circulation function:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Joonas Kylmälä 2020-01-20 12:28:48 UTC 
If the sub MarkIssueReturned is called it returns checked-in item without logging it to action_logs table:

>        # And finally delete the issue
>        $issue->delete;

Elsewhere in the codebase returns are logged:

>        logaction("CIRCULATION", "RETURN", $borrowernumber, $item->itemnumber)
>            if C4::Context->preference("ReturnLog");

MarkIssueReturned should also log the return to action log so that if any mistakes are made when changing the item status to lost or not lost they can be tracked by the librarians.

MarkIssueReturned() gets called by the web page catalogue/updateitem.pl if the lost status is changed.
Comment 1 Andrew Fuerste-Henry 2020-11-14 20:23:53 UTC 
+1 on this. Logging returns due to an item being marked lost would make a much cleaner data trail.
Comment 2 Andrew Fuerste-Henry 2020-11-14 20:26:13 UTC 
Additionally, we should make sure this also logs the end of an issue when a lost fee is paid / written off, for libraries that are not marking lost items as returned when they go to lost.