Summary: | Add to_api_mapping to Koha::Acquisition::BasketGroup | ||
---|---|---|---|
Product: | Koha | Reporter: | Tomás Cohen Arazi (tcohen) <tomascohen> |
Component: | REST API | Assignee: | Tomás Cohen Arazi (tcohen) <tomascohen> |
Status: | CLOSED FIXED | QA Contact: | |
Severity: | enhancement | ||
Priority: | P5 - low | CC: | 1joynelson, kyle, martin.renvoize, nicolas.legrand |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | Trivial patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: |
20.05.00
|
|
Circulation function: | |||
Bug Depends on: | |||
Bug Blocks: | 20212 | ||
Attachments: |
Bug 24461: Add to_api_mapping to Koha::Acquisition::BasketGroup
Bug 24461: Add to_api_mapping to Koha::Acquisition::BasketGroup Bug 24461: Add to_api_mapping to Koha::Acquisition::BasketGroup Bug 24461: Add to_api_mapping to Koha::Acquisition::BasketGroup |
Description
Tomás Cohen Arazi (tcohen)
2020-01-20 14:02:44 UTC
Created attachment 97623 [details] [review] Bug 24461: Add to_api_mapping to Koha::Acquisition::BasketGroup This patch adds to_api_mapping to the Koha::Acquistion::BasketGroup class. To test: 1. Compare the mapping with the one on the RFC => SUCCESS: They match 2. Sigh off :-D Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Created attachment 100278 [details] [review] Bug 24461: Add to_api_mapping to Koha::Acquisition::BasketGroup This patch adds to_api_mapping to the Koha::Acquistion::BasketGroup class. To test: 1. Compare the mapping with the one on the RFC => SUCCESS: They match 2. Sigh off :-D Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Looking good to me.. SO Created attachment 101536 [details] [review] Bug 24461: Add to_api_mapping to Koha::Acquisition::BasketGroup This patch adds to_api_mapping to the Koha::Acquistion::BasketGroup class. To test: 1. Compare the mapping with the one on the RFC => SUCCESS: They match 2. Sigh off :-D Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Amended patch: remove extra lines between methods koha_object[s]_class. That's how they are in other modules. Created attachment 101537 [details] [review] Bug 24461: Add to_api_mapping to Koha::Acquisition::BasketGroup This patch adds to_api_mapping to the Koha::Acquistion::BasketGroup class. To test: 1. Compare the mapping with the one on the RFC => SUCCESS: They match 2. Sigh off :-D Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Amended patch: remove extra lines between methods koha_object[s]_class. That's how they are in other modules. Nice work everyone! Pushed to master for 20.05 not backported to 19.11.x |