Summary: | Nothing happens when trying to add nothing to a list in staff | ||
---|---|---|---|
Product: | Koha | Reporter: | Katrin Fischer <katrin.fischer> |
Component: | Staff interface | Assignee: | Owen Leonard <oleonard> |
Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
Severity: | enhancement | ||
Priority: | P5 - low | CC: | 1joynelson, gmcharlt, lucas |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | Trivial patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: |
20.05.00, 19.11.06, 19.05.11
|
|
Circulation function: | |||
Attachments: |
Bug 24522: Show alert when trying to add nothing to a list in staff
Bug 24522: Show alert when trying to add nothing to a list in staff Bug 24522: Show alert when trying to add nothing to a list in staff |
Description
Katrin Fischer
2020-01-27 21:29:22 UTC
Created attachment 104090 [details] [review] Bug 24522: Show alert when trying to add nothing to a list in staff This patch modifies the JavaScript which handles the process of adding items to a list in the staff client. Error-handling is added in the case when a set of biblionumbers hasn't been passed to the vShelf function. To test, apply the patch and perform a catalog search in the staff client. On the search results page, select any list from the "Add to list" menu at the top of the search results table without checking any checkboxes. You should get an alert, "No item was selected." Also test that adding to a list works correctly after selecting one or more titles. Created attachment 104130 [details] [review] Bug 24522: Show alert when trying to add nothing to a list in staff This patch modifies the JavaScript which handles the process of adding items to a list in the staff client. Error-handling is added in the case when a set of biblionumbers hasn't been passed to the vShelf function. To test, apply the patch and perform a catalog search in the staff client. On the search results page, select any list from the "Add to list" menu at the top of the search results table without checking any checkboxes. You should get an alert, "No item was selected." Also test that adding to a list works correctly after selecting one or more titles. Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> Created attachment 104136 [details] [review] Bug 24522: Show alert when trying to add nothing to a list in staff This patch modifies the JavaScript which handles the process of adding items to a list in the staff client. Error-handling is added in the case when a set of biblionumbers hasn't been passed to the vShelf function. To test, apply the patch and perform a catalog search in the staff client. On the search results page, select any list from the "Add to list" menu at the top of the search results table without checking any checkboxes. You should get an alert, "No item was selected." Also test that adding to a list works correctly after selecting one or more titles. Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Nice work everyone! Pushed to master for 20.05 Backported to 19.11.x for 19.11.06 backported to 19.05.x for 19.05.11 |