Description
Julian Maurice
2020-01-31 10:13:12 UTC
Created attachment 98223 [details] [review] Bug 24552: Be compatible with Search::Elasticsearch 6.00 There is no need to specify the `client` param here because '5_0::Direct' is the default value for Search::Elasticsearch 5.x and it breaks when Search::Elasticsearch 6.x is installed Test plan: 1. Apply the patch 2. Make sure you have Search::Elasticsearch 5.x 3. Reload starman 4. Verify that search works 5. Install Search::Elasticsearch 6.x 6. Reload starman 7. Verify that search works Created attachment 98249 [details] [review] Bug 24552: Be compatible with Search::Elasticsearch 6.00 There is no need to specify the `client` param here because '5_0::Direct' is the default value for Search::Elasticsearch 5.x and it breaks when Search::Elasticsearch 6.x is installed Test plan: 1. Apply the patch 2. Make sure you have Search::Elasticsearch 5.x 3. Reload starman 4. Verify that search works 5. Install Search::Elasticsearch 6.x 6. Reload starman 7. Verify that search works Signed-off-by: Michal Denar <black23@gmail.com> increasing severiyy to fix broken jenkins https://jenkins.koha-community.org/job/Koha_Master_D10_Deps/5/consoleText koha_1 | Test Summary Report koha_1 | ------------------- koha_1 | t/db_dependent/Koha/SearchEngine/Elasticsearch/Indexer.t (Wstat: 2816 Tests: 2 Failed: 1) koha_1 | Failed test: 2 koha_1 | Non-zero exit status: 11 koha_1 | t/db_dependent/Koha/Patrons.t (Wstat: 512 Tests: 40 Failed: 2) koha_1 | Failed tests: 17-18 koha_1 | Non-zero exit status: 2 koha_1 | t/db_dependent/Koha/XSLT/Security.t (Wstat: 256 Tests: 8 Failed: 1) koha_1 | Failed test: 7 koha_1 | Non-zero exit status: 1 koha_1 | t/db_dependent/Koha/SearchEngine/Elasticsearch/Search.t (Wstat: 512 Tests: 4 Failed: 0) koha_1 | Non-zero exit status: 2 koha_1 | Parse errors: Bad plan. You planned 13 tests but ran 4. koha_1 | Files=499, Tests=13968, 2404.87 wallclock secs ( 4.84 usr 9.79 sys + 2334.25 cusr 768.49 csys = 3117.37 CPU) koha_1 | Result: FAIL *** Bug 24639 has been marked as a duplicate of this bug. *** Created attachment 100168 [details] [review] Bug 24552: Be compatible with Search::Elasticsearch 6.00 There is no need to specify the `client` param here because '5_0::Direct' is the default value for Search::Elasticsearch 5.x and it breaks when Search::Elasticsearch 6.x is installed Test plan: 1. Apply the patch 2. Make sure you have Search::Elasticsearch 5.x 3. Reload starman 4. Verify that search works 5. Install Search::Elasticsearch 6.x 6. Reload starman 7. Verify that search works Signed-off-by: Michal Denar <black23@gmail.com> Signed-off-by: Ere Maijala <ere.maijala@helsinki.fi> Created attachment 100179 [details] [review] Bug 24552: Be compatible with Search::Elasticsearch 6.00 There is no need to specify the `client` param here because '5_0::Direct' is the default value for Search::Elasticsearch 5.x and it breaks when Search::Elasticsearch 6.x is installed Test plan: 1. Apply the patch 2. Make sure you have Search::Elasticsearch 5.x 3. Reload starman 4. Verify that search works 5. Install Search::Elasticsearch 6.x 6. Reload starman 7. Verify that search works Signed-off-by: Michal Denar <black23@gmail.com> Signed-off-by: Ere Maijala <ere.maijala@helsinki.fi> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> Nice work everyone! Pushed to master for 20.05 Backported to 19.11.x for 19.11.05 backported to 19.05.x for 19.05.10 Not backporting Elasticsearch patches for 18.11.1x series - contact me if you'd like to discuss |