Summary: | UpdateItemLocationOnCheckin triggers SIP2 alert flag, even with checked_in_ok enabled | ||
---|---|---|---|
Product: | Koha | Reporter: | Kyle M Hall (khall) <kyle> |
Component: | SIP2 | Assignee: | Kyle M Hall (khall) <kyle> |
Status: | CLOSED FIXED | QA Contact: | Martin Renvoize (ashimema) <martin.renvoize> |
Severity: | minor | ||
Priority: | P5 - low | CC: | 1joynelson, colin.campbell, hayleypelham, lucas, martin.renvoize |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
GIT URL: | Change sponsored?: | --- | |
Patch complexity: | Trivial patch | Documentation contact: | |
Documentation submission: | Text to go in the release notes: | ||
Version(s) released in: |
20.05.00, 19.11.05, 19.05.10
|
Circulation function: | |
Attachments: |
Bug 24566: UpdateItemLocationOnCheckin triggers SIP2 alert flag, even with checked_in_ok enabled
Bug 24566: UpdateItemLocationOnCheckin triggers SIP2 alert flag, even with checked_in_ok enabled Bug 24566: UpdateItemLocationOnCheckin triggers SIP2 alert flag, even with checked_in_ok enabled |
Description
Kyle M Hall (khall)
2020-02-03 12:55:51 UTC
Created attachment 98290 [details] [review] Bug 24566: UpdateItemLocationOnCheckin triggers SIP2 alert flag, even with checked_in_ok enabled If UpdateItemLocationOnCheckin, it triggers an alert flag but cannot be acted on in the same way as LocalUse and thus should be removed in the same fashion. Test Plan: 1) Enable UpdateItemLocationOnCheckin and set it up to trigger at checkin for an item 2) Return that item via SIP2 3) Note the alert flag is set 4) Apply this patch 5) Repeat steps 1 and 2 6) The alert flag should not be set Created attachment 98291 [details] [review] Bug 24566: UpdateItemLocationOnCheckin triggers SIP2 alert flag, even with checked_in_ok enabled If UpdateItemLocationOnCheckin, it triggers an alert flag but cannot be acted on in the same way as LocalUse and thus should be removed in the same fashion. Test Plan: 1) Enable UpdateItemLocationOnCheckin and set it up to trigger at checkin for an item 2) Return that item via SIP2 3) Note the alert flag is set 4) Apply this patch 5) Repeat steps 1 and 2 6) The alert flag should not be set Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Kevin Cook <ILS@cedarparktexas.gov> Created attachment 101003 [details] [review] Bug 24566: UpdateItemLocationOnCheckin triggers SIP2 alert flag, even with checked_in_ok enabled If UpdateItemLocationOnCheckin, it triggers an alert flag but cannot be acted on in the same way as LocalUse and thus should be removed in the same fashion. Test Plan: 1) Enable UpdateItemLocationOnCheckin and set it up to trigger at checkin for an item 2) Return that item via SIP2 3) Note the alert flag is set 4) Apply this patch 5) Repeat steps 1 and 2 6) The alert flag should not be set Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Kevin Cook <ILS@cedarparktexas.gov> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Trivial and clear fix.. no QA script failures.. Passing QA Nice work everyone! Pushed to master for 20.05 backported to 19.11.x branch for 19.11.05 backported to 19.05.x for 19.05.10 Minor patch will not be backported to 18.11.x series |