Summary: | Phase out jquery.cookie.js: MARC Frameworks | ||
---|---|---|---|
Product: | Koha | Reporter: | Owen Leonard <oleonard> |
Component: | Templates | Assignee: | Owen Leonard <oleonard> |
Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
Severity: | minor | ||
Priority: | P5 - low | CC: | 1joynelson, lucas, martin.renvoize, testopia |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | Trivial patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: |
20.05.00, 19.11.04, 19.05.09
|
|
Circulation function: | |||
Bug Depends on: | 23944 | ||
Bug Blocks: | 27750 | ||
Attachments: |
Bug 23947: Phase out jquery.cookie.js: MARC Frameworks
Bug 23947: Phase out jquery.cookie.js: MARC Frameworks Bug 23947: Phase out jquery.cookie.js: MARC Frameworks |
Description
Owen Leonard
2020-02-10 17:57:09 UTC
Created attachment 98677 [details] [review] Bug 23947: Phase out jquery.cookie.js: MARC Frameworks This patch removes the use of the jquery.cookie plugin on the MARC Frameworks page and replaces it with a call to the new js-cookie library. To test, apply the patch and go to Administration -> MARC bibliographic frameworks. - Choose the 'MARC structure' menu item for one of the frameworks listed. - On the page which lists the tags in the framework, check the box labeled "Display only used tags/subfields." The page should reload. - The checkbox should remain checked and the list of tags should now show only used tags. - Uncheck the checkbox and the page should reload again. You can also follow the changes to the cookie using the browser's developer console. Look for a cookie named 'marctagstructure_selectdisplay' and confirm that the value flips from 0 to 1 and back. https://developer.mozilla.org/en-US/docs/Tools/Storage_Inspector https://developers.google.com/web/tools/chrome-devtools/storage/cookies Created attachment 98920 [details] [review] Bug 23947: Phase out jquery.cookie.js: MARC Frameworks This patch removes the use of the jquery.cookie plugin on the MARC Frameworks page and replaces it with a call to the new js-cookie library. To test, apply the patch and go to Administration -> MARC bibliographic frameworks. - Choose the 'MARC structure' menu item for one of the frameworks listed. - On the page which lists the tags in the framework, check the box labeled "Display only used tags/subfields." The page should reload. - The checkbox should remain checked and the list of tags should now show only used tags. - Uncheck the checkbox and the page should reload again. You can also follow the changes to the cookie using the browser's developer console. Look for a cookie named 'marctagstructure_selectdisplay' and confirm that the value flips from 0 to 1 and back. https://developer.mozilla.org/en-US/docs/Tools/Storage_Inspector https://developers.google.com/web/tools/chrome-devtools/storage/cookies https://bugs.koha-community.org/show_bug.cgi?id=24619 Signed-off-by: David Nind <david@davidnind.com> Created attachment 98961 [details] [review] Bug 23947: Phase out jquery.cookie.js: MARC Frameworks This patch removes the use of the jquery.cookie plugin on the MARC Frameworks page and replaces it with a call to the new js-cookie library. To test, apply the patch and go to Administration -> MARC bibliographic frameworks. - Choose the 'MARC structure' menu item for one of the frameworks listed. - On the page which lists the tags in the framework, check the box labeled "Display only used tags/subfields." The page should reload. - The checkbox should remain checked and the list of tags should now show only used tags. - Uncheck the checkbox and the page should reload again. You can also follow the changes to the cookie using the browser's developer console. Look for a cookie named 'marctagstructure_selectdisplay' and confirm that the value flips from 0 to 1 and back. https://developer.mozilla.org/en-US/docs/Tools/Storage_Inspector https://developers.google.com/web/tools/chrome-devtools/storage/cookies https://bugs.koha-community.org/show_bug.cgi?id=24619 Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Nice work everyone! Pushed to master for 20.05 Pushed to 19.11.x for 19.11.04 backported to 19.05.x for 19.05.09 |